Received-SPF: pass (google.com: domain of linux-kernel+bounces-76179-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 22 Feb 2024 10:05:50 +0100
Message-ID: <87sf1k6f81.wl-tiwai@suse.de>
From: Takashi Iwai <tiwai@suse.de>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	linux-sound@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] ALSA: echoaudio: remove redundant assignment to variable clock
In-Reply-To: <20240221113809.3410109-1-colin.i.king@gmail.com>
References: <20240221113809.3410109-1-colin.i.king@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
Precedence: bulk
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII

On Wed, 21 Feb 2024 12:38:09 +0100,
Colin Ian King wrote:
> 
> The variable clock is being assigned a value that is never read,
> it is being re-assigned a new value in every case in the following
> switch statement. The assignment is redundant and can be removed.
> 
> Cleans up clang scan build warning:
> sound/pci/echoaudio/echoaudio_3g.c:277:2: warning: Value stored
> to 'clock' is never read [deadcode.DeadStores]
> 
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>

Thanks, applied.


Takashi