Received-SPF: pass (google.com: domain of linux-kernel+bounces-76194-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240129054551.57728-1-ioworker0@gmail.com> <CAK1f24keWtJNVv37r2vNsqnmMLRMvF-F76WR5RD_Y-BbAgEaYQ@mail.gmail.com>
 <CAK1f24nk19eciysFqvTd=rqpiKePhstDWEEQ_mvT89WCDNrWNQ@mail.gmail.com> <84fc211a-075d-44c7-a4c3-698931b6dc7c@redhat.com>
In-Reply-To: <84fc211a-075d-44c7-a4c3-698931b6dc7c@redhat.com>
From: Lance Yang <ioworker0@gmail.com>
Date: Thu, 22 Feb 2024 17:12:00 +0800
Message-ID: <CAK1f24kL_XHsOJ-m30t17bSBnV9wpam33Hmcpf7baT87Yt5FrA@mail.gmail.com>
Subject: Re: [PATCH 1/1] mm/khugepaged: bypassing unnecessary scans with
 MMF_DISABLE_THP check
To: David Hildenbrand <david@redhat.com>
Cc: akpm@linux-foundation.org, mhocko@suse.com, zokeefe@google.com, 
	songmuchun@bytedance.com, shy828301@gmail.com, peterx@redhat.com, 
	minchan@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Thanks, David!

On Thu, Feb 22, 2024 at 4:51=E2=80=AFPM David Hildenbrand <david@redhat.com=
> wrote:
>
> On 22.02.24 08:51, Lance Yang wrote:
> > Hey,
> >
> > On an Intel Core i5 CPU, the time taken by
> > khugepaged to scan the address space of
> > the process, which has been set with the
> > MMF_DISABLE_THP flag after being added
> > to the mm_slots list, is as follows (shorter is better):
> >
> > VMA Count |   Old   |   New   |  Change
> > ---------------------------------------
> >      50     |   23us  |    9us  |  -60.9%
> >     100     |   32us  |    9us  |  -71.9%
> >     200     |   44us  |    9us  |  -79.5%
> >     400     |   75us  |    9us  |  -88.0%
> >     800     |   98us  |    9us  |  -90.8%
> >
> > IIUC, once the count of VMAs for the process
> > exceeds page_to_scan, khugepaged needs to
> > wait for scan_sleep_millisecs ms before scanning
> > the next process. IMO, unnecessary scans could
> > actually be skipped with a very inexpensive
> > mm->flags check in this case.
>
> FWIW
>
> Acked-by: David Hildenbrand <david@redhat.com>
>
> --
> Cheers,
>
> David / dhildenb
>