Received-SPF: pass (google.com: domain of linux-kernel+bounces-76357-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <fbdcd6e6-9d57-47d8-a462-908a03b373ea@quicinc.com>
Date: Thu, 22 Feb 2024 16:20:05 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 3/4] dt-bindings: interconnect: add clock property to
 configure QoS on SC7280
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, <djakov@kernel.org>
CC: <rafael@kernel.org>, <corbet@lwn.net>, <linux-pm@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_viveka@quicinc.com>, <peterz@infradead.org>,
        <quic_mdtipton@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
        <konrad.dybcio@linaro.org>
References: <20240205145606.16936-1-quic_okukatla@quicinc.com>
 <20240205145606.16936-4-quic_okukatla@quicinc.com>
 <e473937e-2d8e-47e3-bffd-025b87769335@linaro.org>
From: Odelu Kukatla <quic_okukatla@quicinc.com>
In-Reply-To: <e473937e-2d8e-47e3-bffd-025b87769335@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 2/5/2024 8:40 PM, Krzysztof Kozlowski wrote:
> On 05/02/2024 15:56, Odelu Kukatla wrote:
>> Added clock property to enable clocks required for accessing
>> qos registers.
> 
> I have no idea how you came up with that CC list. It makes no sense.
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline), work on fork of kernel
> (don't, instead use mainline) or you ignore some maintainers (really
> don't). Just use b4 and everything should be fine, although remember
> about `b4 prep --auto-to-cc` if you added new patches to the patchset.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
> 
> Please kindly resend and include all necessary To/Cc entries. Tomorrow.
> 
> Best regards,
> Krzysztof
> 

Thanks for your comments. I used latest tree only, but looks like i made a mistake while sending it.
I will use scripts/get_maintainer.pl script to get the list for next revision with other's comments addressed.

Thanks,
Odelu