Received-SPF: pass (google.com: domain of linux-kernel+bounces-76367-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <ddef6339-6a37-4048-80f0-7c008ec51cf0@quicinc.com>
Date: Thu, 22 Feb 2024 16:24:46 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 0/4] Add support for QoS configuration
Content-Language: en-US
To: Konrad Dybcio <konrad.dybcio@linaro.org>, <djakov@kernel.org>
CC: <rafael@kernel.org>, <corbet@lwn.net>, <linux-pm@vger.kernel.org>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <quic_viveka@quicinc.com>, <peterz@infradead.org>,
        <quic_mdtipton@quicinc.com>, <linux-arm-msm@vger.kernel.org>,
        <krzysztof.kozlowski@linaro.org>, <quic_rlaggysh@quicinc.com>
References: <20240205145606.16936-1-quic_okukatla@quicinc.com>
 <8189e50a-290c-494d-af42-a954a5d231ea@linaro.org>
From: Odelu Kukatla <quic_okukatla@quicinc.com>
In-Reply-To: <8189e50a-290c-494d-af42-a954a5d231ea@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit


On 2/6/2024 2:37 PM, Konrad Dybcio wrote:
> 
> 
> On 2/5/24 15:56, Odelu Kukatla wrote:
>> This series adds QoS support for QNOC type device which can be found on
>> SC7280 platform. It adds support for programming priority,
>> priority forward disable and urgency forwarding. This helps in
>> priortizing the traffic originating from different interconnect masters
>> at NOC(Network On Chip).
>>
>> Changes in v2:
>>   - Updated regmap_update to make use GENMASK and FIELD_PREP.
>>   - Removed the regmap structure from qcom_icc_node.
>>   - Made qcom_icc_rpmh_configure_qos() static
>>   - Removed qcom_icc_rpmh_map() API, inlined the code in probe
>>     function.
>>   - Updated declarations to reverse christmas tree fashion.
> 
> You ignored some of my previous review comments without a response.
> 
> Konrad

Thanks Konrad! i replied to all of your comments.
I will send V3 with all the comments addressed.

Thanks,
Odelu