Received-SPF: pass (google.com: domain of linux-kernel+bounces-76447-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 22 Feb 2024 12:50:32 +0100
From: Jan Kara <jack@suse.cz>
To: Oliver Sang <oliver.sang@intel.com>
Cc: Jan Kara <jack@suse.cz>, oe-lkp@lists.linux.dev, lkp@intel.com,
	linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <willy@infradead.org>,
	Guo Xuenan <guoxuenan@huawei.com>, linux-fsdevel@vger.kernel.org,
	ying.huang@intel.com, feng.tang@intel.com, fengwei.yin@intel.com
Subject: Re: [linus:master] [readahead]  ab4443fe3c:
 vm-scalability.throughput -21.4% regression
Message-ID: <20240222115032.u5h2phfxpn77lu5a@quack3>
References: <202402201642.c8d6bbc3-oliver.sang@intel.com>
 <20240221111425.ozdozcbl3konmkov@quack3>
 <ZdakRFhEouIF5o6D@xsang-OptiPlex-9020>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZdakRFhEouIF5o6D@xsang-OptiPlex-9020>

Hello,

On Thu 22-02-24 09:32:52, Oliver Sang wrote:
> On Wed, Feb 21, 2024 at 12:14:25PM +0100, Jan Kara wrote:
> > On Tue 20-02-24 16:25:37, kernel test robot wrote:
> > > kernel test robot noticed a -21.4% regression of vm-scalability.throughput on:
> > > 
> > > commit: ab4443fe3ca6298663a55c4a70efc6c3ce913ca6 ("readahead: avoid multiple marked readahead pages")
> > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
> > > 
> > > testcase: vm-scalability
> > > test machine: 224 threads 2 sockets Intel(R) Xeon(R) Platinum 8480CTDX (Sapphire Rapids) with 512G memory
> > > parameters:
> > > 
> > > 	runtime: 300s
> > > 	test: lru-file-readtwice
> > > 	cpufreq_governor: performance
> > 
> > JFYI I had a look into this. What the test seems to do is that it creates
> > image files on tmpfs, loopmounts XFS there, and does reads over file on
> > XFS. But I was not able to find what lru-file-readtwice exactly does,
> > neither I was able to reproduce it because I got stuck on some missing Ruby
> > dependencies on my test system yesterday.
> 
> what's your OS?

I have SLES15-SP4 installed in my VM. What was missing was 'git' rubygem
which apparently is not packaged at all and when I manually installed it, I
was still hitting other problems so I rather went ahead and checked the
vm-scalability source and wrote my own reproducer based on that.

I'm now able to reproduce the regression in my VM so I'm investigating...

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR