Received-SPF: pass (google.com: domain of linux-kernel+bounces-76470-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Subject: Re: [PATCH for-6.8 v4 2/3] LoongArch: KVM: Rename _kvm_get_cpucfg to
 _kvm_get_cpucfg_mask
To: WANG Xuerui <kernel@xen0n.name>, Paolo Bonzini <pbonzini@redhat.com>,
 Huacai Chen <chenhuacai@kernel.org>
Cc: Tianrui Zhao <zhaotianrui@loongson.cn>, kvm@vger.kernel.org,
 loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
 WANG Xuerui <git@xen0n.name>
References: <20240222105109.2042732-1-kernel@xen0n.name>
 <20240222105109.2042732-3-kernel@xen0n.name>
From: maobibo <maobibo@loongson.cn>
Message-ID: <9e738ae8-8209-f194-9d4e-692c8b107ba5@loongson.cn>
Date: Thu, 22 Feb 2024 19:59:11 +0800
User-Agent: Mozilla/5.0 (X11; Linux loongarch64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240222105109.2042732-3-kernel@xen0n.name>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit


On 2024/2/22 下午6:51, WANG Xuerui wrote:
> From: WANG Xuerui <git@xen0n.name>
> 
> The function is not actually a getter of guest CPUCFG, but rather
> validation of the input CPUCFG ID plus information about the supported
> bit flags of that CPUCFG leaf. So rename it to avoid confusion.
> 
> Signed-off-by: WANG Xuerui <git@xen0n.name>
> ---
>   arch/loongarch/kvm/vcpu.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/loongarch/kvm/vcpu.c b/arch/loongarch/kvm/vcpu.c
> index 7fd32de6656b..9f63bbaf19c1 100644
> --- a/arch/loongarch/kvm/vcpu.c
> +++ b/arch/loongarch/kvm/vcpu.c
> @@ -298,7 +298,7 @@ static int _kvm_setcsr(struct kvm_vcpu *vcpu, unsigned int id, u64 val)
>   	return ret;
>   }
>   
> -static int _kvm_get_cpucfg(int id, u64 *v)
> +static int _kvm_get_cpucfg_mask(int id, u64 *v)
>   {
>   	if (id < 0 || id >= KVM_MAX_CPUCFG_REGS)
>   		return -EINVAL;
> @@ -339,7 +339,7 @@ static int kvm_check_cpucfg(int id, u64 val)
>   	u64 mask = 0;
>   	int ret;
>   
> -	ret = _kvm_get_cpucfg(id, &mask);
> +	ret = _kvm_get_cpucfg_mask(id, &mask);
>   	if (ret)
>   		return ret;
>   
> @@ -567,7 +567,7 @@ static int kvm_loongarch_get_cpucfg_attr(struct kvm_vcpu *vcpu,
>   	uint64_t val;
>   	uint64_t __user *uaddr = (uint64_t __user *)attr->addr;
>   
> -	ret = _kvm_get_cpucfg(attr->attr, &val);
> +	ret = _kvm_get_cpucfg_mask(attr->attr, &val);
>   	if (ret)
>   		return ret;
>   
> 
Reviewed-by: Bibo Mao <maobibo@loongson.cn>