Received-SPF: pass (google.com: domain of linux-kernel+bounces-76492-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <01046eb8-a351-4599-96dc-847896fc0785@xs4all.nl>
Date: Thu, 22 Feb 2024 13:16:05 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] media/cec/core: fix task hung in cec_claim_log_addrs
Content-Language: en-US, nl
To: Hillf Danton <hdanton@sina.com>
Cc: Edward Adam Davis <eadavis@qq.com>,
 syzbot+116b65a23bc791ae49a6@syzkaller.appspotmail.com,
 linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
 mchehab@kernel.org, syzkaller-bugs@googlegroups.com
References: <0000000000006d96200611de3986@google.com>
 <tencent_941B48254CBA00BB4933069E391B6E4B5408@qq.com>
 <20240222104320.236-1-hdanton@sina.com>
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
In-Reply-To: <20240222104320.236-1-hdanton@sina.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 22/02/2024 11:43, Hillf Danton wrote:
> On Wed, 21 Feb 2024 15:38:47 +0100 Hans Verkuil <hverkuil-cisco@xs4all.nl>
>> On 21/02/2024 15:20, Edward Adam Davis wrote:
>>> After unlocking adap->lock in cec_claim_log_addrs(), cec_claim_log_addrs() may
>>> re-enter, causing this issue to occur.
>>
>> But if it is called again, then it should hit this at the start of the function:
>>
>>         if (WARN_ON(adap->is_configuring || adap->is_configured))
>>                 return;
>>
>> I'm still not sure what causes the KASAN hung task since I cannot seem to reproduce
>> it, and because it is hard for me to find enough time to dig into this.
> 
> Likely because of the window for initializing completion more than once [1].
> 
> [1] https://lore.kernel.org/lkml/00000000000054a54e0611f1bc01@google.com/

I have been able to reproduce this by adding msleeps in several places.

When I have some more time I will start digging into this.

Regards,

	Hans