Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp300881rdb; Thu, 22 Feb 2024 04:24:49 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUP1AA1r9tbcYluSxR1eSJez8x5Pj4DmXddg7/F+SsOlTu8BKLZYPqudwbp0kniMdytCgRGutK8IDscpHRZE6fji4yvxBZJs+Oay62wvw== X-Google-Smtp-Source: AGHT+IGs1Zd/8yPh5MNQhpHSf4ElWvjd4jW4XzDyAMqGLzsKfi3BpRC8iRrW3hGqXKvLF/FZiv3o X-Received: by 2002:a17:903:244f:b0:1db:cf94:9ba with SMTP id l15-20020a170903244f00b001dbcf9409bamr19914104pls.59.1708604689315; Thu, 22 Feb 2024 04:24:49 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708604689; cv=pass; d=google.com; s=arc-20160816; b=aInVA2ay8xPB6Iehs6ugV6VTmXo2hOoNkatC8Ziqa6YghuYxSZG/e85UIc13aoyRVD 24io5lzHjikXimlnLM6uekAntN0UD0ogEyCre+kpArkSY8m7T6CbWiOdOeO+Er/A1YzT npnkrQ67aNTRgOOzkbqDbZJLyQxCh5YkHbcLbp9ty7Oo5yHADegR71QLwoehLN/CpvZU gscCESGtipXr7sTtfDKKCCn3nCGAsrjBUPWVnS8ZBfkuTsbyHJmGHj8UcES98564d8kQ Tmm8J80cl5jFj/XkTUrbv2AEMBwcRS4yicjwnkFGyWpRiTEKfXmcdc6LgFZfJOJJtcYy 3E6w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=SzkRLezEcoWqN5XMk5IQjv+zaBzCE6hGL4TlzpzvRx8=; fh=M2TDT1pKaetSRjmfVRGty5cIvZ69RRvvUoZHcxAFNMA=; b=ZGpQB+3uQZXdWElq3lhVq1oW8lAHDptffAXXW64Dr6PN0Gyg5FXuWa4Ffh3rfDfuhZ 23bB8KAeTCeQGatN14IFy9UJo3HQA1iO592iInkIWLPzZVA+wPH1nmfH2Wd1Avgnc6f1 MRtU8r381/KpfwdB+jUu24UxwPzRuIOBfYIbq4ShKbjAAsOiU/Yph2/YxsLgR+jPuVYS NnEqTflQyPM/m0hqpPdWv3sFbesc4g1gdtC/07nDhsuZ2F52u13bnClR1V6d9Qo65Z0t GbRrbiP9iFk3HFWpq81CQAhfyjdt+owU47iRr2yn+ZQPIquODirM0AoU3RyLo9rrlcdw s7ng==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@tesarici.cz header.s=mail header.b=EUAlNGrf; arc=pass (i=1 spf=pass spfdomain=tesarici.cz dkim=pass dkdomain=tesarici.cz dmarc=pass fromdomain=tesarici.cz); spf=pass (google.com: domain of linux-kernel+bounces-76507-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76507-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=tesarici.cz Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id c8-20020a170903234800b001d904d7c449si10272585plh.271.2024.02.22.04.24.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 04:24:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-76507-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@tesarici.cz header.s=mail header.b=EUAlNGrf; arc=pass (i=1 spf=pass spfdomain=tesarici.cz dkim=pass dkdomain=tesarici.cz dmarc=pass fromdomain=tesarici.cz); spf=pass (google.com: domain of linux-kernel+bounces-76507-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76507-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=tesarici.cz Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 04FE028B8BF for ; Thu, 22 Feb 2024 12:24:49 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B0C15612E8; Thu, 22 Feb 2024 12:24:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tesarici.cz header.i=@tesarici.cz header.b="EUAlNGrf" Received: from bee.tesarici.cz (bee.tesarici.cz [77.93.223.253]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5420960879; Thu, 22 Feb 2024 12:24:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=77.93.223.253 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708604659; cv=none; b=ePxy7uIi7iQ7cKyMmGQWM+24c96c9ThS1XvFG1/6J0HKVUbl4BbSiVNiIILHhWcidGIsL6IH0q+fxKAldb+oJsuBwsYLYPEzsUt34Fg+bTNQwj1xmRk4N6k3duHVkVoO1sKaW20HbVz1WD+DwJDGE7rb3RyyBp0779PnHrXYvvM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708604659; c=relaxed/simple; bh=SzkRLezEcoWqN5XMk5IQjv+zaBzCE6hGL4TlzpzvRx8=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Jqq4cIuBMIuT1LY29CoWzB3VSng2OipdaLLoCvlXV8qIzVgBNRA2k5Lgof1pOLUBq76zDChdPRGjhccMqpSs9+oR2ddBlDgRRDYkBadcrUKBX4GX62+JfzcS0sLS69GVzlW7niJSEdXI0tB4zbCa0ugK/s73jZOLCJYZwcwAs6U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tesarici.cz; spf=pass smtp.mailfrom=tesarici.cz; dkim=pass (2048-bit key) header.d=tesarici.cz header.i=@tesarici.cz header.b=EUAlNGrf; arc=none smtp.client-ip=77.93.223.253 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=tesarici.cz Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tesarici.cz Received: from meshulam.tesarici.cz (dynamic-2a00-1028-83b8-1e7a-4427-cc85-6706-c595.ipv6.o2.cz [IPv6:2a00:1028:83b8:1e7a:4427:cc85:6706:c595]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by bee.tesarici.cz (Postfix) with ESMTPSA id 49C831B3C16; Thu, 22 Feb 2024 13:24:12 +0100 (CET) Authentication-Results: mail.tesarici.cz; dmarc=fail (p=quarantine dis=none) header.from=tesarici.cz DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tesarici.cz; s=mail; t=1708604653; bh=SzkRLezEcoWqN5XMk5IQjv+zaBzCE6hGL4TlzpzvRx8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=EUAlNGrf23R8w4oEXhdN8ZTdwZg1H7M4/emZPySrk6K9Tl0SxhgdNcc+GVXJzkF3K jhjEkvp7rH7EDvKJP8N1WoE10a3c92Pf6/xWI/KNQXgf4YwqDhpDsD2Sz7vm2z7Lxu QrFdVlvJFDd25mDM+o2lNSY2HQW6+zwnWeoZrkjI/dzsAj1ADwvpfvp+aYsPDhk7+s +uJNHsQG4WSVKSkZg/cEwEkmeqqHv63GsosLISth1I21E6qnsVSxAZUr46A8h1ti5w 8xB2a1phVtvV+YvhVd8sMVHnIsWVImqVlHlq4wr1kEZ6CyLBGnCxeEbIFEyPI2fo5P PuGFeTj8+894w== Date: Thu, 22 Feb 2024 13:24:10 +0100 From: Petr =?UTF-8?B?VGVzYcWZw61r?= To: Michal Hocko Cc: Suren Baghdasaryan , akpm@linux-foundation.org, kent.overstreet@linux.dev, vbabka@suse.cz, hannes@cmpxchg.org, roman.gushchin@linux.dev, mgorman@suse.de, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, penguin-kernel@i-love.sakura.ne.jp, corbet@lwn.net, void@manifault.com, peterz@infradead.org, juri.lelli@redhat.com, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@redhat.com, dave.hansen@linux.intel.com, x86@kernel.org, peterx@redhat.com, david@redhat.com, axboe@kernel.dk, mcgrof@kernel.org, masahiroy@kernel.org, nathan@kernel.org, dennis@kernel.org, tj@kernel.org, muchun.song@linux.dev, rppt@kernel.org, paulmck@kernel.org, pasha.tatashin@soleen.com, yosryahmed@google.com, yuzhao@google.com, dhowells@redhat.com, hughd@google.com, andreyknvl@gmail.com, keescook@chromium.org, ndesaulniers@google.com, vvvvvv@google.com, gregkh@linuxfoundation.org, ebiggers@google.com, ytcoode@gmail.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, bristot@redhat.com, vschneid@redhat.com, cl@linux.com, penberg@kernel.org, iamjoonsoo.kim@lge.com, 42.hyeyoo@gmail.com, glider@google.com, elver@google.com, dvyukov@google.com, shakeelb@google.com, songmuchun@bytedance.com, jbaron@akamai.com, rientjes@google.com, minchan@google.com, kaleshsingh@google.com, kernel-team@android.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux.dev, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH v4 06/36] mm: enumerate all gfp flags Message-ID: <20240222132410.6e1a2599@meshulam.tesarici.cz> In-Reply-To: References: <20240221194052.927623-1-surenb@google.com> <20240221194052.927623-7-surenb@google.com> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.39; x86_64-suse-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Thu, 22 Feb 2024 13:12:29 +0100 Michal Hocko wrote: > On Wed 21-02-24 11:40:19, Suren Baghdasaryan wrote: > > Introduce GFP bits enumeration to let compiler track the number of used > > bits (which depends on the config options) instead of hardcoding them. > > That simplifies __GFP_BITS_SHIFT calculation. > >=20 > > Suggested-by: Petr Tesa=C5=99=C3=ADk > > Signed-off-by: Suren Baghdasaryan > > Reviewed-by: Kees Cook =20 >=20 > I thought I have responded to this patch but obviously not the case. > I like this change. Makes sense even without the rest of the series. > Acked-by: Michal Hocko Thank you, Michal. I also hope it can be merged without waiting for the rest of the series. Petr T