Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp307492rdb; Thu, 22 Feb 2024 04:37:08 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX5X0vAm6+LuletV8DWyPkAF7ZBAym5nl/r2kxzaIt2QTWybI4+klRZdAZhWmi/gQ18PxrQuFFHVwrp6Gf66OjwAuQqVWECDlWVizgn0g== X-Google-Smtp-Source: AGHT+IEzPESjvQD6rCZMsj2AsUaFRAjVDQrnGqjbxxa78KtGa8AVSOLBivS+6XIbPw2A7XoaGeIE X-Received: by 2002:a05:6a00:7295:b0:6e1:29ee:aae8 with SMTP id ll21-20020a056a00729500b006e129eeaae8mr16665848pfb.25.1708605428311; Thu, 22 Feb 2024 04:37:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708605428; cv=pass; d=google.com; s=arc-20160816; b=zLH+uVjC5OZ/+rwMqIow335nDhXePwjwy/56VzwXs0fqxzCKaTFy7EL545aJbvKz98 G3LboxJ99ruNkOy3evk4H0mbOKbZlXCrPnBSUfCb92FR0dtNBLNEexARNLye99Avc2gP F4SOyZS+iGZuzoFf+hHPGB/wI8NRT3vtpLZBA1yRCoQEekcU1rVorVDQvYmeqOYW9mGu 77zh3um4RY5gtl3RC3GBsJK1RmhdELlOvzkDocx52ryjnN5kZbJZUdyvSFik92gYjRWq 92Zbwp4V5PrnX53bEKFa5J5WidX43wukVX0tpFWdNOc5r52VDgo4H0tBdWBFEx0jfo0F 4FPg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Zl7VxNCsDqEdIL+QjMQWr2fTPXGWtgy9/N5FC0HAvsU=; fh=2CeTjPgYSjve0P4ycLtYzZ5d5AP+Iz5F44cOz4gMoA0=; b=0lbwJIQvILA2EFU4e3wIXi4Z2FQHo6MDgzlo85yayS7RZYJoFSgQpPY8lwXwv78PV2 ZkmtwUMKd+obXDyT1ZfR98DX8UfzLuNUJAMh8DOYwThGE6Rn55Fj8ZN0maJwLRzsIBIh NMAch9wURoEM/9picwOtlNPrgms/Fbw+6hGH9F+cE/Rsbvr9yrbcGEQoW5xdkxXkiL+9 urjYdi00mHWthUVcHg/rlaajEh/KdPQknj1eE1YgEGJiBrZCyWrT+8popME0EtJcGIzT mPRhZcP6KrF485yI+9FnAhVXFHMNXpSouFqy4/38m3Lmtrhb5lIGHBww/iZMFYAB8Vk7 GDzg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D1xO5VRo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-76519-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76519-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id lo13-20020a056a003d0d00b006e4be08ae7fsi2484606pfb.366.2024.02.22.04.37.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 04:37:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-76519-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=D1xO5VRo; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-76519-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76519-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 071EA281C63 for ; Thu, 22 Feb 2024 12:37:08 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A9CDF12DDAC; Thu, 22 Feb 2024 12:36:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="D1xO5VRo" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5E0112C809; Thu, 22 Feb 2024 12:36:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708605416; cv=none; b=slRcGEn7UHLkbtmeLkH6dWWKe7WGl8mNs1FZ/rXCumhO9E/dbllnoZ3u4Tdz/Jd3uTWm9IdG/5dTF/EB7+i7c/aiJPJvSmru6X9OGP0GGMCkejBzp3H4H0uNPu+BDnDi0KQpDXO+aVWppcSrtymC3thYHnT7vXu+rVbdSrlxexM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708605416; c=relaxed/simple; bh=5JMBWnzvOQc2q9DWqlLSJhqyKMkqobNiRXLfi0gNSkw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=GMZ9+NTEbnWf0I8lhNnaricC745y7og6+dp6b11AVC4wdHxXPHuZ+qQf497jmOEjPWjftuubhkNycUrveDAIOUMaIRrayWRV1tgA1QdGybgVYf/QglMuUnd3OTq+KVF/mbmtsbv0mW+1GoOc2xKmM4peg0NtIE3o72phB6q6Rb4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=D1xO5VRo; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0D8BCC433F1; Thu, 22 Feb 2024 12:36:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708605416; bh=5JMBWnzvOQc2q9DWqlLSJhqyKMkqobNiRXLfi0gNSkw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D1xO5VRoWXbIbpcnOhY/uLVhsXx/2oRZ2xD235yMjQklY/wimmoooLrtFXjW9Jd2Z 4Nj1KxVN1DvLIa1/KLDUWTU+wbSCz1KQ8tj6JDssXczs9h0SpBTrx+KDnzmj78TzPK 0B5HvJD/XEpCogvsZ+B+MdxKl9ZrlYE/ljxwDSq0reRjMdhHSTtcFSdPy3LfF4PqlJ Ywlx5zj+OqnDsEhvPpU4WlBXF1IExGnDeQL0nS7vBvAnXO6Wed5aQEoMhaVfghyMV/ sODhTLvWPinMcOY35mJfngLaWw4vzUTgQwd63hFrGlFol3IW7K8oYunizs4JzskfHg 6m0ipcTYDF3nw== Date: Thu, 22 Feb 2024 07:36:56 -0500 From: Sasha Levin To: Pavel Machek Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Kees Cook , Kentaro Takeda , Tetsuo Handa , Alexander Viro , Christian Brauner , Jan Kara , Eric Biederman , Andrew Morton , Sebastian Andrzej Siewior , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, surenb@google.com, michael.christie@oracle.com, mst@redhat.com, mjguzik@gmail.com, npiggin@gmail.com, zhangpeng.00@bytedance.com, hca@linux.ibm.com Subject: Re: [PATCH AUTOSEL 5.10 7/8] exec: Distinguish in_execve from in_exec Message-ID: References: <20240202184156.541981-1-sashal@kernel.org> <20240202184156.541981-7-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: On Sun, Feb 18, 2024 at 08:12:56PM +0100, Pavel Machek wrote: >Hi! > >> From: Kees Cook >> >> [ Upstream commit 90383cc07895183c75a0db2460301c2ffd912359 ] >> >> Just to help distinguish the fs->in_exec flag from the current->in_execve >> flag, add comments in check_unsafe_exec() and copy_fs() for more >> context. Also note that in_execve is only used by TOMOYO now. > >These are just a whitespace changes, we should not need them. Dropped, thanks! -- Thanks, Sasha