Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp330060rdb; Thu, 22 Feb 2024 05:18:02 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVVzyWFLbl7eV0W6MbJf/954FDr5DgXVluqU68I9eGAGcQ82ifrjVonYD1Az3HnS0raZCNx/Uund2Um6iIHX6dP9E971YGb/VbOMDJXdA== X-Google-Smtp-Source: AGHT+IF483xrhQqqJYOMoLAL8cWda2jLAK8u6bz2Y3xn8qqwaKnigt8/S7v/RfEjQ2NFeNRcoFuV X-Received: by 2002:a05:620a:38a:b0:787:1fa4:98e5 with SMTP id q10-20020a05620a038a00b007871fa498e5mr24049836qkm.32.1708607881788; Thu, 22 Feb 2024 05:18:01 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708607881; cv=pass; d=google.com; s=arc-20160816; b=Q0GubzJIHY3HBwz7Hh2VajD6zEH3LT7qbcAqawnMocwh95L2VngTIJH3J9QccZg5Cl /3I+b0OTflUI09oB3UJshwXeK9Isz4d2ACjII2q2WH1/R2lW/DXp2wxOrYP/KXfL0+4p n+ZflFnwPGtgYqLkcr+omoptfPoLO7W70u0bJ0a5Mn9TffJKe/dUfMfdC0X2u7ibI+Mo +BfE0nobB8E/jchVs/Mo44lyFnR9XcZHlFmL35T6z+ZTm9o7Q5gHvL3Wwc3m8JmPwCns ZdPkBYhLkwpffm8j0lOifx9B1zt/6tiqyLaC7hnpWydS19MPusd2X7iotS34Un+sa4LK tDSg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=organization:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=Beya05xXImNFk03h2trfhIWurF1YtOBagTq4nSjgcmQ=; fh=/t8uH1B7V/nOXz+sg+L55uz6bwbMpqxdihC3NHJM45k=; b=d9AAbd6KH/YdzI/33DaCv7fE7L9Phj+hrCgjhItZxeij1QPVeqd2uBvyDJp433oXuu gV9hzQy/c7wrkF9jfuZoqJlI0jyGBlW/drDhE6Jz2yIRAWgjFEZTqBSN54JPZoYAl9Cs 0pp4fmrQkSlXSQBLlDF+YwJIc5YV+0ByFs+O3bTs8sPSmAoE+dAPEXverzI+RLduZF1Y yWUoW/xyBHLz+pZcc3FP8e5OLN4Km6E6VNBWhwT4bVOG1TXb+xWMw3u8O61rl04fKgrL gDXORXXUCQkGM2y5n9udGmKHhxPnTeM/H2HiDbdiEztrrWjYOCgpMEwzBqjDmYtNfzMT xsXA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IVjktYGq; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-76578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id h25-20020a05620a21d900b007879734413dsi1690942qka.282.2024.02.22.05.18.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 05:18:01 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-76578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=IVjktYGq; arc=pass (i=1 dkim=pass dkdomain=intel.com dmarc=pass fromdomain=linux.intel.com); spf=pass (google.com: domain of linux-kernel+bounces-76578-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76578-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 878181C215CF for ; Thu, 22 Feb 2024 13:18:01 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C204B44C87; Thu, 22 Feb 2024 13:17:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="IVjktYGq" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EC7012F381 for ; Thu, 22 Feb 2024 13:17:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.10 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708607872; cv=none; b=HsvvyXkV2Dd+q/TrY4MZnjZaLjr+YVBZjGb0I8XVWKWF8Haw9k3v70CWPuQJKxeR72ZohZfvpOfRkAOoqj2TWsUrx7JItx2g4L+LqEQ1HaW9YZP80tffsbupnmpi/QvBb7IwKfKJDYoijMfb0vAxHoD7jPWtxrzALXliQgvGLWo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708607872; c=relaxed/simple; bh=xBCbl14vD49pli8r5yv+02NnEeDwE1tbGIB9bKQyujE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=VFLBmxPkZu0hzcJrY05NP0pVhujQkYOIZOirzBLV2eJowFlh8T3kfbPDPK8b7EB0TCS2oq6QErLJFfJcUDt3QwOtvkj7QyXOy3Nrei/JdE/Y8BECv3s3/GSwRJMMVTog9uGq+DPyvknOPKcCoy0NCkccAjqxVbcs1t9KPQz2PNs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=IVjktYGq; arc=none smtp.client-ip=192.198.163.10 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708607870; x=1740143870; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=xBCbl14vD49pli8r5yv+02NnEeDwE1tbGIB9bKQyujE=; b=IVjktYGqbQxlBBUqzS4herNnAXWd8kTKklGHHJCK6mabk9IdT7jK2ciX MCQDUUrcQkYMLcFtm8HNablumTVwJN+c4rnDEDTp/UkGanDZz9ek8jsJS 0Y0nFC1cWj0U3str2drMIgpxFErzpcHkwaV3wBPxVb8trpLa9/jVU3WEe +YJcNnwe8rnwsjNduFHHjZMWotZvFyLQNGKhD3qQTH/q7fNRxZgridFrl aEvOTW1XqRAGNwa4ozpZYjHlVgy6EJQqzovtHwcbStat451AAOFmmB4xQ wNIN7jWa6dn8nsViU6X+8Mnc+zUaG0mRrnn0W4aHTbA8iPIsFTqhmutD+ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="14246295" X-IronPort-AV: E=Sophos;i="6.06,177,1705392000"; d="scan'208";a="14246295" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 05:17:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="913522712" X-IronPort-AV: E=Sophos;i="6.06,177,1705392000"; d="scan'208";a="913522712" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 05:17:47 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rd8xN-00000006dSL-2Ptq; Thu, 22 Feb 2024 15:17:45 +0200 Date: Thu, 22 Feb 2024 15:17:45 +0200 From: Andy Shevchenko To: linux-kernel@vger.kernel.org Cc: MyungJoo Ham , Chanwoo Choi Subject: Re: [PATCH v1 1/1] extcon: intel-mrfld: Don't shadow error from devm_extcon_dev_allocate() Message-ID: References: <20231222161854.2955859-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Feb 08, 2024 at 09:24:58PM +0200, Andy Shevchenko wrote: > On Fri, Dec 22, 2023 at 06:18:54PM +0200, Andy Shevchenko wrote: > > Don't shadow error from devm_extcon_dev_allocate() and return it as is. > > Any comment on this? Here is another one, can it be applied as well? -- With Best Regards, Andy Shevchenko