Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp338343rdb; Thu, 22 Feb 2024 05:33:07 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXdcgMJj5QW7uE9O0kKcZNIMZ4YmFVm80Rz7Ky4ZCjbLKufU9t9FspeKM35oRC85gQxYG62vGWKXucqAK7n+INuz/oQrmVXx3PzAXPJJw== X-Google-Smtp-Source: AGHT+IGjnnj9Mc5s3Is6nZ2C+6Ij4JChRNWdksMJ9D/kAa8EZgHH5Hn69GpKAj12ii6irDzSra28 X-Received: by 2002:a17:906:154e:b0:a3f:2c1:9887 with SMTP id c14-20020a170906154e00b00a3f02c19887mr6091064ejd.21.1708608787631; Thu, 22 Feb 2024 05:33:07 -0800 (PST) Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id lu14-20020a170906face00b00a3e9176fca8si3861603ejb.1017.2024.02.22.05.33.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 05:33:07 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-76602-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@intel.com header.s=Intel header.b=H650JHo3; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-76602-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76602-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 643641F21953 for ; Thu, 22 Feb 2024 13:33:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 98821134721; Thu, 22 Feb 2024 13:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=intel.com header.i=@intel.com header.b="H650JHo3" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA28F3C480; Thu, 22 Feb 2024 13:32:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708608778; cv=none; b=PWfPFUUxhQWXePooAX6GqeKjCH+WrMgw126hFXJCX05KV989LiPKZ2A8qekT6uZwa5hhD7Ah/Jp384Kr+dETBtBjya1uj7NaZQJGJZn8CYo8ITom9vWdO2ichvUarpHrLR8rNuKqJrpKAPj+eRXF524KRYrRX4c8kriZkOFp1e0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708608778; c=relaxed/simple; bh=to4Ipw+eCpB5bmrx4T/4XN3XHMiieJqUqhIVN5Bez2o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=o+sJmEh7ofMVfRxwibO9fgl0Mopm1nt7H3vvQQDwj0vv3K75mbXgiTqELnk1lc0iMWIG8IoP0KSEvQmphs7mVg4zL5AbX2rtXN/48Ev7QIEq41JU96Ndsec94Ac9/uM0c551SRfzyKmp6fWUcvKSiQ+bzr1JGWseZ+aPslx1vyM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=H650JHo3; arc=none smtp.client-ip=198.175.65.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708608777; x=1740144777; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=to4Ipw+eCpB5bmrx4T/4XN3XHMiieJqUqhIVN5Bez2o=; b=H650JHo3Kir9h91Agl5GBo/F4Vb1xpDHs88WJxHzsSMcxsGAcKYLW5R3 CjTq0L4cjqqCSTSAUXwUEC5pPdnXqv2Qa+05lFChR0vZh7g65YOfjlktw U7FI6LXs9sf0L/tBYxgZ/WXsvzqCFXrksstwR3uXMW7AR+4uZzvNPTzbw SpzheH7XsQrcA/5USWajJZCbXrK8RgkiSQLdvLaDC0ecxfaGUE5AQXFxI 7UL9W7WeuYqjUkoTmtzxdIwdc+K+EWhiSqY8isuvn1yyGudsbdjDpKPOa MQhzaIRltya/9nsUZR7dQG+qKs+uRqNnIm2zJ730OqTfYyZUJpr2Cqm+u A==; X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="25293660" X-IronPort-AV: E=Sophos;i="6.06,177,1705392000"; d="scan'208";a="25293660" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 05:32:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10991"; a="913526182" X-IronPort-AV: E=Sophos;i="6.06,177,1705392000"; d="scan'208";a="913526182" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 05:32:52 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1rd9Bx-00000006deC-0kGg; Thu, 22 Feb 2024 15:32:49 +0200 Date: Thu, 22 Feb 2024 15:32:48 +0200 From: Andy Shevchenko To: Saravana Kannan Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , "Rafael J. Wysocki" , Ard Biesheuvel , Frank Rowand , Daniel Scally , Heikki Krogerus , Sakari Ailus , Len Brown , kernel-team@android.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH v3 4/4] of: property: fw_devlink: Add support for "post-init-providers" property Message-ID: References: <20240221233026.2915061-1-saravanak@google.com> <20240221233026.2915061-5-saravanak@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240221233026.2915061-5-saravanak@google.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Feb 21, 2024 at 03:30:24PM -0800, Saravana Kannan wrote: > Add support for this property so that dependency cycles can be broken and > fw_devlink can do better probe/suspend/resume ordering between devices in a > dependency cycle. .. > - fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np), 0); > + fwnode_link_add(of_fwnode_handle(con_np), of_fwnode_handle(sup_np), > + flags); I would leave it one line despite being 83 characters long. .. > - of_link_to_phandle(con_dev_np, phandle); > + of_link_to_phandle(con_dev_np, phandle, > + s->fwlink_flags); I would leave this on one line, it's only 81 characters. -- With Best Regards, Andy Shevchenko