Received-SPF: pass (google.com: domain of linux-kernel+bounces-76629-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <51ffdd0f-d3a1-7f19-2033-264baf71394e@quicinc.com>
Date: Thu, 22 Feb 2024 19:16:26 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.12.0
Subject: Re: [PATCH v1 1/3] dt-bindings: PCI: qcom: Add global irq support for
 SA8775p
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Konrad Dybcio
	<konrad.dybcio@linaro.org>,
        root <root@hu-msarkar-hyd.qualcomm.com>, <andersson@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <jingoohan1@gmail.com>,
        <gustavo.pimentel@synopsys.com>, <manivannan.sadhasivam@linaro.org>,
        <conor+dt@kernel.org>, <quic_nitegupt@quicinc.com>
CC: <quic_shazhuss@quicinc.com>, <quic_ramkri@quicinc.com>,
        <quic_nayiluri@quicinc.com>, <quic_krichai@quicinc.com>,
        <quic_vbadigan@quicinc.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Rob Herring
	<robh@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>,
        <linux-arm-msm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240221140405.28532-1-root@hu-msarkar-hyd.qualcomm.com>
 <20240221140405.28532-2-root@hu-msarkar-hyd.qualcomm.com>
 <08ca89da-d6a1-440c-8347-f2e31222bede@linaro.org>
 <a0677780-d013-44f7-94bf-ea7e23aab019@linaro.org>
 <88d8fea5-2b11-4d01-816c-dbe822ac8d19@linaro.org>
Content-Language: en-US
From: Mrinmay Sarkar <quic_msarkar@quicinc.com>
In-Reply-To: <88d8fea5-2b11-4d01-816c-dbe822ac8d19@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 2/21/2024 8:03 PM, Krzysztof Kozlowski wrote:
> On 21/02/2024 15:31, Konrad Dybcio wrote:
>> On 21.02.2024 15:28, Krzysztof Kozlowski wrote:
>>> On 21/02/2024 15:04, root wrote:
>>>> From: Mrinmay Sarkar <quic_msarkar@quicinc.com>
>>>>
>>>> Add global interrupt support in dt-bindings for SA8775p RC platform.
>>> What is this global interrupt? Why wasn't it there before?
>>>
>>>> Signed-off-by: Mrinmay Sarkar <quic_msarkar@quicinc.com>
>>>> ---
>>>>   .../devicetree/bindings/pci/qcom,pcie.yaml    | 26 +++++++++++++++++--
>>>>   1 file changed, 24 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>> index a93ab3b54066..d86fb63a2d2c 100644
>>>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>>>> @@ -63,7 +63,7 @@ properties:
>>>>   
>>>>     interrupt-names:
>>>>       minItems: 1
>>>> -    maxItems: 8
>>>> +    maxItems: 9
>>>>   
>>>>     iommu-map:
>>>>       minItems: 1
>>>> @@ -873,8 +873,30 @@ allOf:
>>>>           compatible:
>>>>             contains:
>>>>               enum:
>>>> -              - qcom,pcie-msm8996
>>>>                 - qcom,pcie-sa8775p
>>>> +    then:
>>>> +      oneOf:
>>> No need, drop.
>> Moreover, I think this global irq should be present on all qc platforms
> Heh, this will anyway conflict with my series:
> https://lore.kernel.org/all/90a50ab4-a513-48af-b13a-bba082e49540@linaro.org/
>
> https://lore.kernel.org/all/20240205-dt-bindings-pci-qcom-split-continued-v1-0-c333cab5eeea@linaro.org/

Thanks for sharing the series. will make change top of your series on v2.

Thanks,
Mrinmay

> Best regards,
> Krzysztof
>