Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp454966rdb; Thu, 22 Feb 2024 08:44:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWGeXqOmtqdflIYy31bzKtAgOV+Q8sNuyIzNmK7XVx4iwdubupUGb2Jt7eGtAJ8SO4/wV8l6ALPrvuxRMUprcfrVyZbl4L34hbkgloaZg== X-Google-Smtp-Source: AGHT+IEkNE+vGdIvBwzA1Lnn6qayxdmMEfrkwKmGhzv9j2TJv5goVgFj3hlkpRzsLarxp7pWKET/ X-Received: by 2002:a05:6a20:c886:b0:1a0:73b9:85e2 with SMTP id hb6-20020a056a20c88600b001a073b985e2mr23336980pzb.10.1708620240706; Thu, 22 Feb 2024 08:44:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708620240; cv=pass; d=google.com; s=arc-20160816; b=rwpKexKQuvlAiSUlT8Vrb63J4wdaquOfzpPvXupgKenJOx31Pu8eZ8APSfby+xurkz 69gJabL9mFqgHJxI7BJktloF6R8ULJKj6ugCSyU8ztDi7zxAyYUOYgKrMqdqIT66hYxn ZEjcm838oCTBtR9CvJgCDkuukmseboSX/BTrkqERxoDya+SiAxUvFkf9Dh0jC7cedTa/ ZkbQNGuz4PBgO5TI3GTxHh4DOkB33gwGP7tEoVDTae4WQboPix54eDK03tWD+4IXoM7E DcPAqEu8wsPfwwqFcLK2l22ysEvpqPsKBy3k94PO5nDMr9QTqMd2iJu2gnGCem0A/znE FKYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=blGXCQWbinQD12tf5lew+OFO7kdmX5WYe1FXNjbh2d4=; fh=7XQzYiFLm5KZ/GRGycbnO1ne2E4JgTKxfAlpV0DYjRI=; b=a/PFQC31n2axGhD5iSk7hYUOd+GkJuZWkAWWdFvISPXu2KbraaswipaL/nMDnCTZsj 7XNLZMUcB6UBuDW9NtO+Hg3vxBXOOgTPAH+mpsMkP/LPB3gMbPfuixs0aCi9bY2FY3c3 pL0Bkax7RjLFFE34zWEuwbyDcOe5NA9YyffXvp96bUKXXS9u6offLaMo/aLi97IgJVh6 joPgki6cXZfcitgz2RkRDfpKgFSvz3V9hZX1U+aqJvK3ZtWaxGTKWiFDMBew5SYRjull 2/Llg+XINQZecpjlph3AdBBZ7sP/Fb0RHSWAjZni4menm4EJO8nMRf3gZPj8U7F6ayZS gtnw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iaKY3TNQ; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-76895-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76895-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id ln6-20020a056a003cc600b006e47dc9d922si5307081pfb.138.2024.02.22.08.44.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 08:44:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-76895-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iaKY3TNQ; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-76895-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76895-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 27500286171 for ; Thu, 22 Feb 2024 16:44:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 4FF4D153BCE; Thu, 22 Feb 2024 16:43:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iaKY3TNQ" Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC393132C1B for ; Thu, 22 Feb 2024 16:43:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708620232; cv=none; b=L0+E/hurYJ363aY/mX+cszZ92B8mc6Gex15LxL40yGfH0k/7KV5Xw66V5NoHjAk77HARQuZM/ht4P0r+5pQvhZtvmowWWgHWn3zyF9Zi/qvaP4fAsKuYtC7n4rjtSctWJNNXj3VJVFsSAw3b8cuCWCP8rpir/BS84ZJEXGyGzQc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708620232; c=relaxed/simple; bh=blGXCQWbinQD12tf5lew+OFO7kdmX5WYe1FXNjbh2d4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=Y0PY+WiSpGXuKDF/WZdSfu9L2KHPQcarRQvsVw729M/HotkjL2Fk7feurAGeCAEtnRg/LFBxRQLfS+TOj8LzRDqGZPemCzPRg4v7DEeqC6NnEcdcj2+w/D6kex0KFWfMREsUW6uCy+1dO/MTEHdwiDM/eSa5JW3uuK/dYdhK7UI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=iaKY3TNQ; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-41279203064so12319915e9.1 for ; Thu, 22 Feb 2024 08:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708620229; x=1709225029; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=blGXCQWbinQD12tf5lew+OFO7kdmX5WYe1FXNjbh2d4=; b=iaKY3TNQAt1pe8rPYA6dM2vsv1TiNG446InpPbybZoeIcG/pSCkv9mVqN5A6MjViMP UDcZLj5NvHhziGP+ZP0sVljWuEFYRF2st4B2JdxEO8VYj9eEOundVpvPkMmiwPWxfkaC b9NbfuhE34bl3fu0zpuz3nOrNQbb3qjdOErU4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708620229; x=1709225029; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=blGXCQWbinQD12tf5lew+OFO7kdmX5WYe1FXNjbh2d4=; b=xTJvlReMyZvg//0L/HaFTmOk4IXzDmqACWRQ68yG7PUadaIZPvpewQ44jL+Z8+rpxo V7FNsNP/JX9w6cdPXxDJHZj2BTedBnFF4lL7/ID3+Prt4xFHqKEXubmA7uv5XGPYo5KO if3+eOtdFmQIu4GTuC1yZxnZEXSOFSt4a0wEJYo1CairuMaBCv4kOw9WpoNpQQD3Eugc PwfJWYGapZkiLXR3ScHlXFzf0v4o9tDxvYbLI8ojVMICjs6/PDoDD4s2ufzW7bAwuCtt 8msp5zeOYgyM1H6WPEli12Fp8m8WXzu5BKmRPJw8LvqDfPalU08JHXDWC85otpAMWvG2 bShw== X-Forwarded-Encrypted: i=1; AJvYcCXIweD29xtrHweey3Y9XHnenY4dXSRXsPZGHDrVkavHzIwEDUF6vCQFCriQmChg7xIpjSKtk6IZghqbsObXTITER3YxAE6sWEh4GZmD X-Gm-Message-State: AOJu0YwyB91rGY4kYLtElO+XR+1/ET9ZjVjZoek1MsP/OaUJWDxOr9/U yRDAf5x83EwC0RDF5cjfQeetNovXLxLxLiUvS7P5obWEi7+a6WtPDRgMpFJAg/rKlPc8k3PIOw0 8H7pyQXi3MFtbhHYMsoQ/pl73Pi9bV7kfp9/5 X-Received: by 2002:a05:600c:1391:b0:410:e41a:fc0d with SMTP id u17-20020a05600c139100b00410e41afc0dmr16692583wmf.24.1708620229216; Thu, 22 Feb 2024 08:43:49 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240221114357.13655-2-vbabka@suse.cz> In-Reply-To: From: Karthikeyan Ramasubramanian Date: Thu, 22 Feb 2024 09:43:38 -0700 Message-ID: Subject: Re: [PATCH] mm, vmscan: prevent infinite loop for costly GFP_NOIO | __GFP_RETRY_MAYFAIL allocations To: Sven van Ashbrook Cc: Vlastimil Babka , Andrew Morton , bgeffon@google.com, cujomalainey@chromium.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-sound@vger.kernel.org, perex@perex.cz, stable@vger.kernel.org, tiwai@suse.com, tiwai@suse.de, Michal Hocko , Mel Gorman Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable With this patch, the test results have been promising so far. After 10 hours of stress testing, we have not hit the reported problem yet. We will keep testing and report here if we hit the problem again. Thanks for engaging with us. On Wed, Feb 21, 2024 at 8:53=E2=80=AFAM Sven van Ashbrook wrote: > > Thanks so much ! We will stress test this on our side. > > We do this by exhausting memory and triggering many suspend/resume > cycles. This reliably reproduces the problem (before this patch). > > Of course, as we all know, absence of evidence (no more stalls in stress = tests) > does not equal evidence of absence (stalls are gone in all code paths).