Received-SPF: pass (google.com: domain of linux-kernel+bounces-76919-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f8886683-4f24-47ce-a0c6-ef28466bfec9@intel.com>
Date: Thu, 22 Feb 2024 09:05:50 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 0/5] selftests/resctrl: Add non-contiguous CBMs in
 Intel CAT selftest
Content-Language: en-US
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>,
	<shuah@kernel.org>, <fenghua.yu@intel.com>
CC: <linux-kselftest@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<ilpo.jarvinen@linux.intel.com>
References: <cover.1708072203.git.maciej.wieczor-retman@intel.com>
From: Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <cover.1708072203.git.maciej.wieczor-retman@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a09lUnRIR2orcy9zMGFadjBXN01aUWVjbUF3cC8wN2ZBZUE5UGFLcGd4cjNZ?=
 =?utf-8?B?VDlyUnlib3JBN0RrMWlTa1hyTXE4TWNUK256blc4a2J4RlZLYjR4UjcrcVla?=
 =?utf-8?B?R3ZyZHBkcW9EbDg2Q3NIaTBGMzNmNk83K1BOMkhrbnY3d2JlS0h5QVk1TzlE?=
 =?utf-8?B?TWhxNXJQRCtPMkJMWDlqaGtxRFU5MWhCbjhqOG4xRU81UklxWGQzdldXcTNz?=
 =?utf-8?B?bTB4dEJvZ3JyYllJWmpWem5qeld2dUFZOGNWTnlkWUE2a1FObHAyc01UcXd3?=
 =?utf-8?B?ZEZVMFo2QVU0VG9jS0E1UUhKZDlhNmhWNTZnenFmM1dhTnhIQ25CVFhISmxR?=
 =?utf-8?B?MUc2SUs0SzF2VERqU3hickJGbUllbGFtdmlHK3RabmtudXVLZVkyUU1aS2xB?=
 =?utf-8?B?ZkErTWVMSS9CSzJtRUZkaFluT2FXSU9BaU42SWdBWDIxNnI5MmtWV3lFaXJk?=
 =?utf-8?B?QXgrTExNTDJ3ZzFvWG5tWlowTlFETmE3ekJJN0xXRWw0cmI4TDJxRU5HR2Zt?=
 =?utf-8?B?LzBubm1xK3p1U2RpNlFRK2hQUWZFcXh1blQramFQT0hxQ3pxMUZZMWlxcGhx?=
 =?utf-8?B?ZHZTaWJrQ1gvb2RWanRVUExYNFRRc3NwU3d0UkhrempLS042RHZ4di9QS0JC?=
 =?utf-8?B?WTdHM3hTbEhqdjBxRVEveHR1YjFYQ2FLNTl0US85cTlzMTdZVlRjVDljNEZv?=
 =?utf-8?B?K3BZV2JzdThRd2Iva1k5VWJpYTRyc1NFNFVCeXF1cXFiRVZzYlRBeW1scmxl?=
 =?utf-8?B?QSs1MGFpdDIxSTJZc1hMQTVOTWE3VTJmQ01wcVhSY1JWVzZwdzRqWVYzK3Yw?=
 =?utf-8?B?dU43UWRPK0RyTDFiMHY0dkFRb1g5QlM1dFFHY0hWSTdTdzlIZ0Z6TkZ3Misr?=
 =?utf-8?B?SFQ0Lzg4L3ZZdGl5U2cxWmhTRG40bjBBTmg0WTFPRVhlTFVGNHNoc3AvT1Fn?=
 =?utf-8?B?d0lDWnMzTDVsOTFkMlExSzdjQ21JTU5hV0RkV29hRXp2ZU1WcjNyZzQrMmpu?=
 =?utf-8?B?MFZNNXBINWhwV2RnNW1BTVZYMTBJWUlEVFBlNjZMWWtWbmtmclc3WGtBZVBy?=
 =?utf-8?B?Zmc3U3YwS3dpOEUzVU9hSEw4RnAzQ3ZkajdNUzc1NlFMaE1obGFPNVNSeDhJ?=
 =?utf-8?B?VGFheTJocnJMVmRIUW5GTmJ3ODhaS1Y2MDhyWmNJckkxRE9MTzNsN3BNbUpy?=
 =?utf-8?B?TFFDcysxQ09UY1JhZ1g0NUZCdk16V29Ub1JIRyt3RXZpVUJvMjlmdFBQM3ZM?=
 =?utf-8?B?UUYxYithMkE4ZDgxdHJtT3g1eWFpa0NTMXpVVzNoNDN5anFRSm5pR3JOaWpq?=
 =?utf-8?B?dlNvcDdzTm1vS1RPK0lGL1lzRHE3Yzl2VDkwVnV3c1hlcDZFMk5MVmw3TlF0?=
 =?utf-8?B?MGNzQnFOZk82RGttWkdFdmQ5ZElSVHZPMmhya0J0UmFmNFVwbzIyUmRTRDRC?=
 =?utf-8?B?bG5PNThOQVlrV0xuV21oVW91bWRHdTl4ODBOR25zZHIxU2ZOK01VcHIvVlhx?=
 =?utf-8?B?UzBacElUanlKRGNYY2twQ1l5dU9IakRhODdnc3lDc1M0eXhnbmlLam1TaHRR?=
 =?utf-8?B?V3lIS3VDK1pRaUp2dDl0ZWt3UDFxMTBIanpsQzdqbFA0dWEwNDNJelJocXgr?=
 =?utf-8?B?bXVQdkNrRzB5eURUbGVldG1lRjZ4dEZ1ZW1HYzlqNGFlZC9wdFVqV0ZSNVVY?=
 =?utf-8?B?b0xUaFU5VFFncm9Pbnpka3FIV1ArSmd0amR4TDFLeFNXUnJxc3JrWnNwckM1?=
 =?utf-8?B?UHdhb0Y4ZnNUZUVkNnQ2MnRuY2Z5VWwvS2x1TU5OK0ZlekdpOHNIMGN5dFNR?=
 =?utf-8?B?THNBYXpjRUtVcFo1eVRwTXdIK2ZxUTlqSGxKWUJJQWtkTWlhaktlMThwMy8v?=
 =?utf-8?B?Vkl5ZnVmb2tJOWRBb0xDcDNPUlptUWtUMGlJc0RlTFRKeDRFYlhEVnd3U0U0?=
 =?utf-8?B?WkRtd3JKcjhpTGpjZm1VUzRsV3dRbmViVVV6VERhaTl3UGJXOWhlOSs5NktU?=
 =?utf-8?B?L1pVMEw1c0lhUjFPT0hnczg4Vjg2bFVhTlMwZjV3WUE3OUNwSE9XTHYzQTRm?=
 =?utf-8?B?OXFXUDlxMXRYckQ0ODYxTFc5Tmh4cytJdDBubHdTaWUxaVVTanBYcStTVWRB?=
 =?utf-8?B?bVpydUpxdXJkR2xIODNubVpHMUpXWFZVbVVLazZ2NHc1MHYxTGFUcEFqYWMx?=
 =?utf-8?B?aEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 55a78620-f706-479b-0aba-08dc33c88679
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR11MB7573.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 17:05:52.4138
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EGoC8ItOx1mG/vVciZY0vu0sXJmk3aNTz7FfLRsBs5TnynLCsHo7+WjZ1UzgyLk5lmF5qbJWdcJ1RHMAJGrTpGxETCjCOx6KVaf2qqIoajY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5938
X-OriginatorOrg: intel.com

Hi Shuah,

Could you please consider this series for inclusion?

Thank you very much.

Reinette

On 2/16/2024 12:34 AM, Maciej Wieczor-Retman wrote:
> Non-contiguous CBM support for Intel CAT has been merged into the kernel
> with Commit 0e3cd31f6e90 ("x86/resctrl: Enable non-contiguous CBMs in
> Intel CAT") but there is no selftest that would validate if this feature
> works correctly. The selftest needs to verify if writing non-contiguous
> CBMs to the schemata file behaves as expected in comparison to the
> information about non-contiguous CBMs support.
> 
> The patch series is based on a rework of resctrl selftests that's
> currently in review [1]. The patch also implements a similar
> functionality presented in the bash script included in the cover letter
> of the original non-contiguous CBMs in Intel CAT series [3].
> 
> Changelog v6:
> - Add Reinette's reviewed-by tag to patch 2/5.
> - Fix ret type in noncont test.
> - Add a check for bit_center value in noncont test.
> - Add resource pointer check in resctrl_mon_feature_exists.
> - Fix patch 4 leaking into patch 3 by mistake.
> 
> Changelog v5:
> - Add a few reviewed-by tags.
> - Make some minor text changes in patch messages and comments.
> - Redo resctrl_mon_feature_exists() to be more generic and fix some of
>   my errors in refactoring feature checking.
> 
> Changelog v4:
> - Changes to error failure return values in non-contiguous test.
> - Some minor text refactoring without functional changes.
> 
> Changelog v3:
> - Rebase onto v4 of Ilpo's series [1].
> - Split old patch 3/4 into two parts. One doing refactoring and one
>   adding a new function.
> - Some changes to all the patches after Reinette's review.
> 
> Changelog v2:
> - Rebase onto v4 of Ilpo's series [2].
> - Add two patches that prepare helpers for the new test.
> - Move Ilpo's patch that adds test grouping to this series.
> - Apply Ilpo's suggestion to the patch that adds a new test.
> 
> [1] https://lore.kernel.org/all/20231215150515.36983-1-ilpo.jarvinen@linux.intel.com/
> [2] https://lore.kernel.org/all/20231211121826.14392-1-ilpo.jarvinen@linux.intel.com/
> [3] https://lore.kernel.org/all/cover.1696934091.git.maciej.wieczor-retman@intel.com/
> 
> Older versions of this series:
> [v1] https://lore.kernel.org/all/20231109112847.432687-1-maciej.wieczor-retman@intel.com/
> [v2] https://lore.kernel.org/all/cover.1702392177.git.maciej.wieczor-retman@intel.com/
> [v3] https://lore.kernel.org/all/cover.1706180726.git.maciej.wieczor-retman@intel.com/
> [v4] https://lore.kernel.org/all/cover.1707130307.git.maciej.wieczor-retman@intel.com/
> [v5] https://lore.kernel.org/all/cover.1707487039.git.maciej.wieczor-retman@intel.com/
> 
> Ilpo Järvinen (1):
>   selftests/resctrl: Add test groups and name L3 CAT test L3_CAT
> 
> Maciej Wieczor-Retman (4):
>   selftests/resctrl: Add a helper for the non-contiguous test
>   selftests/resctrl: Split validate_resctrl_feature_request()
>   selftests/resctrl: Add resource_info_file_exists()
>   selftests/resctrl: Add non-contiguous CBMs CAT test
> 
>  tools/testing/selftests/resctrl/cat_test.c    | 92 +++++++++++++++++-
>  tools/testing/selftests/resctrl/cmt_test.c    |  2 +-
>  tools/testing/selftests/resctrl/mba_test.c    |  2 +-
>  tools/testing/selftests/resctrl/mbm_test.c    |  6 +-
>  tools/testing/selftests/resctrl/resctrl.h     | 10 +-
>  .../testing/selftests/resctrl/resctrl_tests.c | 18 +++-
>  tools/testing/selftests/resctrl/resctrlfs.c   | 96 ++++++++++++++++---
>  7 files changed, 203 insertions(+), 23 deletions(-)
>