Received-SPF: pass (google.com: domain of linux-kernel+bounces-77010-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240130094037.76895-1-chentao@kylinos.cn> <CAHC9VhQG6XAm3R3wtgFrb0b0UHoxkSV2yziVAnUy2x7Ovun_pQ@mail.gmail.com>
 <CAHC9VhRLNHT0ar2YPkZBsyha_mh6Ggf6=V2gnbFkdo7ryXmHnQ@mail.gmail.com> <0f51c6ba-a6c0-4fbf-9b00-21cea6d59ca9@kylinos.cn>
In-Reply-To: <0f51c6ba-a6c0-4fbf-9b00-21cea6d59ca9@kylinos.cn>
From: Paul Moore <paul@paul-moore.com>
Date: Thu, 22 Feb 2024 12:48:29 -0500
Message-ID: <CAHC9VhTJXfPztz2W_V6sp41PJW8dzvZH0YdnRXd7tUZOF1Q09Q@mail.gmail.com>
Subject: Re: [PATCH] cred: Use KMEM_CACHE instead of kmem_cache_create
To: Kunwu Chan <chentao@kylinos.cn>
Cc: axboe@kernel.dk, elena.reshetova@intel.com, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 21, 2024 at 10:06=E2=80=AFPM Kunwu Chan <chentao@kylinos.cn> wr=
ote:
> Thanks for your reply.
> On 2024/2/22 08:10, Paul Moore wrote:
> > On Thu, Feb 15, 2024 at 10:54=E2=80=AFPM Paul Moore <paul@paul-moore.co=
m> wrote:
> >> On Tue, Jan 30, 2024 at 4:40=E2=80=AFAM Kunwu Chan <chentao@kylinos.cn=
> wrote:
> >>>
> >>> commit 0a31bd5f2bbb ("KMEM_CACHE(): simplify slab cache creation")
> >>> introduces a new macro.
> >>> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> >>> to simplify the creation of SLAB caches.
> >>>
> >>> Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
> >>> ---
> >>>   kernel/cred.c | 4 ++--
> >>>   1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> This seems reasonable to me, unless I see any objections I can pull
> >> this via the LSM tree next week.
> >
> > Actually, never mind, the original posting has some non-ASCII junk in
> > the patch and I'm not able to import it cleanly.
> Thanks for reply.
>
> I checked the patch with the checkpatch.pl script and applied it to
> another machine to compile and found no issues.
> Seems ok to me, what should I do next to clean up that non-ASCII junk.
>
> And i use :perl -ne 'print if /[^[:ascii:]]/'
> 0001-cred-Use-KMEM_CACHE-instead-of-kmem_cache_create.patch seems ok too.

Look at the message when in the mailing list archive (link below) and
you'll notice the extra characters:
https://lore.kernel.org/all/20240130094037.76895-1-chentao@kylinos.cn/raw

.. and then look at a correctly submitted patch:
https://lore.kernel.org/all/20240126104403.1040692-1-omosnace@redhat.com/ra=
w

--=20
paul-moore.com