Received-SPF: pass (google.com: domain of linux-kernel+bounces-77103-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID:
 <SEZPR06MB695934C69446B4878115B17796562@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Fri, 23 Feb 2024 02:15:26 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 3/8] dt-bindings: clock: histb-clock: split into two
 header files
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Michael Turquette <mturquette@baylibre.com>, Stephen Boyd
 <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>
Cc: David Yang <mmyangfl@gmail.com>, linux-clk@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240222-clk-mv200-v3-0-f30795b50318@outlook.com>
 <20240222-clk-mv200-v3-3-f30795b50318@outlook.com>
 <5781c1a8-8097-49f6-b672-33a6bcf2ffaa@linaro.org>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <5781c1a8-8097-49f6-b672-33a6bcf2ffaa@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|PUZPR06MB5722:EE_
X-MS-Office365-Filtering-Correlation-Id: 5ef296b1-7ae0-48d0-f64d-08dc33d240e9
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	dNf9r79B5vKKZiwA0bRL4691QrpvbU638gwgNMf8TLYp+BGny8ie+KCakLC/RtHuiiSDsUEqzqx5f/KXGfpCr73EzrIJTsXFdlEkQC/VAdJsEygZcrDb556iCVn49w0kp9m7YsTfLKm5NW+lD1sXRExJOH89XNHXikZFZwi7FygL9PPZX7LG0K3JSk7duzKbiqk+VbCHkNY9Jp6T/3NEYRrnBy+BrSaRA3EovbxJvMzPrlJVLzDo9MOh8WwYz6UY3Vhl6sCfUqByKJoqFwOaksHCeM9kPew8W5S792UUVWWWTI0U9tNC/l6iITycvRQb+mipxDjUXxQCSG48V83FRxA0wmIMvqBeVUI6IxsQ9duZBEwJqPtXCVH6QGTOfFngBCYvTylSuAtNxFB2UJ7skNIzDdCRrjFklyKDY4t6fuUdh0fWEL9zMQYZt+24MukJghr/Zihj0dpjzIxRK1VEUxyvtdyeKFM3t4M0YBe8kOpngMzbZl+GJxzAnRsuliBl7pqvlX2Au9XtPWgIq7yqkhrikkrel9aMKSzRyIWnHeJ9QdUCRK5MNBXf4KRlsG0A
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?b0NvUnVDbVRUUkg0d002akRab1d3dUNVNXFoUDhodFlqZVVtcFZzcjQ0Z0I3?=
 =?utf-8?B?THR3MHJ1dVdSQzRNK2hndHVhWU5yVEdWdm5LcVpXSTBCKzVoOWNUNncvOFBV?=
 =?utf-8?B?bkhvUHQwTXlESXNIK0NvN1pKZ0QrR0VYeXVaWkxkTkFCOXZ5MWNHNWsvVFBn?=
 =?utf-8?B?RWRSRTNiRm5XdU1vYUY2bzlRaGdwd2MzOGJSeklRc05RZnlpWU9ZcGRzemJw?=
 =?utf-8?B?MlhZeEtEbnRVOUt6MHIyc2ZyZjI5K2pVOVp6YlUwQVpSZ0VJaU1JMHJvOGhl?=
 =?utf-8?B?VDB5ejlkU24yYUp1czlHOEVPeFlJR24ya2FvK2VkS2NRRi9hRTlsemQrUzdt?=
 =?utf-8?B?dFJYV2wyZzRzeERtVnBmT05jSzZNcHVjWWllZCt5VE9Cbnl4K3RFR1FXQU8r?=
 =?utf-8?B?NnY2STJGT1B1Z29PV2JuNFpzbW1hYk52bmFaTzJrSlkrZ0RFUENzYWo3Vity?=
 =?utf-8?B?UldFVU0yQVZaNGdFTDR2YTlOMEtsWHFXWG04YUM4RnV6cTI5OWlhMEVtQnlD?=
 =?utf-8?B?Y1MxcHVpU3lBSGVUTVFjVCtzckNKS01MSjAxRE9Ub2dMUjBVVDZDdnp2L3RC?=
 =?utf-8?B?RzNVdWVLTzljRDVKZWxVRjZNbm1ac3gvOE43MUQyeitHVHJ0cFZmMnNBdzB3?=
 =?utf-8?B?c21oRStxdW5DWlAzZlRkWmh6a3IxY2hVeVZrZ2V3OHM3U2RRS29GVmRWSmtD?=
 =?utf-8?B?Z296QUc2ZnJ0MXpYN09BeWo5d0IxektYdy9JQnpXa0tXSkIxbCtDWjV0bGs1?=
 =?utf-8?B?U3FiVHZkbVAzd1BMbFkyMDdLbmVGaWJ5QTh5bXBQbHg4bHd2NnhKcTVDZVNz?=
 =?utf-8?B?d2RxYzRPV0R2QWNYMXF6dnpHUkYvQUNhS0R1aHN1M2dVSFZJdSs0YXdmYld0?=
 =?utf-8?B?MW5ZTVkwRVh5d3htQUdjY1NYTGwyZDlQM0MzWFdtbzFWb0pvY2xzRnZXTy9Z?=
 =?utf-8?B?MkdCQ0szbHVNUGxkMDZlWm5yNEpWUElvcyttbkI0aE8wTnZBR3RPKzIxcU1S?=
 =?utf-8?B?RXUrMmE2WWR1VDZWU1d4WkwzWmxnS1ZzTU1tRE9TOS9WQm9EUURnNE9WbFZM?=
 =?utf-8?B?UTZYUGxZOVdYVUZzb1FtK095elAxdWRBSDIraEc3dU1WNCsxNkErK0hrSE5O?=
 =?utf-8?B?THk0elR2T1NNNlluYmR2aExYeGNBalpWQldYMnZlcU5NVzhTOXl2ZWxZRzA1?=
 =?utf-8?B?L09LOXh1NEN6aktKOW5oUWQ2a1RzMlNUNFJtRDJaODFXMENxMFNKNThHYzgv?=
 =?utf-8?B?UDc1YWU2RFBDWHBRWHlHd1VuQkxPNGFEejMvZFNKY1RnT3FNQVdpSXRvUk8x?=
 =?utf-8?B?QVY1SzhhYTFvdkU4Q21YdG51VEVqSHlnbEVCdGhzQ0VhN243b2ZsSFZPejZL?=
 =?utf-8?B?bjdGWTZ5ajhRTWZpNnByNUpkdm9jaGUxUmdjZkx0OVcvTzZ3azExODRhczJm?=
 =?utf-8?B?VGZXWjZONjdTTTJFQzZ3dnFRby9aVFZOWDMxYUxlYXB0VHlaR3QwUERNVlJh?=
 =?utf-8?B?cEFDNE9FcmlLUExHZkMvOWJVTGRXN3FYcHJQZWJkdEVMUHVKdUpUY3FrL3NF?=
 =?utf-8?B?Uno3aENPVEc3Uk1Jb3cxSmZ3YjRXZ1VPM25XcXJzRkF6L2lTb0E5NEQ3RURY?=
 =?utf-8?B?cCtpWXFSZTd6T2pDaE15QzJ2NlBqSnd6OExSNWRHRllFays2aVBHVmw4aUpq?=
 =?utf-8?B?WG9UTFhvR2c5SHRzTmptODQ2UG9QNEtaMGppWVdreTNVdTVXSU5rclYvcWM1?=
 =?utf-8?Q?ZJNYmW1oy0zPPTm5dQC2Br81dkteZe5DvVlugb4?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5ef296b1-7ae0-48d0-f64d-08dc33d240e9
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 18:15:30.8873
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5722

On 2/23/2024 2:11 AM, Krzysztof Kozlowski wrote:
> On 21/02/2024 17:41, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@outlook.com>
>>
>> The CRG driver between different SoCs provides different clocks and
>> resets. We should not provide a generic header file across all HiSTB
>> SoCs, instead each CRG driver should provide its own.
>>
>> Split histb-clock.h into two files: hisilicon,hi3798cv200-crg.h and
>> hisilicon,hi3798cv200-sysctrl.h. This header file is for Hi3798CV200
>> only actually. For other HiSTB SoCs, some clock definitions are missing.
>>
>> Create a new histb-clock.h to include these two files for backward
>> compatibility only. Deprecate this file as well.
>>
>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>> ---
>>   .../dt-bindings/clock/hisilicon,hi3798cv200-crg.h  | 62 ++++++++++++++++++
>>   .../clock/hisilicon,hi3798cv200-sysctrl.h          | 17 +++++
>>   include/dt-bindings/clock/histb-clock.h            | 73 +++-------------------
>>   3 files changed, 87 insertions(+), 65 deletions(-)


Should I fix the #ifndef #define #endif stuffs here? i.e. s/DTS/DT_BINDING


> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>

-- 
Regards,
Yang Xiwen