Received-SPF: pass (google.com: domain of linux-kernel+bounces-77189-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 22 Feb 2024 18:41:13 +0000
From: Mark Brown <broonie@kernel.org>
To: =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Arnaud Ferraris <arnaud.ferraris@collabora.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>, linux-sound@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 4/4] ASoC: sun8i-codec: Implement jack and accessory
 detection
Message-ID: <0c351386-f1df-443f-a997-261f5c60c852@sirena.org.uk>
References: <20240222181851.3398254-1-megi@xff.cz>
 <20240222181851.3398254-5-megi@xff.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="nDVapEvA1lBavuoE"
Content-Disposition: inline
In-Reply-To: <20240222181851.3398254-5-megi@xff.cz>


--nDVapEvA1lBavuoE
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 07:18:47PM +0100, Ond=C5=99ej Jirman wrote:

> +static struct snd_soc_jack_pin sun8i_codec_jack_pins[] =3D {
> +	{
> +		.pin	=3D "Headphone Jack",
> +		.mask	=3D SND_JACK_HEADPHONE,
> +	},
> +	{
> +		.pin	=3D "Headset Microphone",
> +		.mask	=3D SND_JACK_MICROPHONE,
> +	},
> +};
> +

The jack being a headset jack is going to be system specific isn't it?
Some systems might have separate headphone and microphone jacks.  I'd
not expect to see any pin handling code at all in a CODEC driver, that
belongs in the machine driver.

>  static int sun8i_codec_component_probe(struct snd_soc_component *compone=
nt)
>  {
>  	struct snd_soc_dapm_context *dapm =3D snd_soc_component_get_dapm(compon=
ent);
>  	struct sun8i_codec *scodec =3D snd_soc_component_get_drvdata(component);
>  	int ret;
> =20
> +	scodec->card =3D component->card;
> +

The fact that you're needing to look at the card here should be a bit of
a warning sign there.

--nDVapEvA1lBavuoE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmXXlUgACgkQJNaLcl1U
h9CKKgf/aoS85uaApPM+Hu5AKwDdPhzqPWfBz5tHxcaPCNpEosJgwvW7FkDEJJIs
7ODH56RBKAhTrzbyUAgg6PIgeOilZSXWzgUi5BkIqsSUJxW7jZJKa1Xk4XusRnOw
3bMp1wVMh1QlUVIV+0podvqlsDjEvC08l6Rq5hIRf7ZRxztdnsE9a774ZwTFyk2g
UZeFv6KT7PegfqSNtyIrt9s/ghKpPAoCffRPkNTIc8+ZbGeBReomWijInFrK82gb
rVHPuJdb5oXz/lH8Zj0LrFjEH511k6OxPwxGwwylruXbDyND/ur+YAhphUxrkTwO
YIdwQVpj84jPawxlailo/ViT+V7i+A==
=fWYW
-----END PGP SIGNATURE-----

--nDVapEvA1lBavuoE--