Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp529076rdb; Thu, 22 Feb 2024 10:55:01 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXBSNofHZcX9MrJmu4Vo6CNnZhVGOT50x0saxNQI83Ua/iMgcrXFTC9Vvn/iILXF/IBDP5K7fBlwXooCaKk6PefLb3P3ZT99wrB+NoFlQ== X-Google-Smtp-Source: AGHT+IEaSI9pZeOUQG+5jAzE9hLAGJtmX0+NEFC6NuxUGIhqpJKED2ZMlC0ri5o4dtXTjWSrzWGe X-Received: by 2002:a17:906:e2cb:b0:a3f:175b:ea91 with SMTP id gr11-20020a170906e2cb00b00a3f175bea91mr5077414ejb.13.1708628100868; Thu, 22 Feb 2024 10:55:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708628100; cv=pass; d=google.com; s=arc-20160816; b=Bp/BSK9BDXfR1ivMczOMPPfv8EMQhZSdP6X1mGGyEk2CcLJuYEVjn6Ke2oum7GqT21 +vKVJeoMtuNjOayZ63FTmNgzBq06srKkIpy1PbIfJJbDtAmrln/0NpeHs5ATm+8jjr4W aKW2jjeh3wt7v9i8GBdBN5bCZpLZ8l0cO0MuTgEOT23Quvze/HD2BZ0cAD01HgCuBIYj SxZw/V/72H9OqDQbSceTnXz9TILHSLP6Ywm3Atr0Kf90UKhrar9JoxwgOC6pd9skIj+v e5CbaqL6+j47RPwG5UiHwtEa+EIkFab0Rhn3jB5OlQ+zsv4oS4+JgMv7z8UxkOAhEORr p3wg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=S9LMKezFhDe/+/XZd0pFiyo2AngI9rPVyIDawCfhQ6c=; fh=9WrDgc5VS2poP12E6ie1LQeKTf4XYx892xViKVFuLYU=; b=tvIS2vn5V42sZWKFBWGodMgqXPcOr9Ec2bGOYfZ33PB9nfDmtw2gBetFSdkimfHINv juVq//TaLn4MnhydJNPsU6XyVUYs4VxxtgZxJb5BzTImpHSVy1CXBTahPtwtHFBIy3oK kxgvpoAhLenFyUop0bf3efs5564Sv6aeBSr8GVjbEs+Tt/LWFinIZbZrgFIZntN2JoOZ czngJs9AkpdgAscoE0FbDmyg05YVxb3LS7GjgEACYgHBXbgB4+pNQF3VBOaXFyNEBUzZ MNGrKZpXzK+yJyQG0SlsUFug2P0TKA05oqI7iGhGQp9VgdiBl9qEicMv3GihqNUqeocm gQDA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KED1dSQv; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77198-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77198-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id qw17-20020a170906fcb100b00a3ed15edbeasi3197399ejb.929.2024.02.22.10.55.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 10:55:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77198-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=KED1dSQv; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77198-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77198-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5173D1F24E27 for ; Thu, 22 Feb 2024 18:55:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 610976E61A; Thu, 22 Feb 2024 18:47:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="KED1dSQv" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 789136E5EA for ; Thu, 22 Feb 2024 18:47:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.21 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708627628; cv=none; b=Nno0fEQnRon77u4WzIa2Bzq10DYxa6UKzO1OdXLalglustVXD17nCrR0CAtzOoHWNjtd7Gmrqsmaj0q1rcJJMqYHgWlOoFGtTfCZkyqXU8Rcbmn2+4Ge+mCJ+Av93b0plPT0y2+mavcW9a/bGG72TwbBMIswPoXIcfd5AZeCqEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708627628; c=relaxed/simple; bh=Jz1V/iJm3ijUEiMt5XcbSL3EA8EwVnQsAvUWppwbJ7E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Iv2qbCOfcebn3wr+Nwl4jVBBQC3Hr/Mz2M1BhCDevI/Fa9gAOG5EcG3mVBiymtLBtoN8yGL3ORmE/OmvX/pb/YApqw0BSNeES17M6JHvJXBLv4JEban27HhpHRGnSnPZyXbnp9IwLrI2Yuvpx9IdrlN0KHvPiwypnt8nMXzx9lc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=KED1dSQv; arc=none smtp.client-ip=198.175.65.21 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708627627; x=1740163627; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Jz1V/iJm3ijUEiMt5XcbSL3EA8EwVnQsAvUWppwbJ7E=; b=KED1dSQvKEzGBLaG01vxuzsi8FwY0y/hBN3wx0m1gulcWwEoYUWQGJKP 0UCws+ZJuWRWEEBojIiplxTCCAdGMz+AifxVXKGzHiVibAGN3aVIYDhGB 2cb383CjUDtLtrNb4g5rlHwQrGVg54/XCNIaYFHqxdHAoGdsf3JEeNqb3 KM/bl5pcHGQ/ucRnQsJ2RJ/Km6f3NWn9R7lh7EopGY9zmSG2L31rWDPOv 3ruyTCoGQJQDebymn48GDNnKfm14id9phGu0w5chVXQtmoew0yu3ExXGm 7GCQvLrNQPBunz1mP96OXxTmP+tA9pIJcUa+MSyausZNAzK+hdTseXIVq g==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="2794645" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="2794645" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa113.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 10:47:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="10168367" Received: from jwbates1-mobl.amr.corp.intel.com (HELO [10.209.48.22]) ([10.209.48.22]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 10:47:05 -0800 Message-ID: Date: Thu, 22 Feb 2024 10:47:03 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] x86/mm: clarify "prev" usage in switch_mm_irqs_off() Content-Language: en-US To: Yosry Ahmed Cc: Ingo Molnar , Thomas Gleixner , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , Andrew Morton , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240126080644.1714297-1-yosryahmed@google.com> <20240126080644.1714297-2-yosryahmed@google.com> <88cb9996-0e9b-49ec-bc94-f816a5b64870@intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/22/24 10:43, Yosry Ahmed wrote: >> /* >> * This optimizes when not actually switching mm's. Some architectures >> * use the 'unused' argument for this optimization, but x86 must use >> * 'cpu_tlbstate.loaded_mm' instead because it does not always keep >> * ->active_mm up to date. >> */ > Yes, this is more clear, thanks! However, Andrew already merged that > patch into mm-stable, so it cannot be amended. I can send a separate > patch to rewrite the comment tho if you'd like, WDYT? > >> Also, I think it might be useful to have the rule that arch/x86 code >> _always_ calls switch_mm_irqs_off() with the first argument (the >> newly-named 'unused') set to NULL. I think there's only one site: > Agreed. I can also send a separate patch for this. Thanks! That would be great. I'd be happy to ack them.