Received-SPF: pass (google.com: domain of linux-kernel+bounces-77146-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <9cc1ccfa-5ddc-46d6-93ff-dab952191207@intel.com>
Date: Thu, 22 Feb 2024 11:29:59 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] cxl/hdm: Clean up a debug printk
Content-Language: en-US
To: Dan Carpenter <dan.carpenter@linaro.org>,
 Davidlohr Bueso <dave@stgolabs.net>
Cc: Jonathan Cameron <jonathan.cameron@huawei.com>,
 Alison Schofield <alison.schofield@intel.com>,
 Vishal Verma <vishal.l.verma@intel.com>, Ira Weiny <ira.weiny@intel.com>,
 Dan Williams <dan.j.williams@intel.com>, Robert Richter <rrichter@amd.com>,
 linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
 kernel-janitors@vger.kernel.org
References: <3d3d969d-651d-4e9d-a892-900876a60ab5@moroto.mountain>
From: Dave Jiang <dave.jiang@intel.com>
In-Reply-To: <3d3d969d-651d-4e9d-a892-900876a60ab5@moroto.mountain>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


On 2/21/24 11:14 PM, Dan Carpenter wrote:
> Smatch complains that %pa is for phys_addr_t types and "size" is a u64.
> 
>     drivers/cxl/core/hdm.c:521 cxl_dpa_alloc() error: '%pa' expects
>     argument of type 'phys_addr_t*', argument 4 has type 'ullong*
> 
> Looking at this, to me it seems more useful to print the sizes as
> decimal instead of hex.  Let's do that.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
>  drivers/cxl/core/hdm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cxl/core/hdm.c b/drivers/cxl/core/hdm.c
> index 7d97790b893d..0b1843631b26 100644
> --- a/drivers/cxl/core/hdm.c
> +++ b/drivers/cxl/core/hdm.c
> @@ -518,9 +518,9 @@ int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long long size)
>  	}
>  
>  	if (size > avail) {
> -		dev_dbg(dev, "%pa exceeds available %s capacity: %pa\n", &size,
> +		dev_dbg(dev, "%llu exceeds available %s capacity: %llu\n", size,
>  			cxled->mode == CXL_DECODER_RAM ? "ram" : "pmem",
> -			&avail);
> +			(u64)avail);
>  		rc = -ENOSPC;
>  		goto out;
>  	}