Received-SPF: pass (google.com: domain of linux-kernel+bounces-77219-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 22 Feb 2024 14:06:25 -0500
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>
CC: <dri-devel@lists.freedesktop.org>, Maarten Lankhorst
	<maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Tvrtko Ursulin
	<tvrtko.ursulin@linux.intel.com>, <robdclark@gmail.com>,
	<freedreno@lists.freedesktop.org>, <dmitry.baryshkov@linaro.org>,
	<intel-gfx@lists.freedesktop.org>, <ville.syrjala@linux.intel.com>,
	<quic_jesszhan@quicinc.com>, <linux-kernel@vger.kernel.org>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v3 2/2] drm/dp: drop the size parameter from
 drm_dp_vsc_sdp_pack()
Message-ID: <ZdebMVIA_EH_R_4D@intel.com>
References: <20240220195348.1270854-1-quic_abhinavk@quicinc.com>
 <20240220195348.1270854-2-quic_abhinavk@quicinc.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240220195348.1270854-2-quic_abhinavk@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z5ooizlSn63eNhbbf8jV1+L5JcEJB3I/Ukhjx0MJpPzyrw0ikTPBjp7YFIVF?=
 =?us-ascii?Q?sPi9QK5PkZYyDG0/hwbu5eG84WvalZE2L91RG7pIs9YpS7jZM0Rha4Z9wKl7?=
 =?us-ascii?Q?PNrN2iA6N1rmSdGjIiAGbms2Jfgf1qY3xw2vMuBu2kBNj6LmqGGEf/tcVs3j?=
 =?us-ascii?Q?4boaX8PygzxlsmKIDkXh3jYICxeZHYOhcc7Se2KAKyF0zlX8kBTPSj0k1LF/?=
 =?us-ascii?Q?mz1voJejZQc0ahX41Ey3wPu5yBffbiv3EfdyL2a8OkXdX/w+y+cgtiqsvkVC?=
 =?us-ascii?Q?ibQU1Py/VJtGGfUKJvX4BpDJg8XW1MDnOYsQONfpnoRbp06cEQHk4+cTPhQT?=
 =?us-ascii?Q?giHpAlITY38lfGgb4CPNQWxX5Ei+ymB7cFqIvfEcforXG4kLYaTW+uy9spLt?=
 =?us-ascii?Q?Uf3ILDy3+y481q9IdpsX2F2cu4EP0sKJU34SBl3gcxILRzQkl/y9lfYjqEPY?=
 =?us-ascii?Q?sibwk8DxBhJobfbDIJBzar3N5CidhId/6VORSEAeADKC/WrWgHTd/lM96mvn?=
 =?us-ascii?Q?yxEV/sXAn5v/UeSsbHcmcJjsfYVvb4wfTAI8WZ2rkWBrUHH5U3B6myj4bGCJ?=
 =?us-ascii?Q?xOiVUrKjGuzYo6Ltr0O6AWwREsleKIbcH67BcgN5N4X4iRDSCrMu8Xu/qMD+?=
 =?us-ascii?Q?6Ep/Kx+/YxzNwYBemrmKXucHkWYED9UkRikNIwV1MOR3F31RnOz3fP1jiSxN?=
 =?us-ascii?Q?4ZCoi18FoYoRsVTf7NXvLmn+4h8Dw3SbCUkFiTKI8ifZaVBLUb9V3DENu0+k?=
 =?us-ascii?Q?5jdO474ZUdZ7ZNXaN8PFlKDLkHPiJAsE8ZQBFdp9QBegTnC/hRFgBjVu8jXF?=
 =?us-ascii?Q?F4DHXOuJNz0P9myUbyk+Xpd9n1ts0+cF+kxwmabnYRnqHFkjSXRtnHO4v0R5?=
 =?us-ascii?Q?oq1hDXEl1PFinGKtRBcGv83EPxlQS3tRORndB/VukXArS/DynNJ8Es92WgxP?=
 =?us-ascii?Q?oHxMGSBUtr9UORt3ImrgKR72ClKADUpUMQz0KFtce83xWER8Ee2yC9XjfTS5?=
 =?us-ascii?Q?8AgOqU0S/VFDadeWgL6hh6ivzGzBpp++iCpI0agbq3c+AnBrnmzJQbrZrBFC?=
 =?us-ascii?Q?GA1fo2vwN81oqDYtr57/CnZpq5fbHVz0pceQP49YVUOfMKbzF8m2I8kPkqG9?=
 =?us-ascii?Q?nuYpaED6/tuUczP7dtTvOH9aT8e1n34r5hdYoWOkj9pg4uWxhRYts+3PhTDA?=
 =?us-ascii?Q?1RkY9Q6GAwY0kCugc+7M/9pmGXjykmugvHqc8foN0arFg+HiofuiNhXcTLd6?=
 =?us-ascii?Q?tW6crujAt3hvObbB2LZy+JQq2jJwtD8zH8XTRhROy4gp+MA/JZYsUWnfyLwG?=
 =?us-ascii?Q?cnjKHzl2OoC2J7nGWzPT8hRs3sXb/Qtyl+0HjNajYje+cAfmw2LvsZ/+1kHA?=
 =?us-ascii?Q?DKhH8B3v66R3Z7kTj6e5oc7g0LpNlX57p5oazdZKA2IH7PZb+UKoF9HI7saZ?=
 =?us-ascii?Q?LzjIPlYHrQ2YrGlWJfzwe3/2R/pbdqI4q9Mvv2H9bDSqrCYU8CkuU8NEvfjv?=
 =?us-ascii?Q?ckCjc0IHl2AVCh9xzrl9MH6EjIPB+5pUMw9XYBwSwZxB1gBjclDNRbwbM70H?=
 =?us-ascii?Q?KtdSxTkdL2kyuLDFRY6oBqLBQ2PN6XLDq/JyqJp6gjJiy0tGZiMJ0ogpU1wR?=
 =?us-ascii?Q?iQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ee04d144-870c-4446-09fb-08dc33d961c9
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 19:06:32.3240
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: NB+uIqZKy0VsKBNOKl4n6g1H4e8+BNDrCSx4wkx2B5fQEJ3GGmdI4wA2OXgWkXeDHbqCFn+LmVM06tUokQtI7w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6800
X-OriginatorOrg: intel.com

On Tue, Feb 20, 2024 at 11:53:47AM -0800, Abhinav Kumar wrote:
> Currently the size parameter of drm_dp_vsc_sdp_pack() is always
> the size of struct dp_sdp. Hence lets drop this parameter and
> use sizeof() directly.
> 
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
>  drivers/gpu/drm/display/drm_dp_helper.c | 8 ++------
>  drivers/gpu/drm/i915/display/intel_dp.c | 3 +--

Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>  include/drm/display/drm_dp_helper.h     | 3 +--
>  3 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index 6c91f400ecb1..10ee82e34de7 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -2918,19 +2918,15 @@ EXPORT_SYMBOL(drm_dp_vsc_sdp_log);
>   * @vsc: vsc sdp initialized according to its purpose as defined in
>   *       table 2-118 - table 2-120 in DP 1.4a specification
>   * @sdp: valid handle to the generic dp_sdp which will be packed
> - * @size: valid size of the passed sdp handle
>   *
>   * Returns length of sdp on success and error code on failure
>   */
>  ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc,
> -			    struct dp_sdp *sdp, size_t size)
> +			    struct dp_sdp *sdp)
>  {
>  	size_t length = sizeof(struct dp_sdp);
>  
> -	if (size < length)
> -		return -ENOSPC;
> -
> -	memset(sdp, 0, size);
> +	memset(sdp, 0, sizeof(struct dp_sdp));
>  
>  	/*
>  	 * Prepare VSC Header for SU as per DP 1.4a spec, Table 2-119
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index a9458df475e2..e13121dc3a03 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -4181,8 +4181,7 @@ static void intel_write_dp_sdp(struct intel_encoder *encoder,
>  
>  	switch (type) {
>  	case DP_SDP_VSC:
> -		len = drm_dp_vsc_sdp_pack(&crtc_state->infoframes.vsc, &sdp,
> -					  sizeof(sdp));
> +		len = drm_dp_vsc_sdp_pack(&crtc_state->infoframes.vsc, &sdp);
>  		break;
>  	case HDMI_PACKET_TYPE_GAMUT_METADATA:
>  		len = intel_dp_hdr_metadata_infoframe_sdp_pack(dev_priv,
> diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h
> index 8474504d4c88..1f41994796d3 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -812,7 +812,6 @@ int drm_dp_bw_overhead(int lane_count, int hactive,
>  		       int bpp_x16, unsigned long flags);
>  int drm_dp_bw_channel_coding_efficiency(bool is_uhbr);
>  
> -ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc,
> -			    struct dp_sdp *sdp, size_t size);
> +ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc, struct dp_sdp *sdp);
>  
>  #endif /* _DRM_DP_HELPER_H_ */
> -- 
> 2.34.1
>