Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp539586rdb; Thu, 22 Feb 2024 11:13:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXIIOd+rDeLgZhcW2LVg4qXfmscVJPRC+HBnUmIg8wzY9ghlmvVoonP3zaQ5SRbhu6LJrM8rya+UO93EMWN74N9fiQKso040LlY84O6Cw== X-Google-Smtp-Source: AGHT+IFYNfbmivsJc2paGgQfm/Gaa/2IrYrj/OlPZXRuZLIGX2OLIW+Sl9O83FFXsWTEDq2ynivW X-Received: by 2002:a17:906:80c9:b0:a3e:5a14:a2f7 with SMTP id a9-20020a17090680c900b00a3e5a14a2f7mr9243531ejx.64.1708629208570; Thu, 22 Feb 2024 11:13:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708629208; cv=pass; d=google.com; s=arc-20160816; b=xGBfI0kPyCwdiYb03ar3dvdx0d5euu0DJ2pQ369wYzxgSw4WdLDkVLTZ+9pcpQQcsS jX9U9hxbCFoXdmio8TDf/cWQ1a4Ob0YQhrC1q2XYaQ9ktioUy9nRK3ZsA6yx/wLhe7TD TM9hFDsyyWxEjWaMgElB7i3XXzaQt79sVWbk+nsMopEfK3DcGUznrhM1hUBdi9c8a5ds ZYFlvOF2vXXPFcoHWvto1k5DdYThwIrTLc8oatytdCPJiExUYG8MWz5jnVmAJvSH/oyo 3Z2qF/rDa/mkTKAdPeUoJsEuLl+zHKLMvF2clHSwbaYe5MTvFXF0m23p3ZBr3bgdiQRh +5Xw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=RA6xo9xVnozyL9f904nf23vVB8S14SsR+KowggJ7wsA=; fh=jW4M0oIlX9DseHBAcdWnHCFpF2gMYBqFCHcAQynaNO4=; b=DYOlGu/Yk/AisXp41s+93jLct0UbUFH6aQsQX5Cfr6hh8dg/QhukSnNJfAwUcdPLa4 szJIRzZHuRSN6QrvK2wJXjB/1lrqL/PFrov7p/iA3azAlHEzC3C7uhc5VFt3QoU/a2h+ bfs913NAM8T2BZ/DlFqcp/xruIadV2nGkolNrVks+Ldev2XQPI2/4+79ldVd9suj58d3 g9vcL+KfA0ktxDuv9mpSbe79OwbnhISFrkjN/98Htuy6vXDZFHYDHdnEnHslWT+DdNvZ 53VlBbXpDrTFbBRksYw3KJa4DLJCK6HlmkgjNsQJppFKzJh1VZTOlLZr8OfbPgEqlSj8 Fivg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=I84LOwF5; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77230-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [2604:1380:4601:e00::3]) by mx.google.com with ESMTPS id o11-20020a1709062e8b00b00a3f4fd85316si1420456eji.977.2024.02.22.11.13.28 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 11:13:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=I84LOwF5; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77230-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77230-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 7ACC61F286B8 for ; Thu, 22 Feb 2024 19:12:19 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 04F5D14B832; Thu, 22 Feb 2024 19:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="I84LOwF5" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77E3D54916 for ; Thu, 22 Feb 2024 19:11:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708629103; cv=none; b=NrC+qFjU9GhlSJ2FDjBse8nuZ7C2oGHR8C9VKqEvgXDrmyA4omzusPKVpAwOmUPI6epmbgbn9qwUequ1/oNOLcpiNWAjeRGGvFquDy4vCm/Q8uRbtZzKlAsjsq2PDUFiUikch/wQ2S9pMgq7f5HLKQaGbiGYlDC/F0lS+luzAgs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708629103; c=relaxed/simple; bh=RA6xo9xVnozyL9f904nf23vVB8S14SsR+KowggJ7wsA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EHm/JDAlGMZ9Ejci0hGz/DshkJJoPueh1Es7dsIPOJ9197+uKpWggElzRQCc4MTDJdWEBS9reebDrj9aArtPb5ycmbD5YuKit0ufu1NtmkKwI97Bl/c+CbpZ0OudUa9TP06CcWRCDnOGaD38ecsRHiXXGA7HHT8A802ANKoyqWY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=I84LOwF5; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708629101; x=1740165101; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=RA6xo9xVnozyL9f904nf23vVB8S14SsR+KowggJ7wsA=; b=I84LOwF5phxlaYQwJNAEK+oPCfvzb2EDMFF6ba6W2v5dHcLudbvVM6dT RpxAW1pEA1quttPoq2ZkyG/ekAZfO2sO8aE+AqT0DBCajR1GoMdiqKzYS zTTbAaw/88wSW4EAboMduq3G6HtSv3TtlHKY5vxhuilIe7ViiDBnriCPe /WRBhm65AoXcE5Gj1nxhIH/A7/PJcuQxbrO/E3JJ7gO1kiVldk052rb9u tCdy1UCYqu42jJxkO84B3IjV/08hNseLB1XdRpQ2yXQ1cumJ4xNGvMHlG L8MQvfr3HylQLm9ng3Wfhu0vt/6eFMZYXo4AOW68BFltqWu2MbFogx2ma Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="13507446" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="13507446" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 11:11:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="10174895" Received: from jwbates1-mobl.amr.corp.intel.com (HELO [10.209.48.22]) ([10.209.48.22]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 11:11:38 -0800 Message-ID: <55c537d9-4fd2-4b61-a30d-4cdbeb037875@intel.com> Date: Thu, 22 Feb 2024 11:11:37 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-stable 1/2] x86/mm: further clarify switch_mm_irqs_off() documentation Content-Language: en-US To: Yosry Ahmed , Andrew Morton Cc: Ingo Molnar , Thomas Gleixner , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240222190911.1903054-1-yosryahmed@google.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240222190911.1903054-1-yosryahmed@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/22/24 11:09, Yosry Ahmed wrote: > Commit accf6b23d1e5a ("x86/mm: clarify "prev" usage in > switch_mm_irqs_off()") attempted to clarify x86's usage of the arguments > passed by generic code, specifically the "prev" argument the is unused > by x86. However, it could have done a better job with the comment above > switch_mm_irqs_off(). Rewrite this comment according to Dave Hansen's > suggestion. Looks good, thanks for sending this! Acked-by: Dave Hansen