Received-SPF: pass (google.com: domain of linux-kernel+bounces-77244-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 22 Feb 2024 20:19:06 +0100
From: Pavel Machek <pavel@ucw.cz>
To: Vlastimil Babka <vbabka@suse.cz>,
	kernel list <linux-kernel@vger.kernel.org>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Oleksandr Natalenko <oleksandr@natalenko.name>,
	Kent Overstreet <kent.overstreet@linux.dev>,
	Jiri Benc <jbenc@redhat.com>, Sasha Levin <sashal@kernel.org>,
	stable@vger.kernel.org,
	Thorsten Leemhuis <regressions@leemhuis.info>
Subject: stable-kernel-rules was Re: fs/bcachefs/
Message-ID: <ZdeeKiTXc7WidRcs@duo.ucw.cz>
References: <g6el7eghhdk2v5osukhobvi4pige5bsfu5koqtmoyeknat36t7@irmmk7zo7edh>
 <uknxc26o6td7g6rawxffvsez46djmvcy2532kza2zyjuj33k7p@4jdywourgtqg>
 <2024022103-municipal-filter-fb3f@gregkh>
 <4900587.31r3eYUQgx@natalenko.name>
 <2024022155-reformat-scorer-98ae@gregkh>
 <aaf2f030-b6f4-437b-bb4e-79aa4891ae56@suse.cz>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="s+LkKkXk95XsNqZb"
Content-Disposition: inline
In-Reply-To: <aaf2f030-b6f4-437b-bb4e-79aa4891ae56@suse.cz>


--s+LkKkXk95XsNqZb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi!

> > Personally I think we are not taking enough, and are still missing real
> > fixes.  Overall, this is only a very small % of what goes into Linus's
> > tree every day, so by that measure alone, we know we are missing things.
>=20
> What % of what goes into Linus's tree do you think fits within the rules
> stated in Documentation/process/stable-kernel-rules.rst ? I don't know but
> "very small" would be my guess, so we should be fine as it is?
>=20
> Or are the rules actually still being observed? I doubt e.g. many of the
> AUTOSEL backports fit them? Should we rename the file to
> stable-rules-nonsense.rst?

There seems to be just one rule being observed: "It or an equivalent
fix must already exist in Linus' tree (upstream).". Every other rule is
broken pretty much all the time.

AUTOSEL is a problem.

Plus there's problem with dependencies -- if a patch A is need for fix
B, the rules pretty much go out of the window, huge patches are
applied, whitespace fixes are applied, etc.

There are even known-bad patches being applied, and then
reverted. Greg explained that it heps his process somehow.

For example in 6.1.53 review, my notes say 30% of the patches did not
match the documented rules. 42% for v6.1.76.

OTOH ammount of patches that cause "real" problems is not that great,
and we seem to have enough testing. Still, updating the documentation
to match the reality would be good (perhaps explaining that stable
does not have manpower to re-do the dependencies, and how "apply bad
and revert" works).

Best regards,
								Pavel
--=20
People of Russia, stop Putin before his war on Ukraine escalates.

--s+LkKkXk95XsNqZb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQRPfPO7r0eAhk010v0w5/Bqldv68gUCZdeeKgAKCRAw5/Bqldv6
8vdCAJ0RFoBCe44jaM/9Yby4MDmhD7BKnwCgow91ieOFc1Kq+uvHpe2550KDnV0=
=f+89
-----END PGP SIGNATURE-----

--s+LkKkXk95XsNqZb--