Received-SPF: pass (google.com: domain of linux-kernel+bounces-77235-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240217213010.2466-1-dsmythies@telus.net>
In-Reply-To: <20240217213010.2466-1-dsmythies@telus.net>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 22 Feb 2024 20:13:33 +0100
Message-ID: <CAJZ5v0gWPQhgmD1nCxJQhwzvUxVuCMghT28AkqCMGk-pHkuwrQ@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: fix pstate limits enforcement for
 adjust_perf call back
To: Doug Smythies <dsmythies@telus.net>
Cc: srinivas.pandruvada@linux.intel.com, rafael@kernel.org, lenb@kernel.org, 
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, 
	vincent.guittot@linaro.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 17, 2024 at 10:30=E2=80=AFPM Doug Smythies <dsmythies@telus.net=
> wrote:
>
> There is a loophole in pstate limit clamping for the intel_cpufreq CPU
> frequency scaling driver (intel_pstate in passive mode), schedutil CPU
> frequency scaling governor, HWP (HardWare Pstate) control enabled, when
> the adjust_perf call back path is used.
>
> Fix it.
>
> Signed-off-by: Doug Smythies <dsmythies@telus.net>
> ---
>  drivers/cpufreq/intel_pstate.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstat=
e.c
> index ca94e60e705a..79619227ea51 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2987,6 +2987,9 @@ static void intel_cpufreq_adjust_perf(unsigned int =
cpunum,
>         if (min_pstate < cpu->min_perf_ratio)
>                 min_pstate =3D cpu->min_perf_ratio;
>
> +       if (min_pstate > cpu->max_perf_ratio)
> +               min_pstate =3D cpu->max_perf_ratio;
> +
>         max_pstate =3D min(cap_pstate, cpu->max_perf_ratio);
>         if (max_pstate < min_pstate)
>                 max_pstate =3D min_pstate;
> --

Applied as 6.9 material, thanks!