Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp545461rdb; Thu, 22 Feb 2024 11:25:03 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXXQPYE6CSenG6kKZ8AewJQ48RRpMRaIdvVvz8xiEUlmmzk/oB1cA+TSeJGfZIu/T4xx0Be68asPG6ISTgyIba65GmO+ScC8x3nmtau0w== X-Google-Smtp-Source: AGHT+IHpzfhsBCSEP5qNkgr3akCs0mHvoDxOtw0fdsvkoF0BgV5M3ZvnbIQBSkSHKD53KEMHgOhR X-Received: by 2002:a17:902:ed4c:b0:1db:fed2:7a90 with SMTP id y12-20020a170902ed4c00b001dbfed27a90mr4010085plb.29.1708629902735; Thu, 22 Feb 2024 11:25:02 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708629902; cv=pass; d=google.com; s=arc-20160816; b=S6OTRTFK2I19Memqu0GUOt0jIAAtXCns0aiRPFrjRjF5cMPGwjC71WXrOx9W0gTdtn M7FBW1XnfhHaXyiKDGqMpGUxWuFZ6t5aiFc0BKOWYR4E7G1Ucvblnr2ToOZu8chxzgPc thyfIR79tQfrKpWW04AMd5RRdUDcRXGCNiQbuArb7l/ZGzVImUJsgsttOzF39zgJei7h b9GGH8HiZj3xbNAQwT5sMJXNfLwWEyruQhLyokqhJ/deAKzSdZUBsNMP+JjE4P3fNQ8Y u2cGm/5nExy1nSzy6EkQIeVQLlQdSSibsF0sTMpSxTGvPa+AXM2+mqjjCgiTZgihtdsF H+ng== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=0Qks+DDhYCmzTTbFrd2ThMT4amH+aqvX5uPDsqGmmfM=; fh=jW4M0oIlX9DseHBAcdWnHCFpF2gMYBqFCHcAQynaNO4=; b=YejdrSuCOfe2u17DqXI3xmZtZm1YlMbMdBgyYtLzDghjYbktrUzKORq2nUzyMICgZl 0hD/A1KY4EDQHJyDD1TPTRc4rBF5DMfMyvp8AJZaFUdanX93LwBr2tQBQExMTQhxmwsr DEfdpduy2tR4ZxI2uQUp3EJ/9Mp6149w7aqqX0ZqDeDvFkWY3crolXQOEiYqQ2CdO+96 /zF+iSMhs+CVX00AFbQEXtv/pJfPfHpXryG9LJj8avCU4nDWQw1nIbCtUZERB6qUsSPw s1pM4ZuAkH1vncJMhAqnu/lCrNp3SiU0SAbCJskGXjJ2EVC1wKoJ6XSmcVodk7pKXgYj N2Mw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="UuFDFpx/"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77231-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j6-20020a17090276c600b001da18419bb9si10629806plt.55.2024.02.22.11.25.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 11:25:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="UuFDFpx/"; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-77231-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77231-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 8C47F2917EB for ; Thu, 22 Feb 2024 19:12:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8A52C14B833; Thu, 22 Feb 2024 19:12:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="UuFDFpx/" Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1FE86548F8 for ; Thu, 22 Feb 2024 19:12:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.11 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708629125; cv=none; b=G10K5LCaJgI3R+D1A+u8qnUX9Dvgjz++MTkZEhgNPwGshcGb6F6+5QFCrIZ81iyS7SGSz5JlaRz4jBkhBNMk5yJjKJ8nRoth2mTnFWuKtZmTEJAR86AFRjIBh/awshTfMbAGbp43X8vgTCR0aca36HyhBkaDcrLmNa1a5QNm2xI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708629125; c=relaxed/simple; bh=0Qks+DDhYCmzTTbFrd2ThMT4amH+aqvX5uPDsqGmmfM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cdpxS027xdOyq9zKhUnFybwpwDH9XiMYOMHMj7e/2nEBz4kva6Y2nahw95HcpnTGmzsE+XBDHuLQTIUzdN5fas47T9UNMFSxCH5D1UIiG/pzGMgWXi688rDsdZwgGhVVt9v/oU/g7CtsGFDhHVztyoi6nbt0wOO7W4FpBrsTNjM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=UuFDFpx/; arc=none smtp.client-ip=192.198.163.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1708629124; x=1740165124; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=0Qks+DDhYCmzTTbFrd2ThMT4amH+aqvX5uPDsqGmmfM=; b=UuFDFpx/zfej6bKB1Xms9AXicfDRfwmckVwYBEXmdxbpYyyJUCVMRYVL KyQ0kIUGoK3eLmQ2xYY7LFSX5Zq4Hgd0MeT9QtY0oKp42k1zCxkTxuqAk aeqTGAdQX1wOu8A9Hi/uLdaiyFV2XSs0CfLJgz2EkaoGTr+9w5s+n2F3u a4MpCP5PTb4W/iUKMO+zp58rkNMeKLGzzd0dyqvGgiss5PQpqtjbiiuyk XL9loAtXlPPCPUvGgtb15ObsnH64sOQAlClFOOAXiQBfMD+5t/6IWDDIP r7V+5jrkFhrYCjzaHabI1wk91sT54aoMLWjETmC9/xmbs7BLByx9/Zjdt Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10992"; a="13507555" X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="13507555" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 11:12:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,179,1705392000"; d="scan'208";a="10175034" Received: from jwbates1-mobl.amr.corp.intel.com (HELO [10.209.48.22]) ([10.209.48.22]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2024 11:12:02 -0800 Message-ID: <7c0b97b7-48c0-4f8e-829a-8e237808d47f@intel.com> Date: Thu, 22 Feb 2024 11:12:02 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-stable 2/2] x86/mm: always pass NULL as the first argument of switch_mm_irqs_off() Content-Language: en-US To: Yosry Ahmed , Andrew Morton Cc: Ingo Molnar , Thomas Gleixner , Borislav Petkov , Dave Hansen , Andy Lutomirski , Peter Zijlstra , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240222190911.1903054-1-yosryahmed@google.com> <20240222190911.1903054-2-yosryahmed@google.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240222190911.1903054-2-yosryahmed@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/22/24 11:09, Yosry Ahmed wrote: > The first argument of switch_mm_irqs_off() is unused by the x86 > implementation. Make sure that x86 code never passes a non-NULL value to > make this clear. Update the only non violating caller, switch_mm(). Acked-by: Dave Hansen