Received-SPF: pass (google.com: domain of linux-kernel+bounces-77250-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240222083515.1065025-1-quic_kshivnan@quicinc.com>
In-Reply-To: <20240222083515.1065025-1-quic_kshivnan@quicinc.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 22 Feb 2024 20:22:51 +0100
Message-ID: <CAJZ5v0gDeCbQ5rGOfCdpsVUpAsq3L=9DoLFChHc5=Zdq9Jc_7g@mail.gmail.com>
Subject: Re: [PATCH] cpufreq: Limit resolving a frequency to policy min/max
To: Shivnandan Kumar <quic_kshivnan@quicinc.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>, Viresh Kumar <viresh.kumar@linaro.org>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, kernel@quicinc.com, quic_pkondeti@quicinc.com, 
	quic_namajain@quicinc.com, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 9:35=E2=80=AFAM Shivnandan Kumar
<quic_kshivnan@quicinc.com> wrote:
>
> Resolving a frequency to an efficient one should not transgress policy->m=
ax
> (which can be set for thermal reason) and policy->min. Currently there is
> possibility where scaling_cur_freq can exceed scaling_max_freq when
> scaling_max_freq is inefficient frequency. Add additional check to ensure
> that resolving a frequency will respect policy->min/max.
>
> Fixes: 1f39fa0dccff ("cpufreq: Introducing CPUFREQ_RELATION_E")
> Signed-off-by: Shivnandan Kumar <quic_kshivnan@quicinc.com>
> ---
>  include/linux/cpufreq.h | 18 +++++++++++++++++-
>  1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> index afda5f24d3dd..42d98b576a36 100644
> --- a/include/linux/cpufreq.h
> +++ b/include/linux/cpufreq.h
> @@ -1021,6 +1021,19 @@ static inline int cpufreq_table_find_index_c(struc=
t cpufreq_policy *policy,
>                                                    efficiencies);
>  }
>
> +static inline bool cpufreq_table_index_is_in_limits(struct cpufreq_polic=
y *policy,
> +                                                   int idx)

This is not really about the index only, but about the frequency at
that index too, so I'd call the function differently.

> +{
> +       unsigned int freq;
> +
> +       if (idx < 0)
> +               return false;
> +
> +       freq =3D policy->freq_table[idx].frequency;
> +
> +       return (freq =3D=3D clamp_val(freq, policy->min, policy->max));

Redundant outer parens.

> +}
> +
>  static inline int cpufreq_frequency_table_target(struct cpufreq_policy *=
policy,
>                                                  unsigned int target_freq=
,
>                                                  unsigned int relation)
> @@ -1054,7 +1067,10 @@ static inline int cpufreq_frequency_table_target(s=
truct cpufreq_policy *policy,
>                 return 0;
>         }
>
> -       if (idx < 0 && efficiencies) {
> +       /*
> +        * Limit frequency index to honor policy->min/max
> +        */

This comment need not be multi-line.

> +       if (!cpufreq_table_index_is_in_limits(policy, idx) && efficiencie=
s) {
>                 efficiencies =3D false;
>                 goto retry;
>         }
> --

Thanks!