Received-SPF: pass (google.com: domain of linux-kernel+bounces-77259-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 22 Feb 2024 14:27:46 -0500
From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Vlastimil Babka <vbabka@suse.cz>,
        Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, Lorenzo Stoakes <lstoakes@gmail.com>,
        Michal Hocko <mhocko@suse.com>, stable@vger.kernel.org
Subject: Re: [PATCH] mm, mmap: fix vma_merge() case 7 with vma_ops->close
Message-ID: <20240222192746.cb65qvtmhaikfeko@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
	Vlastimil Babka <vbabka@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, Lorenzo Stoakes <lstoakes@gmail.com>,
	Michal Hocko <mhocko@suse.com>, stable@vger.kernel.org
References: <20240222165549.32753-2-vbabka@suse.cz>
 <20240222185642.rmnp76oquu5wfo6c@revolver>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240222185642.rmnp76oquu5wfo6c@revolver>
User-Agent: NeoMutt/20220429
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?hf2z2kN6BQdeXPtC6RCo91WHlNpYZmxshQvya/EP8kwrK70l/verJ77JbHa1?=
 =?us-ascii?Q?JVujtDjWcKA7d5++/mg4Qlz3uJnaou+JQQvsQ76aphoMgs2tlfRg3RrbY5sG?=
 =?us-ascii?Q?vv9Ax+WMwLELJJHBGkdf+Gddkb7j3efQ59LnqBBLdRS/UtQXGetfh5+ykIhJ?=
 =?us-ascii?Q?xS51woa6UT0f1it+Ryj/DmPZ9H65ygxGVeQz9f7hzR7srCqq73cygiGefEbn?=
 =?us-ascii?Q?formrdAnBJHS51PLqkc5oqsyyzAh/fVpoFi0Tfn1C+3XzA9JgKO8CkRSzNSH?=
 =?us-ascii?Q?ZdFqFIJ/RrUWwFQoMhYSUhKsJjvJeRoTtjQ6Nou/uIC2AaF1w8yT1+D0/djm?=
 =?us-ascii?Q?H67C/0ylfKns0bh4xM2tTnWPRN7EZjpmwOMDXvXXJsBjtV5OBx9wRp2FE6D7?=
 =?us-ascii?Q?cSH+DVnHEvM7VbxVsrI692h3Uo1J6/lMsLTOTc1pJLJK1Ay08J/q1amoY1n5?=
 =?us-ascii?Q?AAIPDiWxw5/u9L2zJa8OBsI+yYCEeN8o2CSp4OO/BmEveLp5KMn88PdtFBMQ?=
 =?us-ascii?Q?S3nxT4BZcJKVjR65mEWy2ODXjQ3r7NtQx++B3sQENAfSkFJWgqJ0s+lqP7Vi?=
 =?us-ascii?Q?LYnY7xxPo2S+tw8Jps3kjCFlOGci+AJrQ3b82HipFfNuoqe8MRb+fO5aprKd?=
 =?us-ascii?Q?MI9rwLUgls4togTCaeN9/LPIDurjnYbBsyAdXsTRf8y1cuEcTe0i9Dznve/n?=
 =?us-ascii?Q?uRMuVWWXfHp6khLpbqT0FtWMOK52MyfDXB0DZkGG+kW1DEkFPesCyel+GnX/?=
 =?us-ascii?Q?oCTRYyCFcljwc0Owxc1OLBWpCFSm2c0jaomztUD0qXv/giv4gKMpIrLA8EAo?=
 =?us-ascii?Q?9IYBoDOn7YQatNSm9ZjR5o0nFLuAcMnlYn6TQiX3/robcvguYsCCMAgudTL1?=
 =?us-ascii?Q?HeM09Mt8/WA18aJd3L49rOhNzDi0guy1SJR9A/SScB6gC0K2gG3HAFzv0M9m?=
 =?us-ascii?Q?cmFZocF1WIcpOJ3jE48soEevDdPQZuIl2ZTGynADIjU/mV2vLkwWj84XSyUU?=
 =?us-ascii?Q?Ysh0Wpuzq8+VkJVoxn+nLqPwkq1a9pxq1F7XlEiHJwYrF3X/kLxhPp3KltAu?=
 =?us-ascii?Q?3ox5foJe9izGCUPW30KjdSIow9juhIEIJdz9Wh1X6cYbIWpSdom5hFIDQpA/?=
 =?us-ascii?Q?Cmch97ik/iviJ5VPDbk4MLoIxgdGuUylrZ3GZrSJXMSw7pgT7hfOxYypuCNI?=
 =?us-ascii?Q?9onVNSzHJt/duWXQnvYYmt082z19iPrxFNKN1lP0RquPZgpXAP43sfQN/jdP?=
 =?us-ascii?Q?ITV/UNfVmAguHlWGO+hX7n4+aF3uGiANJ+oEbPnRsxNb8XSNdjm0yn6rw6t+?=
 =?us-ascii?Q?4+U4ePwCBXotIH2+WEj7j6ZkgqdOzUpEThjGqwryu080Jw/zvU196CTAsRZG?=
 =?us-ascii?Q?JuMoRAZtWcB1tyxY20a2fdh1+mHRL+geAspUuEEBWP61CVsa0QeiA29FaYlR?=
 =?us-ascii?Q?yiN8QlN3KKSAmPLhSw5iHuycXcK+4HoY2ta/QAmyTGqjdPtWUobgcQo3oaMe?=
 =?us-ascii?Q?O/73IuYHgvye8Wp9BqWMmYVjXOqknjIdKHf11gBIHazOh29a1g+XYIIuVhp7?=
 =?us-ascii?Q?vt1h6hnmprXIAQhmomO2uurwCwsvxFVmDeTIwyzJxINjmVE5LUwPci6KOHl7?=
 =?us-ascii?Q?Eg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	R82EFkpcpcIa2LFxbzuamxd+DY7wZwj3g/IHQ9VX/u5MXP0Op89x0mQ4+6vNGcvTQEtLtC0ZQRaWzcp8iErP997PcBwzgg4cN6WaC+w3YAJ7Ps+u3SN2R6L21SQH9JLBB0BIWdB2b/qhKkRqzPNs7ABSCqn9aAagIY5KYT87V0feufrhtmaTcOgXHnu1iLpsms2yfRiamFdWWWEu2RSuzXikDNJw5/0RdxSqPhQShVHOcU3nm9YRGvNGSj8fikxcdIThAxQum3MDQr7BZYWJ57xc2nyjBpS1rOaez3w4XMY2Tsz+bvGk0OeNy/4a1UhUo4ePsi4X9qNbCLbFKfm6y2JUei0mOpLvTQxlazSTUXhadbYNKearAgSM8w0cPoGtJcTrkWTQG7FHo/NF208lbMjcyMLsQMUXCk7k3SkGyI1BHjrqxeVV414ej4rOnP1+iZc8DWEHgnqb/icwuak1IYnAs/8Z7wlKKmdg1FycoWO+yqMyJaiT2EiFO/5VPIWh/UAFKtkSdy72jRcENAV+YKmKKQ1kpl3bHDrikgjdrbKTjCDbgqQJsoLDl0vAWcA8zvRfAB6vvLtgesP8ICDP5d30AmD+fhUW5qy9wQyolJY=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2f51f54e-4fd1-40e2-cff8-08dc33dc5ab7
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7933.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 19:27:48.8750
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zhnsMJM2qPpmxEDLuAXdG+DtsWXLhGXexU63aSJuaYjq9JWDypxg9Eu3eI0iOCRbOg3MmCg8hj3fx01Uft+9Sw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4456
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-22_15,2024-02-22_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0
 bulkscore=0 adultscore=0 suspectscore=0 spamscore=0 mlxlogscore=834
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2402220152
X-Proofpoint-GUID: UFWIyIylH3Mf4agbYpfDIB3WWcUP8zo8
X-Proofpoint-ORIG-GUID: UFWIyIylH3Mf4agbYpfDIB3WWcUP8zo8

* Liam R. Howlett <Liam.Howlett@Oracle.com> [240222 13:56]:
> * Vlastimil Babka <vbabka@suse.cz> [240222 11:56]:
> > When debugging issues with a workload using SysV shmem, Michal Hocko has
> > come up with a reproducer that shows how a series of mprotect()
> > operations can result in an elevated shm_nattch and thus leak of the
> > resource.
> > 
> > The problem is caused by wrong assumptions in vma_merge() commit
> > 714965ca8252 ("mm/mmap: start distinguishing if vma can be removed in
> > mergeability test"). The shmem vmas have a vma_ops->close callback
> > that decrements shm_nattch, and we remove the vma without calling it.
> > 
> > vma_merge() has thus historically avoided merging vma's with
> > vma_ops->close and commit 714965ca8252 was supposed to keep it that way.
> > It relaxed the checks for vma_ops->close in can_vma_merge_after()
> > assuming that it is never called on a vma that would be a candidate for
> > removal. However, the vma_merge() code does also use the result of this
> > check in the decision to remove a different vma in the merge case 7.
> > 
> > A robust solution would be to refactor vma_merge() code in a way that
> > the vma_ops->close check is only done for vma's that are actually going
> > to be removed, and not as part of the preliminary checks. That would
> > both solve the existing bug, and also allow additional merges that the
> > checks currently prevent unnecessarily in some cases.
> > 
> > However to fix the existing bug first with a minimized risk, and for
> > easier stable backports, this patch only adds a vma_ops->close check to
> > the buggy case 7 specifically. All other cases of vma removal are
> > covered by the can_vma_merge_before() check that includes the test for
> > vma_ops->close.
> > 
> > The reproducer code, adapted from Michal Hocko's code:
> > 
> > int main(int argc, char *argv[]) {
> >   int segment_id;
> >   size_t segment_size = 20 * PAGE_SIZE;
> >   char * sh_mem;
> >   struct shmid_ds shmid_ds;
> > 
> >   key_t key = 0x1234;
> >   segment_id = shmget(key, segment_size,
> >                       IPC_CREAT | IPC_EXCL | S_IRUSR | S_IWUSR);
> >   sh_mem = (char *)shmat(segment_id, NULL, 0);
> > 
> >   mprotect(sh_mem + 2*PAGE_SIZE, PAGE_SIZE, PROT_NONE);
> > 
> >   mprotect(sh_mem + PAGE_SIZE, PAGE_SIZE, PROT_WRITE);
> > 
> >   mprotect(sh_mem + 2*PAGE_SIZE, PAGE_SIZE, PROT_WRITE);
> > 
> >   shmdt(sh_mem);
> > 
> >   shmctl(segment_id, IPC_STAT, &shmid_ds);
> >   printf("nattch after shmdt(): %lu (expected: 0)\n", shmid_ds.shm_nattch);
> > 
> >   if (shmctl(segment_id, IPC_RMID, 0))
> >           printf("IPCRM failed %d\n", errno);
> >   return (shmid_ds.shm_nattch) ? 1 : 0;
> > }
> > 
> > Fixes: 714965ca8252 ("mm/mmap: start distinguishing if vma can be removed in mergeability test")
> > Reported-by: Michal Hocko <mhocko@suse.com>
> > Cc: <stable@vger.kernel.org>
> > Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
> > ---
> >  mm/mmap.c | 11 ++++++++++-
> >  1 file changed, 10 insertions(+), 1 deletion(-)
> > 
> > diff --git a/mm/mmap.c b/mm/mmap.c
> > index d89770eaab6b..a4238373ee9b 100644
> > --- a/mm/mmap.c
> > +++ b/mm/mmap.c
> > @@ -954,10 +954,19 @@ static struct vm_area_struct
> >  	} else if (merge_prev) {			/* case 2 */
> >  		if (curr) {
> >  			vma_start_write(curr);
> > -			err = dup_anon_vma(prev, curr, &anon_dup);
> >  			if (end == curr->vm_end) {	/* case 7 */
> > +				/*
> > +				 * can_vma_merge_after() assumed we would not be
> > +				 * removing prev vma, so it skipped the check
> > +				 * for vm_ops->close, but we are removing curr
> > +				 */
> > +				if (curr->vm_ops && curr->vm_ops->close)
> > +					err = -EINVAL;
> > +				else
> > +					err = dup_anon_vma(prev, curr, &anon_dup);
> >  				remove = curr;
> 
> This separates the check for potentially merging previous to a later
> failure case.  Would it be better to check:
> 	if (curr && curr->vm_ops && curr->vm_ops->close)
> 
> and not set merge_prev = true, ie we cannot merge with the predecessor?
> 
> That way we would exit as merge_prev == false.
> 
> We would have the added benefit of not having to look at merge_prev &
> merge_next case with this vm_ops->close in mind (case 1 and 6).. because
> I'm pretty sure we can currently get to case 6 in this way:
> 
> merge_prev = true
> check for merge_next.. can_vma_merge_before(next...);
> is_mergeable_vma(next.... , true);
> if (true && next->vm_ops && next->vm_ops->close) /* Fine for next.. */
> 
> Remove curr by case 6 without checking curr->vm_ops &&
> curr->vm_ops->close
> 
> If I am correct, then are we blaming the right commit?

I am not correct.
The file check will ensure the same ops, so the file and ops must match.
As long as both are checked on one VMA then it will work as required.

> 
> Perhaps we should just fail earlier when we find a curr with the close
> ops?

I'd rather fail earlier, but it's not a big deal.

> 
> >  			} else {			/* case 5 */
> > +				err = dup_anon_vma(prev, curr, &anon_dup);
> >  				adjust = curr;
> >  				adj_start = (end - curr->vm_start);
> >  			}
> > -- 
> > 2.43.1
> >