Received-SPF: pass (google.com: domain of linux-kernel+bounces-77255-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240221142550.1814055-1-lukasz.luba@arm.com>
In-Reply-To: <20240221142550.1814055-1-lukasz.luba@arm.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 22 Feb 2024 20:26:17 +0100
Message-ID: <CAJZ5v0h-HmTTGY2N2BK6paga8yaqv8u6rLosH5oqrRHPMt3Xkg@mail.gmail.com>
Subject: Re: [PATCH] PM: EM: Fix nr_states warnings in static checks
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org, 
	kernel test robot <lkp@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 21, 2024 at 3:25=E2=80=AFPM Lukasz Luba <lukasz.luba@arm.com> w=
rote:
>
> During the static checks nr_states has been mentioned by the kernel test
> robot. Fix the warning in those 2 places.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com>
> ---
>  kernel/power/energy_model.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
> index 7101fa3fa0c0..b686ac0345bd 100644
> --- a/kernel/power/energy_model.c
> +++ b/kernel/power/energy_model.c
> @@ -280,6 +280,7 @@ static int em_compute_costs(struct device *dev, struc=
t em_perf_state *table,
>   * em_dev_compute_costs() - Calculate cost values for new runtime EM tab=
le
>   * @dev                : Device for which the EM table is to be updated
>   * @table      : The new EM table that is going to get the costs calcula=
ted
> + * @nr_states  : Number of performance states
>   *
>   * Calculate the em_perf_state::cost values for new runtime EM table. Th=
e
>   * values are used for EAS during task placement. It also calculates and=
 sets
> @@ -728,7 +729,6 @@ static void em_check_capacity_update(void)
>                 struct cpufreq_policy *policy;
>                 unsigned long em_max_perf;
>                 struct device *dev;
> -               int nr_states;
>
>                 if (cpumask_test_cpu(cpu, cpu_done_mask))
>                         continue;
> @@ -749,7 +749,6 @@ static void em_check_capacity_update(void)
>                 cpumask_or(cpu_done_mask, cpu_done_mask,
>                            em_span_cpus(pd));
>
> -               nr_states =3D pd->nr_perf_states;
>                 cpu_capacity =3D arch_scale_cpu_capacity(cpu);
>
>                 rcu_read_lock();
> --

Applied, thanks!