Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp554104rdb; Thu, 22 Feb 2024 11:43:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV5UvO669n1JrmnPQ8auasYOBZpbM5d2fO38ul1ALTgd9gXJsqJE8LfQGoYXYcum0Yvz/xW1lDChmnq+zNT8UTDYwf8sWKOrKFd7SND/w== X-Google-Smtp-Source: AGHT+IFh7B7P84k0LdT/gSPSyKFV+7t1iL5Qt5Y8NXaeT51DQ8kuXk3/DKZQv9QqmyrHPV117YNQ X-Received: by 2002:a05:6a21:2d8d:b0:19e:9adc:b274 with SMTP id ty13-20020a056a212d8d00b0019e9adcb274mr29663983pzb.41.1708631037735; Thu, 22 Feb 2024 11:43:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708631037; cv=pass; d=google.com; s=arc-20160816; b=xNSJnHWlHN+phMOvc3sM8U9VjT8Fyc0td0U22OptR3VbFyAJ5XM7KCyu/fM2F/DRb4 jmP1P1V4UGoqaCW0lBOmnbLALH3gVugu5roH/b/R+8JCMhStKpIJ5HSczfXGMgjwE/rT FSpKYVcF4IKsHGBbHRjY7L9KXUJCTglPqX++unG5eD1bRq8sxcREO4ZQmP6ViUHpzVyN uZnEi01b2ol5Y2CFj/Yf6Q7gQn4rJK3XPMwpobO/sHj3iTu2nhwOBKI2iQfLLeHcjfG2 c1eAROZJhbd9x+yLqBDAbLJq4ewuCNoitxGyxWkn8SJ6n9q4QbCAFURo3zHAkbUo/7Yx eF2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=W4vpO/kuwhEAbu5lyhpp3cdM+wCLzEUK+hlVl6YVNB0=; fh=17JuAwdwVfQj4/Ob2E3Tz+el5fCUs7itpKEjqHzj43c=; b=VkeZIuH7V6VpFiNvogeKQOGVzTkMTT3Ibork/MoYDXbvj8wwy10lojxAruPS1++c1L R6aFLj7cdc+hMyfnzwyzZl2LrCbCwdHwZg2iV3q2tGzm+JvC7tvUbiz8QC9ynQSKFz9/ nc1rLooaXWYV0KK+2k2H5xlRaX5GX+ekQi4jo9ZjzA7LBKfu7FTg1ria6Qmc6PVnMKBm 2sTg65tP33fGI6gRATv+LkZds9Q1zIprTJL86xDSwyHGI2l2/RwF1wnwPbwi6bBL0clE tHzZTOxaa+hPSBGJoubqSDcMTNUJI8SUOzL+ke5IEHgMMg30uBIsumACU9Qlfe/V3jA1 Q60g==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jZnn94kL; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77197-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77197-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id x185-20020a6363c2000000b005dc477d69ddsi10637145pgb.25.2024.02.22.11.43.57 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 11:43:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77197-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=jZnn94kL; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77197-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77197-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 44BF9B2DB65 for ; Thu, 22 Feb 2024 18:54:48 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 43AA56E604; Thu, 22 Feb 2024 18:47:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="jZnn94kL" Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D17CA6E5E1 for ; Thu, 22 Feb 2024 18:47:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708627627; cv=none; b=PHRq0T2KZVAw0MmjIAuh5UoMd8f+p19J53aC9Y06mUhybPInPs5aYEoQmUUyvVNq7kAy/3ZHrNlYOmkGw3jdJwjEZeD9q4QvQ/qxn0bmXwXZTTEsCOro9/ihcpLlNcOH90Gvr9ARyx2H09JKrN6q6oxlclZ9sDMSFwgrdF3JZU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708627627; c=relaxed/simple; bh=NwoZ/s/YB6zInacwyEad3YhKFkgtInk+ILfXRdyVvto=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lDIHlzLh2k0COtwKvozwR7MhfLC9AXjOtSzT2YXvdppYcnj6yD4YuLxA3cEZPAQSy6s4M2OhvW5EiMM/4cuknc+2lgxPs6zFV6bwo4idcOplwKhqz+uJfD/eT65n0zrC9SAAc0ijBDmkGYou9BHMIhQxi6FsxqmjxLBSL26D3dc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=jZnn94kL; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6e4560664b5so1934528b3a.1 for ; Thu, 22 Feb 2024 10:47:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708627625; x=1709232425; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=W4vpO/kuwhEAbu5lyhpp3cdM+wCLzEUK+hlVl6YVNB0=; b=jZnn94kLXyYka+9eXc6AizHVEys8TFY2OiJFG7PIg2WwOoOPGz/WnjIUBC7K1XuDyA N9WXbD4i43+FAb+UXraPUYghcAZtBZ9c/hsS++vfJPdXD4DWX6Tn2LFckfPHMQVQ39OA b5jXaD5DSRAvbP8DPkBMeXcy0mMxLq472fvQY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708627625; x=1709232425; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=W4vpO/kuwhEAbu5lyhpp3cdM+wCLzEUK+hlVl6YVNB0=; b=ep6i6jhEKD9Kmg77Lbs7HcpDg8FQvwrCrXv3Wjf/JADWyE6EMI7BtoppXzCvYpf47o zFIIcP9kysQ1PuI+6/pMXc86xB3FZdEKYuVi8lDX1dS0dxwKF8htmUIWUEqDpTzk0f8f Bg/9LERqhPQ9dVSDbzMswEeWtPlrRFbTS+OZ3fbFk602wsWZoomKxoTfaBvgLyWRd/we Zb5h+jotNJFM1zUxSkSz+eH3XqxHNLNarI4dGnogzSlsnnMfycknfwsPvXQWT0mfVZ0Z 90Dcs6nW0hhM23dSDeMoOyu8LcM3GrizDz47noJTzVn+4soOhYqgN14JKfhidrtAeOcb gD2g== X-Forwarded-Encrypted: i=1; AJvYcCUQmM6Sir6ZIaRA/+GJm2czbTXqJgInFqFORAEM8Kr2VdnfTwWf7V/nXE71n9L+EgxVoifAcPo7G+VYSISnuW2c8mDolPW3l7QmsVPk X-Gm-Message-State: AOJu0YxiY4IP9ywdIO8sMvTsRCBEo++rLTjKEmk1ZdasTrdcjlOOkCub SpYMWYo9sNZOpJ2mvbU4+EoQpfr/9VqNWcresBGBMjUGkwjStacDl2UI+JDP9A== X-Received: by 2002:a05:6a00:6c95:b0:6e4:6a3f:f065 with SMTP id jc21-20020a056a006c9500b006e46a3ff065mr12647864pfb.10.1708627625231; Thu, 22 Feb 2024 10:47:05 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id s12-20020aa7828c000000b006e0651ec05csm11280323pfm.43.2024.02.22.10.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 10:47:04 -0800 (PST) Date: Thu, 22 Feb 2024 10:47:04 -0800 From: Kees Cook To: Daniel Borkmann Cc: Mark Rutland , "Gustavo A . R . Silva" , Alexei Starovoitov , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , Haowen Bai , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, Yonghong Song , Jonathan Corbet , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Joanne Koong , Yafang Shao , Kui-Feng Lee , Anton Protopopov , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH v6] bpf: Replace bpf_lpm_trie_key 0-length array with flexible array Message-ID: <202402221046.020C94D@keescook> References: <20240222155612.it.533-kees@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222155612.it.533-kees@kernel.org> On Thu, Feb 22, 2024 at 07:56:15AM -0800, Kees Cook wrote: > Replace deprecated 0-length array in struct bpf_lpm_trie_key with > flexible array. Found with GCC 13: Yay! This finally passes all of CI: https://patchwork.kernel.org/project/netdevbpf/patch/20240222155612.it.533-kees@kernel.org/ -- Kees Cook