Received-SPF: pass (google.com: domain of linux-kernel+bounces-77226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <be49c794567f3bd00ae16e91b54fe8cfe6cb4999.1708245599.git.christophe.leroy@csgroup.eu>
 <202402180106.25E08136F5@keescook>
In-Reply-To: <202402180106.25E08136F5@keescook>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 22 Feb 2024 20:09:24 +0100
Message-ID: <CAJZ5v0jbPvP6TfF9QS5szaW3bfGw6M=kzOFjTDAOjKHBiWNdrg@mail.gmail.com>
Subject: Re: [PATCH] PM: hibernate: Don't ignore return from set_memory_ro()
To: Kees Cook <keescook@chromium.org>, Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, linux-pm@vger.kernel.org, 
	linux-kernel@vger.kernel.org, 
	"linux-hardening @ vger . kernel . org" <linux-hardening@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, Feb 18, 2024 at 10:07=E2=80=AFAM Kees Cook <keescook@chromium.org> =
wrote:
>
> On Sun, Feb 18, 2024 at 09:40:58AM +0100, Christophe Leroy wrote:
> > set_memory_ro() and set_memory_rw() can fail, leaving memory
> > unprotected.
> >
> > Take the returned value into account and abort in case of
> > failure.
> >
> > Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> More set_memory* consumers! :) Error paths look good to me.
>
> Reviewed-by: Kees Cook <keescook@chromium.org>

Applied as 6.9 material, thanks!