Received-SPF: pass (google.com: domain of linux-kernel+bounces-77225-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 22 Feb 2024 14:09:16 -0500
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Abhinav Kumar <quic_abhinavk@quicinc.com>
CC: <dri-devel@lists.freedesktop.org>, Maarten Lankhorst
	<maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Tvrtko Ursulin
	<tvrtko.ursulin@linux.intel.com>, <robdclark@gmail.com>,
	<freedreno@lists.freedesktop.org>, <dmitry.baryshkov@linaro.org>,
	<intel-gfx@lists.freedesktop.org>, <ville.syrjala@linux.intel.com>,
	<quic_jesszhan@quicinc.com>, <linux-kernel@vger.kernel.org>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v3 2/2] drm/dp: drop the size parameter from
 drm_dp_vsc_sdp_pack()
Message-ID: <Zdeb3DHQ_WMTp8zR@intel.com>
References: <20240220195348.1270854-1-quic_abhinavk@quicinc.com>
 <20240220195348.1270854-2-quic_abhinavk@quicinc.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240220195348.1270854-2-quic_abhinavk@quicinc.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Vkop/vfiJZxDCjzZx7QmuTRX1Vt6CgSbRk9Kd44JX6yViQ6h9HO5shxlTfqm?=
 =?us-ascii?Q?u87qi3752CyEtP7Zka5IGBSP5+aXTSc8vWlAg64nniBD2fRDTf9vci1svXit?=
 =?us-ascii?Q?+9mHo3jPVpb5bIngp2Z334mNG6E26vdie2lasg1LuDGkg0hXThXwjfcA0gHM?=
 =?us-ascii?Q?//seJMHWtB7mRDa3JV8XmOOlMThW9iUgEuQvGZduIBePFivpKQ5BuyWjqHIM?=
 =?us-ascii?Q?YMyQzyu3+pMFvKCiqE7r0C5aYf4yFW4LJtXiMmpIppM4yaU0YBrnIA4UhhgC?=
 =?us-ascii?Q?/njBBVGOzx5W8Uo++y/5wzVl4ELRhNbGDl/1mDiCsRLs8tfON0K3NM4QWWvl?=
 =?us-ascii?Q?FxHi1N9j7T9CZC+HEi4tkk/K/FFDTfU2aJpxdoGVHXS0O8iCBmeOa5H3o8S8?=
 =?us-ascii?Q?G/YLNTIoH43wHb+p/MLDOJk9kw0cwS7xx5hF+q7qXO9/uQxbQ2ELIH1+nit7?=
 =?us-ascii?Q?35jHdbNUDkMOH8Tx+SOUBpTcny1+la1rn75n3iAXduZV0qWMmxi+Uwzq8XQU?=
 =?us-ascii?Q?/qTjdz5UbokigIVrWLwcJEV+oibi3DlEaHo5Gj6GOLs2h0Xl3eWSkq8il3U9?=
 =?us-ascii?Q?oWbhihMLszIPIE5NvdDohn8zE6PPxSSH4XIVtkGJMM6M4aN5RHwyo18UzB6w?=
 =?us-ascii?Q?rih2CWl+2MswHs7r+aU9QIxhtQV6cot8rhElhwYodilvGbs8MR3bapmAl4tN?=
 =?us-ascii?Q?FcfvrB21nVkHBPZiID9hDk0ujAKnKBjO3TuzzIGF5Q27g5iKOdcgtIgyfAss?=
 =?us-ascii?Q?uFh/KyilS8JZSO5o9zow8k/OwS0iSM8MABfaAVjuEd3bjezBIme9QHZAt1nj?=
 =?us-ascii?Q?rOTkEHcL1aDc/tYce2NEm81wPdT8zIfUDHUcUhlJYBTVnL1i9esqp7sRRtLj?=
 =?us-ascii?Q?zL5FXC8/YIjaJii6RSfaTPYbuE6bsG9CgcTagKX7vHbiICkX+s7Frn8K+LH5?=
 =?us-ascii?Q?jYgqgBiENEXytIjxEDf8Dlg/WP5ucvrXUzezD/mr2p/x9rPGVPCVd9xy4ISQ?=
 =?us-ascii?Q?dMpesRaXNR0gvjjRIelhEcZo6a1/0LsDUxCndFo8GBeQJwXrIIMHp+E5zKlU?=
 =?us-ascii?Q?L3vhYtbc6gI3fMNuX5gi9xfYpicNFYL50isBJE5j0hku1RSailK/5Hv/xB/e?=
 =?us-ascii?Q?vDLmhWZBrZh1Dypx/bDovDoBalA1kXBSiblK/K1aoqyhD9vhZJHVffJWLG8a?=
 =?us-ascii?Q?l6stkrFv/VWY9+E1mXdagUUovaBMDMVpYtg13saH3QOvHiRj5DfQN+9FEEEp?=
 =?us-ascii?Q?wMr/mxI4JZJG1bnUXVxwTn99GhGIzF2dm0iVz0mE2audwaFx6jtE3Far0cXq?=
 =?us-ascii?Q?RJb7Ni9sHUXCdkJ2MSPK8sfzQprB/ZuON/GLsNzVc7mjfUoJ0riokHQPp2F2?=
 =?us-ascii?Q?9O5c1dM9F0uwUXmoQECQtIE4XPU5D2dVmssRWAspxdBsPzvKzqJPZDo59Flj?=
 =?us-ascii?Q?nDfqqeqBIamQnVSEsS5QXHBvTXiHy6/pT9LK3l6PMMZN+5zFZAfnJxaFlYMD?=
 =?us-ascii?Q?rWmDF0NWsc69aeB3rAhe/cgW5r4JmhPnmNm+PZ/ast3wnsZ1ebLz/WEevHRH?=
 =?us-ascii?Q?LsO3UrGESCNz1DIK8DyV/VxpBggd/M5l7eX+0J0i+AnpiMjqnqpGkz7wM8Y/?=
 =?us-ascii?Q?CA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0f3a1377-b527-4535-8e1c-08dc33d9c713
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6059.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 19:09:22.2584
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b0HkKvKFNCF68c8yiTE+I2+ns133c0VIWiuQoDamFZZJ1ofBwj9bcP/DeRBiEytOh+KNpuz6v3Qet1pYqpnQjA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB6800
X-OriginatorOrg: intel.com

On Tue, Feb 20, 2024 at 11:53:47AM -0800, Abhinav Kumar wrote:
> Currently the size parameter of drm_dp_vsc_sdp_pack() is always
> the size of struct dp_sdp. Hence lets drop this parameter and
> use sizeof() directly.
> 
> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Signed-off-by: Abhinav Kumar <quic_abhinavk@quicinc.com>

it looks indeed an unecessary check.
you can convert my ack to a

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and the ack to take this through drm-misc if needed

> ---
>  drivers/gpu/drm/display/drm_dp_helper.c | 8 ++------
>  drivers/gpu/drm/i915/display/intel_dp.c | 3 +--
>  include/drm/display/drm_dp_helper.h     | 3 +--
>  3 files changed, 4 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index 6c91f400ecb1..10ee82e34de7 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -2918,19 +2918,15 @@ EXPORT_SYMBOL(drm_dp_vsc_sdp_log);
>   * @vsc: vsc sdp initialized according to its purpose as defined in
>   *       table 2-118 - table 2-120 in DP 1.4a specification
>   * @sdp: valid handle to the generic dp_sdp which will be packed
> - * @size: valid size of the passed sdp handle
>   *
>   * Returns length of sdp on success and error code on failure
>   */
>  ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc,
> -			    struct dp_sdp *sdp, size_t size)
> +			    struct dp_sdp *sdp)
>  {
>  	size_t length = sizeof(struct dp_sdp);
>  
> -	if (size < length)
> -		return -ENOSPC;
> -
> -	memset(sdp, 0, size);
> +	memset(sdp, 0, sizeof(struct dp_sdp));
>  
>  	/*
>  	 * Prepare VSC Header for SU as per DP 1.4a spec, Table 2-119
> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
> index a9458df475e2..e13121dc3a03 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp.c
> @@ -4181,8 +4181,7 @@ static void intel_write_dp_sdp(struct intel_encoder *encoder,
>  
>  	switch (type) {
>  	case DP_SDP_VSC:
> -		len = drm_dp_vsc_sdp_pack(&crtc_state->infoframes.vsc, &sdp,
> -					  sizeof(sdp));
> +		len = drm_dp_vsc_sdp_pack(&crtc_state->infoframes.vsc, &sdp);
>  		break;
>  	case HDMI_PACKET_TYPE_GAMUT_METADATA:
>  		len = intel_dp_hdr_metadata_infoframe_sdp_pack(dev_priv,
> diff --git a/include/drm/display/drm_dp_helper.h b/include/drm/display/drm_dp_helper.h
> index 8474504d4c88..1f41994796d3 100644
> --- a/include/drm/display/drm_dp_helper.h
> +++ b/include/drm/display/drm_dp_helper.h
> @@ -812,7 +812,6 @@ int drm_dp_bw_overhead(int lane_count, int hactive,
>  		       int bpp_x16, unsigned long flags);
>  int drm_dp_bw_channel_coding_efficiency(bool is_uhbr);
>  
> -ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc,
> -			    struct dp_sdp *sdp, size_t size);
> +ssize_t drm_dp_vsc_sdp_pack(const struct drm_dp_vsc_sdp *vsc, struct dp_sdp *sdp);
>  
>  #endif /* _DRM_DP_HELPER_H_ */
> -- 
> 2.34.1
>