Received-SPF: pass (google.com: domain of linux-kernel+bounces-77306-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 22 Feb 2024 21:18:00 +0100
From: =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>
To: Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>, 
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, 
	Arnaud Ferraris <arnaud.ferraris@collabora.com>, Chen-Yu Tsai <wens@csie.org>, 
	Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, 
	linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 4/4] ASoC: sun8i-codec: Implement jack and accessory
 detection
Message-ID: <vmi3fkm47wf7cbfakubbye4ce7ol5kjpg3edkrati2lhsl6qej@57uir6fjjzq2>
Mail-Followup-To: =?utf-8?Q?Ond=C5=99ej?= Jirman <megi@xff.cz>, 
	Mark Brown <broonie@kernel.org>, linux-kernel@vger.kernel.org, 
	Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, 
	Arnaud Ferraris <arnaud.ferraris@collabora.com>, Chen-Yu Tsai <wens@csie.org>, 
	Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, 
	linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-sunxi@lists.linux.dev
References: <20240222181851.3398254-1-megi@xff.cz>
 <20240222181851.3398254-5-megi@xff.cz>
 <0c351386-f1df-443f-a997-261f5c60c852@sirena.org.uk>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0c351386-f1df-443f-a997-261f5c60c852@sirena.org.uk>

Hello Mark,

On Thu, Feb 22, 2024 at 06:41:13PM +0000, Mark Brown wrote:
> On Thu, Feb 22, 2024 at 07:18:47PM +0100, Ondřej Jirman wrote:
> 
> > +static struct snd_soc_jack_pin sun8i_codec_jack_pins[] = {
> > +	{
> > +		.pin	= "Headphone Jack",
> > +		.mask	= SND_JACK_HEADPHONE,
> > +	},
> > +	{
> > +		.pin	= "Headset Microphone",
> > +		.mask	= SND_JACK_MICROPHONE,
> > +	},
> > +};
> > +
> 
> The jack being a headset jack is going to be system specific isn't it?
> Some systems might have separate headphone and microphone jacks.  I'd
> not expect to see any pin handling code at all in a CODEC driver, that
> belongs in the machine driver.

Yeah, the only reason this and the card reference seems to be here is to
check whether jack detection should be enabled and in what capacity.

Looks like there's some set_jack component callback for that. :)

I'll look into that.

kind regards,
	o.

> >  static int sun8i_codec_component_probe(struct snd_soc_component *component)
> >  {
> >  	struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component);
> >  	struct sun8i_codec *scodec = snd_soc_component_get_drvdata(component);
> >  	int ret;
> >  
> > +	scodec->card = component->card;
> > +
> 
> The fact that you're needing to look at the card here should be a bit of
> a warning sign there.