Received-SPF: pass (google.com: domain of linux-kernel+bounces-77268-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240222105723.3810303-1-colin.i.king@gmail.com>
In-Reply-To: <20240222105723.3810303-1-colin.i.king@gmail.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Thu, 22 Feb 2024 20:37:44 +0100
Message-ID: <CAJZ5v0gPg4XwLNC2fEb8j9iDgCrZXQ8cFbru581467BYgX4jXw@mail.gmail.com>
Subject: Re: [PATCH][next][V2] ACPI: thermal_lib: Initialize temp_decik to zero
To: Colin Ian King <colin.i.king@gmail.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>, Zhang Rui <rui.zhang@intel.com>, Len Brown <lenb@kernel.org>, 
	linux-acpi@vger.kernel.org, kernel-janitors@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 11:57=E2=80=AFAM Colin Ian King <colin.i.king@gmail=
com> wrote:
>
> Static analysis with clang scan build is warning that uninitialized
> data is being passed into various functions. Stop these warnings by
> initializing temp_decik to zero.
>
> Cleans up clang scan warnings in lines 106, 125, 146 and 164 such as:
> drivers/acpi/thermal_lib.c:106:9: warning: 2nd function call argument
> is an uninitialized value [core.CallAndMessage]
>
> Kudos to Dan Carpenter for the deeper analysis of this issue.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
>
> V2: just set temp_decik to 0
>
> ---
>  drivers/acpi/thermal_lib.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/acpi/thermal_lib.c b/drivers/acpi/thermal_lib.c
> index 4e0519ca9739..6214d6ebe1fa 100644
> --- a/drivers/acpi/thermal_lib.c
> +++ b/drivers/acpi/thermal_lib.c
> @@ -100,7 +100,7 @@ static int thermal_temp(int error, int temp_decik, in=
t *ret_temp)
>   */
>  int thermal_acpi_active_trip_temp(struct acpi_device *adev, int id, int =
*ret_temp)
>  {
> -       int temp_decik;
> +       int temp_decik =3D 0;
>         int ret =3D acpi_active_trip_temp(adev, id, &temp_decik);
>
>         return thermal_temp(ret, temp_decik, ret_temp);
> @@ -119,7 +119,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_active_trip_temp);
>   */
>  int thermal_acpi_passive_trip_temp(struct acpi_device *adev, int *ret_te=
mp)
>  {
> -       int temp_decik;
> +       int temp_decik =3D 0;
>         int ret =3D acpi_passive_trip_temp(adev, &temp_decik);
>
>         return thermal_temp(ret, temp_decik, ret_temp);
> @@ -139,7 +139,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_passive_trip_temp);
>   */
>  int thermal_acpi_hot_trip_temp(struct acpi_device *adev, int *ret_temp)
>  {
> -       int temp_decik;
> +       int temp_decik =3D 0;
>         int ret =3D acpi_hot_trip_temp(adev, &temp_decik);
>
>         return thermal_temp(ret, temp_decik, ret_temp);
> @@ -158,7 +158,7 @@ EXPORT_SYMBOL_GPL(thermal_acpi_hot_trip_temp);
>   */
>  int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_t=
emp)
>  {
> -       int temp_decik;
> +       int temp_decik =3D 0;
>         int ret =3D acpi_critical_trip_temp(adev, &temp_decik);
>
>         return thermal_temp(ret, temp_decik, ret_temp);
> --

Applied as 6.9 material, thanks!