Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp579268rdb; Thu, 22 Feb 2024 12:34:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCX/UVziJ5lu5L4e7hiGGuYCJ+/+duk66CHwTYV2ugUC5bdQWHdYuqk/3CxJAgq4dW3JuUxy7UfvwQuBPzfsdezMPVmsXqbznMttGDGWUg== X-Google-Smtp-Source: AGHT+IGrptSvu39JdvUCQOjYS7WFz20EbOzgnGHKFW2oi6KtNNPN6l+z9lkNRu8Xte0dSPuH3fh7 X-Received: by 2002:a05:6358:7181:b0:17b:56ad:6b14 with SMTP id t1-20020a056358718100b0017b56ad6b14mr7522793rwt.2.1708634048740; Thu, 22 Feb 2024 12:34:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708634048; cv=pass; d=google.com; s=arc-20160816; b=LcCZHs7HLF2rY1G5bhNquFy80LeB1rhijcqQC7OgIXNdnmVmIXVFzaEkXVokTtLhFh LcWcTaalfsRXlXfQ1nFstf9EqRAG0RHw2DZN694mp8e5/JCI3W9c0I+ZRynmTuGbrHpM FU1zY9LoCN4ezae4w9xvKYy7y66+ukg5zNHOmOL69d9yQHBGS4DxeoF5YOzXEs1fe5to xDNcxnbVYXGFFfVCxBXTKUB5/ReZ5ZoDrJcebVnZiXWf9vnOm0POHxKMc/wwf+v2SfR9 0F7iVQ9DY0I9RC/HWs8moalrgW//wLvl93miSPTMCIoS1LDWx+R41FccC9E894otagZ5 65Nw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=hTo2vh8op0bT3tEUtwhGOi1VLFI+ijx3iYvYYb7CfwI=; fh=NRkcXcex9UZi2vekb2ngHkGcH8Ve9nW71Go2Z7/arAE=; b=uPCe+TApKkZzVfTpJKEd2kpDRP3Rxpo87tnJ2U0zJyaPnvyy80pxdVxw1jbs9J/hF9 Z3BEV5hDQzIwcox0HsYD0vOC10ZTAHENSlgNfrBrgwI8KqPUQ7ppAJ8Q9wV9OFX7eEDB nV203luoC3yxU2dIu0TATQ4gaR20QPQ87ay4EcNlrVvHpbBS8d4ZLSYP9A7MJbSezBag N3npTT1n8qaP4NCI+EUG2G14nXJuwpAvTALeahaEaGU7eB+aHapaSyCtLMKARpGoM7Z+ 7v425jh6kGZ9VLZgBUPlSwMnTWjZ5VQToc7Zm8SNvaHvaO9E/AH3K7iJisbta+/ZJF+X oURQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=PS7wXuAw; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-76843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76843-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id dq25-20020a056a020f9900b005dc82971734si10736294pgb.387.2024.02.22.12.34.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 12:34:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-76843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=PS7wXuAw; arc=pass (i=1 dkim=pass dkdomain=infradead.org); spf=pass (google.com: domain of linux-kernel+bounces-76843-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-76843-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C44C1B29CF3 for ; Thu, 22 Feb 2024 16:03:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0967B15098C; Thu, 22 Feb 2024 16:03:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="PS7wXuAw" Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDC9314F9E7; Thu, 22 Feb 2024 16:03:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708617804; cv=none; b=KZO9JwL4+YA56d613zqzJINxFGAnQMudg0NaGN1ThWB6SX4ToZBXjFX6cHaxPRBpY82sC5eNIxQTSdDBoqD890KOFo12wohUHPALldDlzn+XExaxcs5rLPZjUJN8eWJZoCgFzaLYPmgS/tTER0ijiCIFsau7obKXL8nI9B/XdtE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708617804; c=relaxed/simple; bh=/wFw9YSuI9zcQ/LNkPy0aQWduY5c3j/BYq0CnuD5GsQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=AOQzEVlzyczduGUwsi+rH6bVw8p4BtPcHHVHG5U4529hkIuPJdStEkvk0RoHXvf7oSrjuRF6sw3NxbgrLc5Eu8XuU1Tr+Z7XgCMkvmQUGKxBqDqDEN23aMaD6ISeiu6+YHjmEX5ixwOl6d91lLOWxEy+jyxhXNRME8H5HxTsdbU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org; spf=none smtp.mailfrom=infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=PS7wXuAw; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description; bh=hTo2vh8op0bT3tEUtwhGOi1VLFI+ijx3iYvYYb7CfwI=; b=PS7wXuAw8lZ8GBrFmVpTkfUOGH 6W0EWv2KQFOAZU8YkN1qlzhthap25pdsmMxha+7oQW8VHAUR/Vm9zaQC5pyl5aSxpqh0p0RJy3k7F Xr8OOUKPjXXKFqPnkiOz59lZeN59A5x82yKYHgNrOZ3SRxjk3XZOMxE+PkbCSgKi47YlfwxsdVbj3 D3zeBJx7Poy66QyzmC6JrC0CMK4sTBuok7/hvVZArSQkybxkWQoTHjY503K/r5enpDsbnz2CmZZVd AOudf+5EmYTxTIcPCEL6+A7WihJsnXjq7fWh4KQq4kVZuKLB5q78mdZK5Yp2lEjwm2CHPSKqhkxg+ vA6R/wLw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdBXc-00000005XBO-2mrq; Thu, 22 Feb 2024 16:03:20 +0000 Date: Thu, 22 Feb 2024 08:03:20 -0800 From: Luis Chamberlain To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: "Eric W. Biederman" , Kees Cook , Joel Granados , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 0/4] sysctl: move sysctl type to ctl_table_header Message-ID: References: <20240222-sysctl-empty-dir-v1-0-45ba9a6352e8@weissschuh.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240222-sysctl-empty-dir-v1-0-45ba9a6352e8@weissschuh.net> Sender: Luis Chamberlain On Thu, Feb 22, 2024 at 08:07:35AM +0100, Thomas Wei?schuh wrote: > Praparation series to enable constification of struct ctl_table further > down the line. > No functional changes are intended. > > These changes have been split out and reworked from my original > const sysctl patchset [0]. > I'm resubmitting the patchset in smaller chunks for easier review. > Each split-out series is meant to be useful on its own. > > Changes since the original series: > * Explicit initializartion of header->type in init_header() > * Some additional cleanups > > [0] https://lore.kernel.org/lkml/20231204-const-sysctl-v2-0-7a5060b11447@weissschuh.net/ This all looks super sexy to me, but I'd love Eric's feedback on patch series before merging as he may know some other facts over sysctl_mount_point I might be missing. Reviewed-by: Luis Chamberlain Luis