Received-SPF: pass (google.com: domain of linux-kernel+bounces-77421-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 22 Feb 2024 13:42:23 -0800 (PST)
From: Ilkka Koskinen <ilkka@os.amperecomputing.com>
To: Namhyung Kim <namhyung@kernel.org>, James Clark <james.clark@arm.com>
cc: Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>, 
    Arnaldo Carvalho de Melo <acme@kernel.org>, 
    Mark Rutland <mark.rutland@arm.com>, 
    Alexander Shishkin <alexander.shishkin@linux.intel.com>, 
    Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>, 
    Adrian Hunter <adrian.hunter@intel.com>, 
    Evgeny Pistun <kotborealis@awooo.ru>, 
    Ilkka Koskinen <ilkka@os.amperecomputing.com>, 
    linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] perf data convert: Fix segfault when converting to
 json on arm64
In-Reply-To: <20240117215101.77713-1-ilkka@os.amperecomputing.com>
Message-ID: <d77856e0-50e8-b7b4-734-93be3447ed73@os.amperecomputing.com>
References: <20240117215101.77713-1-ilkka@os.amperecomputing.com>
Content-Type: text/plain; format=flowed; charset=US-ASCII
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?BCocZK3dbP+sRZIZIw7BurCQYU8cacYJw8uptRjm078TbhnTtFjE/OC96Wrk?=
 =?us-ascii?Q?wPRTVtAxBssgTtolOyF3teRFqCELAGLMfzEVXHJ6lW8oyAMJ7ajQjR8878r1?=
 =?us-ascii?Q?oE1noP9pP34oAA06kRLEDA5EwcFnh4ykwx98979TF96A0F+I57Ny8tqdHoKD?=
 =?us-ascii?Q?phqq+M1PVJCR04PWXcR4bfglTxfhldaIpLg2TAD3wq1AeyGXA0XEORLTJA2K?=
 =?us-ascii?Q?vhOXf77hW9JFI9tlxxfRw5ad2feC976A78IQCXJhxjKV6jZ0qabg2rLezyOb?=
 =?us-ascii?Q?qtbvsmvulijXJT2frDuB5+yxASle3PeeBjL+Iuar6/i2FCZltxEgbRrQHfNc?=
 =?us-ascii?Q?7lZauo9jd18lF78MWsCPLsCkMmWr4fIh7XUoXk05c72TDHHHdzX3VzRq/wXv?=
 =?us-ascii?Q?iw2+mAomOIt8bYjhzightF/655grX9Y4S27RFYP5vJ2tARsWMriMZuIfg3BC?=
 =?us-ascii?Q?z5XAtr9pAVlvM9j03iFv9jo1phlRdm0kjMAyGAmYRJXU9aqIuqZhwTTQdI2W?=
 =?us-ascii?Q?nyb2ktGP7e4BvttLKm0mMUktIH5hRGxljNMbS+BjEv5IjFT5ZjtnyaejCrXu?=
 =?us-ascii?Q?iHOzmM9bJMIItcagmRDcYdd3DEbcz9d/a3wtDTFMN11Jjj94phpOhVeRX01n?=
 =?us-ascii?Q?wBYVTsB54qO2AEcyZxe+bOKXFLu2c/72csRlHQ2Ba8WCBOqTt6QYps6Le2Dm?=
 =?us-ascii?Q?SkIeEZ6JQn47IrKxSo7o25+VEeQICCe06NXGbI3qco5sJ3offKpzvAy36D0j?=
 =?us-ascii?Q?eFCY1DKHmXgaPyizDBf1dljam+NgiNxf9ziG83qjnuyPPi/Z7EkDUHtF+Kao?=
 =?us-ascii?Q?nMrue60KEOYPXDWhzwjiUJvs3lT9L51javbwFS/bvQHjKWQ0zSd4lPLMTqCL?=
 =?us-ascii?Q?wgOyxwJi54F3FDLTo+a3FOw5+daGyZ+Ke+1nj3IUGuXwKfWNpr+aYDgfzOUU?=
 =?us-ascii?Q?WtJrB4rV0p6BmCo8ABsLNazIzV0Hgsp85Tr8m6znjnyhbQqqOMEZG3Z+PA9L?=
 =?us-ascii?Q?AhWTh+TKqM740X/ReJJAbXqIKqdLPFA1q6boLdLNFT+7WiYaxca0KGI+nsx7?=
 =?us-ascii?Q?PMwdsqgUW909npUZccDXWJeJ8ddQ1XSHDc3Rsur7NTvSCSc0r+G0t5CpAIL7?=
 =?us-ascii?Q?fQBFKk4DerA0efAa353Im8bXhHS4HU1mwsUsZ0IXi/o+uytfYJRV6mBzoCwV?=
 =?us-ascii?Q?JyZsYD1RWfDCjqZik4hxreHvnqGnXlpOGAqEcMpSAoUogGud/KoVxvbrmyIf?=
 =?us-ascii?Q?DkQiku+phfh0PByRyhUtHoAgxHaOfAO0zR5Z/OYXgI1Q9HRMWlk5PmhMZN6+?=
 =?us-ascii?Q?6Im19SPmUuoSiBFZy9ueS7Gp/5qrW1bRDrPd4XXiUthFCvHNjiHIftF0lkux?=
 =?us-ascii?Q?rwTLd85YyMHYXVSsAqnbS4eA7LZ1X4GIEKNzoldro/TBQAmEoPfytndIxzNZ?=
 =?us-ascii?Q?GquB1uZnPE1zWvLdgdgrY1mM3t1ho5HJkHPrzXTJFy9NZ7sV2BKgiP2P8oUR?=
 =?us-ascii?Q?qXmpkV74+jg+jkf/d89DMSgELyI6aRVfMErc+YeqRn3/2pBFKr29AHIAB1kv?=
 =?us-ascii?Q?I2eqaOqkudOrRGaVdkUSxs/JDFz6bR4Qy1nx+/E4pp/K5NzkY5mdPaU9Vlxf?=
 =?us-ascii?Q?unopWs1jgOKVqXU8XEb8MH8=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7cbe5187-8b78-43b9-1e40-08dc33ef2f17
X-MS-Exchange-CrossTenant-AuthSource: SJ2PR01MB8257.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 21:42:36.1585
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FfGIh8UV9xGCGvy4HNdbTta2QN9cy86oU9AjKp2M8DK7BJsImDvyJn31JC2ngVzmAJbGpkkIA7xXPh+YHdcRPA9VUxq0XfWb/RZYCwjYE+XunvDVnBhaAQ2j+5gdEYRD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB6174


cc: Evgeny Pistun since he submitted a patch pretty similar to my first 
version
(https://lore.kernel.org/all/20240125184411.30757-1-kotborealis@awooo.ru/)


Namhyung and James,

What's your thought on this? Is one of the patches (Evgeny's or mine) 
good enough or should we try some other approach?

Cheers, Ilkka


On Wed, 17 Jan 2024, Ilkka Koskinen wrote:
> Arm64 doesn't have Model in /proc/cpuinfo and, thus, cpu_desc doesn't get
> assigned.
>
> Running
> 	$ perf data convert --to-json perf.data.json
>
> ends up calling output_json_string() with NULL pointer, which causes a
> segmentation fault.
>
> Signed-off-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
> ---
> v1:
>    - https://lore.kernel.org/all/20240111232923.8138-1-ilkka@os.amperecomputing.com/
> v2:
>    - Changed the patch based on James's comments.
> v3:
>    - The architecture is checked from the actual data file to allow one to do
>      conversion on another system. (thanks to James for the feedback)
> ---
> tools/perf/util/data-convert-json.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/data-convert-json.c b/tools/perf/util/data-convert-json.c
> index 5bb3c2ba95ca..405c38371870 100644
> --- a/tools/perf/util/data-convert-json.c
> +++ b/tools/perf/util/data-convert-json.c
> @@ -284,7 +284,13 @@ static void output_headers(struct perf_session *session, struct convert_json *c)
> 	output_json_key_string(out, true, 2, "os-release", header->env.os_release);
> 	output_json_key_string(out, true, 2, "arch", header->env.arch);
>
> -	output_json_key_string(out, true, 2, "cpu-desc", header->env.cpu_desc);
> +	/*
> +	 * Arm64 doesn't have Model section in /proc/cpuinfo and, thus, cpu-desc
> +	 * is not set.
> +	 */
> +	if (strncmp(header->env.arch, "aarch64", 7))
> +		output_json_key_string(out, true, 2, "cpu-desc", header->env.cpu_desc);
> +
> 	output_json_key_string(out, true, 2, "cpuid", header->env.cpuid);
> 	output_json_key_format(out, true, 2, "nrcpus-online", "%u", header->env.nr_cpus_online);
> 	output_json_key_format(out, true, 2, "nrcpus-avail", "%u", header->env.nr_cpus_avail);
> -- 
> 2.43.0
>
>