Received-SPF: pass (google.com: domain of linux-kernel+bounces-77438-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 22 Feb 2024 14:03:13 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>, Dan Williams
	<dan.j.williams@intel.com>
CC: <gregkh@linuxfoundation.org>, Pierre-Louis Bossart
	<pierre-louis.bossart@linux.intel.com>, Marc Herbert
	<marc.herbert@intel.com>, "Rafael J. Wysocki" <rafael@kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<linux-coco@lists.linux.dev>, <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 1/3] sysfs: Fix crash on empty group attributes array
Message-ID: <65d7c4a17f351_ca001294e8@dwillia2-xfh.jf.intel.com.notmuch>
References: <170863444851.1479840.10249410842428140526.stgit@dwillia2-xfh.jf.intel.com>
 <170863445442.1479840.1818801787239831650.stgit@dwillia2-xfh.jf.intel.com>
 <CAJZ5v0hmD+7iSKKexpUccvMUtjNpd9fHo3vRrshD_s=rb5Vq_w@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAJZ5v0hmD+7iSKKexpUccvMUtjNpd9fHo3vRrshD_s=rb5Vq_w@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlZXNkhxVXVLdUlqUThNNmJKYTRCdGtwcExHSDJ0bVcxOGNRQkg4NkVvVkZX?=
 =?utf-8?B?Rk9ZN0w4ek5xZ0xHTlkwSFo2ckFneDJBZ3dyc29VRVRLMVdyZThQNERDODhK?=
 =?utf-8?B?NFd6SjVVQm9KNERzbDhmb3YvMFhJeC9ZcTFaUThtaTRpaUUxellzdkFCYnBD?=
 =?utf-8?B?alB4RjBuTHkxNG9MaEEraFVrcDBlWllQbU9BVDZBWXF3TEROUDE5Wm5SNjln?=
 =?utf-8?B?bi83Z25qNFk3NzhOZDdOSVh5RTJENDM1aVNCYjc3WVVSbWhBazkveUhRNWtU?=
 =?utf-8?B?M2JKK1k2WDVtWXZHOG5rZkdvQjJtc2pKYkNtS3lWcUpvWkxSVzJKVmwzZXZ0?=
 =?utf-8?B?NktLdEpVUmE5dnpoWWhMLy9kL0JhRUZ6N0ZPZENhV1BFVWozc0lJaUdTVjZu?=
 =?utf-8?B?Y2tIQ0RnU3ZaeDB2eWxZd0tYb3ZGWHZLNUxvU2J5emQrYXBoeWFveEFLV0F0?=
 =?utf-8?B?clpPdllWUVpPb1J5MTlLZW5SU0JkbDB6dFpzS2YwRjg0YUJvWUwvWElpNWlh?=
 =?utf-8?B?Q3N3d2IrT1ZFOUtjMUd0MFE0bWdVeVRLOWczWEFVQ3E2MmNxRlhDY2t6aU1D?=
 =?utf-8?B?Zkl4U0cxY0tpYUZWVDRVUUlPMFFNOGtYeW1CaTVlblZmMTNpT21JR3RRSjRm?=
 =?utf-8?B?Yml3MTJrb3pVamtxUDVGQi93WTk4K1F1RHVhTnRyK1FMNUlDQndTamtKNmNV?=
 =?utf-8?B?NGVPTXhFUHcrKzRHYXVNNG1Od3YyUGlSNVFWdkhHYlh5UXRFWitndDJ4cHdu?=
 =?utf-8?B?bXJpekVPaE9tUmMycGR5SmdJSWd1Wjg5TSszdnhXbmRvZkhSRzVkZVBpYmsx?=
 =?utf-8?B?QkJGb2JsajMxdzEyK1VwdnkwOHVSVTdjSGVPOWlXNStyNFBNWUpwdTIrRmZU?=
 =?utf-8?B?SmdyRmdLYk5sbE0yRlN4UzdGTE1JNytqQ0pJTERLVjBLNWZBc1lFd0ZwZXpE?=
 =?utf-8?B?SWh0Ylg1VEh0Y2RsOWRwTTRuc05FNHlnVE9VMFkvNXlzUHVockJCcmwwMHVh?=
 =?utf-8?B?Z1B1UjluZDN1TUlOTmVXakJEVVB5V3ZQRU42OEpBMmRxWVFibGkwY3luOG5a?=
 =?utf-8?B?YzV5UmMyb3FsV3VVVnNkKy91Tkx5dytmczhhZ2lhQ0I3RmFKSXpld0dmY2w0?=
 =?utf-8?B?WmJLM2lyNXlhVEM5QlNTMjh0U2ZYaHViekQ4MFVVSHBLS2VzT0c0UHNIdkxl?=
 =?utf-8?B?N2JlLzZCSmMxcnFZNjBVaHUwa3JvVUFIUlRPY2tQUldvdzM1cE11WmdBU1Bs?=
 =?utf-8?B?YWZvWFlBVUkvcVB3elYrc21INkR4Q1JHa05ZaDFrRlVJd2xTRG1ST0pybnQz?=
 =?utf-8?B?QWtzTTJrYXFpWVNPck5kZ2FoTzJvZndNbEJ1OGZvZWc1K2lyWFZHalNxOExX?=
 =?utf-8?B?NWNqTHNPZThYSlFrWHFZcWNzYmFRY0EyOHM4M3ZtYld6ckl1cmRGa0VOeVBx?=
 =?utf-8?B?NVF5TmR6VTMxby8vTzRzM2pkK3B5SnI4WHdYb1ZNQWk3TkZaRitGMkEyZTNV?=
 =?utf-8?B?QWtpcXpUUDhaRFg1SW1OUWZoTTZXcGxWS3pYQkVCdDFhNDhzUFNOaERaOWtM?=
 =?utf-8?B?Q2tCajdjNkNCNFRBbGpjc2cyWHBMVlBwK01SdkZacDhxMWJVTDRkME5JRFEx?=
 =?utf-8?B?R0htbEoxR3kwNGtZVlhFWTBBbVBlVU9yOTBzb0pCaDJvY2tPOGJUdWE1bFJv?=
 =?utf-8?B?MUJZd2xlbmhhSk9ma2pndW14L293Qld2YmxGWEZYTkx4QVJrbXVCb1pxdW9q?=
 =?utf-8?B?a2NFSEwyTHV2K2k5VEEwM3dWaDdyZkNQV25ZZW1wMU9vUW0wVEJWTW96Ym11?=
 =?utf-8?B?S24zMWJLcU10b0pXdUxLcldXQU1tTkMxOWlTOXEycE9VTldmL1NtdFlVaXFQ?=
 =?utf-8?B?N0gzcS90eFJIaHF6b25QcTU4OFZEcDFKanBBTDA2TExRbFp5MGxGMkVGTTVU?=
 =?utf-8?B?bHFrVEkyRDlLZGFzTzRLbW90a2xIS1dnTE8wSVl3TElPamg4YTZieHp6MVNY?=
 =?utf-8?B?a0lLNmhHVEdKS3lQU3NwRUhaVy93TldZUTJ6T3dnUXAyMzNKMWhrejZ4UUlV?=
 =?utf-8?B?Yk1CMlhRdGdwYmhKczQzSkVIMTJsWkdYSDMvSEZ2UE1TQmJyc08yTW5pUWcv?=
 =?utf-8?B?WkU2akltNTFRK1Q1V24zQVdnVVc5MG0vN3cxVnFBcmg2aEt6QnhtRFcyY3Bx?=
 =?utf-8?B?eUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 7d958e02-b7a6-4f92-8bb7-08dc33f211f5
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 22:03:15.7677
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nitWXAvOupNbvTPBZ4fLBzCMMgYnfFfCugYrlBe3XmL5JYtib5rxLw4lt4kAIFbRTVVa6KX7Cp81vu5YMcKcrhyEi6gMEs/m3emn0/jDKgQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4807
X-OriginatorOrg: intel.com

Rafael J. Wysocki wrote:
> On Thu, Feb 22, 2024 at 9:40 PM Dan Williams <dan.j.williams@intel.com> wrote:
> >
> > It turns out that arch/x86/events/intel/core.c makes use of "empty"
> > attributes.
> >
> >         static struct attribute *empty_attrs;
> >
> >         __init int intel_pmu_init(void)
> >         {
> >                 struct attribute **extra_skl_attr = &empty_attrs;
> >                 struct attribute **extra_attr = &empty_attrs;
> >                 struct attribute **td_attr    = &empty_attrs;
> >                 struct attribute **mem_attr   = &empty_attrs;
> >                 struct attribute **tsx_attr   = &empty_attrs;
> >                 ...
> >
> > That breaks the assumption __first_visible() that expects that if
> > grp->attrs is set then grp->attrs[0] must also be set and results in
> > backtraces like:
> >
> >     BUG: kernel NULL pointer dereference, address: 00rnel mode
> >     #PF: error_code(0x0000) - not-present ] PREEMPT SMP NOPTI
> >     CPU: 1 PID: 1 Comm: swapper/IP: 0010:exra_is_visible+0x14/0x20
> >      ? exc_page_fault+0x68/0x190
> >      internal_create_groups+0x42/0xa0
> >      pmu_dev_alloc+0xc0/0xe0
> >      perf_event_sysfs_init+0x580000000000 ]---
> >     RIP: 0010:exra_is_visible+0x14/0
> >
> > Check for non-empty attributes array before calling is_visible().
> >
> > Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> > Closes: https://github.com/thesofproject/linux/pull/4799#issuecomment-1958537212
> > Fixes: 70317fd24b41 ("sysfs: Introduce a mechanism to hide static attribute_groups")
> 
> This is not in the mainline, so linux-next I suppose?

..or at least it will be shortly. Greg notified that it is currently in
driver-core-next:

https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git/commit/?h=driver-core-next&id=70317fd24b41