Received-SPF: pass (google.com: domain of linux-kernel+bounces-77462-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 22 Feb 2024 23:24:57 +0100
From: Andi Shyti <andi.shyti@kernel.org>
To: Patrick =?utf-8?B?SMO2aG4=?= <hoehnp@gmx.de>
Cc: Jean Delvare <jdelvare@suse.com>, 
	Pali =?utf-8?B?Um9ow6Fy?= <pali@kernel.org>, Paul Menzel <pmenzel@molgen.mpg.de>, linux-i2c@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: i801: Add lis3lv02d for Dell Precision M6800 v2
 Bios: A26
Message-ID: <3s546clapu73llqqyhj7fhab5cwhchygrtq53juqcqoyttk2dx@47ylvwpqso5d>
References: <20240222215010.31456-1-hoehnp@gmx.de>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20240222215010.31456-1-hoehnp@gmx.de>

Hi Patrick,

On Thu, Feb 22, 2024 at 10:50:08PM +0100, Patrick H?hn wrote:
> Signed-off-by: Patrick H?hn <hoehnp@gmx.de>

I see that you've fixed almost everything that Paul has
suggested, but please elaborate a bit more in the git commit.

Spend some time adding a description. If you want, you can reply
to this email with the commit log you have in mind, and I can add
it for you, or you can send a v3.

Thank you, Paul, for your excellent review.

Andi

PS: A small nitpick: there's no need to add 'v2' in the title.
    '[PATCH v2]' is sufficient.

> ---
>  drivers/i2c/busses/i2c-i801.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/i2c-i801.c b/drivers/i2c/busses/i2c-i801.c
> index 2c36b36d7d51..c1fee2c61da1 100644
> --- a/drivers/i2c/busses/i2c-i801.c
> +++ b/drivers/i2c/busses/i2c-i801.c
> @@ -1231,6 +1231,7 @@ static const struct {
>  	 */
>  	{ "Latitude 5480",      0x29 },
>  	{ "Precision 3540",     0x29 },
> +	{ "Precision M6800",    0x29 },
>  	{ "Vostro V131",        0x1d },
>  	{ "Vostro 5568",        0x29 },
>  	{ "XPS 15 7590",        0x29 },
> --
> 2.43.0
>