Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753114AbXLaT2s (ORCPT ); Mon, 31 Dec 2007 14:28:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751387AbXLaT2i (ORCPT ); Mon, 31 Dec 2007 14:28:38 -0500 Received: from pentafluge.infradead.org ([213.146.154.40]:41297 "EHLO pentafluge.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751196AbXLaT2g (ORCPT ); Mon, 31 Dec 2007 14:28:36 -0500 Date: Mon, 31 Dec 2007 11:26:43 -0800 From: Greg KH To: Alan Stern Cc: Andreas Mohr , Ingo Molnar , Alexey Dobriyan , Andrew Morton , David Woodhouse , "Eric W. Biederman" , Linus Torvalds , "Rafael J. Wysocki" , Pavel Machek , kernel list , netdev , Pavel Emelyanov , "Denis V. Lunev" , USB list Subject: Re: [usb regression] Re: [PATCH 2.6.24-rc3] Fix /proc/net breakage Message-ID: <20071231192643.GA25341@kroah.com> References: <20071231052500.GB4187@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1396 Lines: 36 On Mon, Dec 31, 2007 at 12:49:52PM -0500, Alan Stern wrote: > On Sun, 30 Dec 2007, Greg KH wrote: > > > > It looks like Greg misused the debugfs API -- which is ironic, because > > > he wrote debugfs in the first place! :-) > > > > Oh crap, sorry, I did mess that up :( > > > > > Let me know if this patch fixes the problem. If it does, I'll submit > > > it to Greg with all the proper accoutrements. > > > > This isn't going to work if CONFIG_DEBUGFS is not enabled either :( > > Why not? The debugging files won't be created, true, but the driver > should work just fine regardless. This is exactly the way uhci-hcd > behaves, and it hasn't caused any problems. Ok, you are right, it was late and after some wine and I shouldn't have been responding to email :) I'll rework this, and send out a patch tonight or tomorrow when I get a chance (am on the road right now). We should only care about NULL being returned here, that's the only "real" error. And in thinking about it some more, I should go audit all the debugfs callers to make sure they are doing something sane too, it shouldn't be this complex at all... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/