Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753241AbXLaTnb (ORCPT ); Mon, 31 Dec 2007 14:43:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751809AbXLaTnX (ORCPT ); Mon, 31 Dec 2007 14:43:23 -0500 Received: from rgminet01.oracle.com ([148.87.113.118]:62300 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbXLaTnW (ORCPT ); Mon, 31 Dec 2007 14:43:22 -0500 Date: Mon, 31 Dec 2007 11:41:46 -0800 From: Mark Fasheh To: Christoph Hellwig Cc: Marcin Slusarz , ocfs2-devel@oss.oracle.com, LKML , kernel-janitors Subject: Re: [RFC][PATCH] byteorder: introduce le32_add_cpu & friends to core Message-ID: <20071231194146.GT13821@ca-server1.us.oracle.com> Reply-To: Mark Fasheh References: <20071230190619.GA13757@joi> <20071230191825.GA6447@infradead.org> <20071230214857.GA14177@joi> <20071231091732.GA29043@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071231091732.GA29043@infradead.org> Organization: Oracle Corporation User-Agent: Mutt/1.5.16 (2007-06-11) X-Brightmail-Tracker: AAAAAQAAAAI= X-Brightmail-Tracker: AAAAAQAAAAI= X-Whitelist: TRUE X-Whitelist: TRUE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 828 Lines: 22 On Mon, Dec 31, 2007 at 09:17:32AM +0000, Christoph Hellwig wrote: > > be32_add is shorter than be32_add_cpu but I think it's not clear > > whether second parameter is in native byte order or not. > > Then again adding foreing endian values doesn't make much sense. > > If you insist on your naming please make sure to convert ocfs and xfs > to your naming. Personally, I'd rather stick with the (IMHO) more descriptive name - btw, the ones he picked don't require any extra conversion in Ocfs2. --Mark -- Mark Fasheh Principal Software Developer, Oracle mark.fasheh@oracle.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/