Received-SPF: pass (google.com: domain of linux-kernel+bounces-77593-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240222051539.3001988-3-saravanak@google.com>
 <20240222051539.3001988-4-saravanak@google.com> <ffec7c7b8eb86f573e420e0582075ba1e75d0e54.camel@perches.com>
In-Reply-To: <ffec7c7b8eb86f573e420e0582075ba1e75d0e54.camel@perches.com>
From: Saravana Kannan <saravanak@google.com>
Date: Thu, 22 Feb 2024 16:45:36 -0800
Message-ID: <CAGETcx-mNt+_ST0opQ=_M1ZJK1acf8Rr0VqaAUskyig5YwL_dw@mail.gmail.com>
Subject: Re: [PATCH 2/2] checkpatch: Don't check for unified diff format in
 git sendemail headers
To: Joe Perches <joe@perches.com>
Cc: Andy Whitcroft <apw@canonical.com>, Dwaipayan Ray <dwaipayanray1@gmail.com>, 
	Lukas Bulwahn <lukas.bulwahn@gmail.com>, kernel-team@android.com, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 12:54=E2=80=AFAM Joe Perches <joe@perches.com> wrot=
e:
>
> On Wed, 2024-02-21 at 21:15 -0800, Saravana Kannan wrote:
> > When checkpatch is used as a git sendemail-validate hook, it's also pas=
sed
> > in the email header for sanity check.
>
> Why?
>
> If so, why not use a front-end script to stop/remove
> the file from being scanned by checkpatch?

Sure, I could do that. But this also makes it easier for people to
start using checkpatch. Or I can put up a git hook wrapper script in
here for people to symlink into their .git/hooks that does this.

I'd prefer the lazy route of not creating a 1 line wrapper script :)

-Saravana

>
> > These headers are, as expected, not
> > in unified diff format. So, don't complain about unified diff format fo=
r
> > these header files.
>