Received-SPF: pass (google.com: domain of linux-kernel+bounces-77615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <e51c5e6fe02bcc5a487cae063fe8f440013d0ca9.camel@perches.com>
Subject: Re: [PATCH 2/2] checkpatch: Don't check for unified diff format in
 git sendemail headers
From: Joe Perches <joe@perches.com>
To: Saravana Kannan <saravanak@google.com>
Cc: Andy Whitcroft <apw@canonical.com>, Dwaipayan Ray
 <dwaipayanray1@gmail.com>,  Lukas Bulwahn <lukas.bulwahn@gmail.com>,
 kernel-team@android.com, linux-kernel@vger.kernel.org
Date: Thu, 22 Feb 2024 17:01:53 -0800
In-Reply-To: <CAGETcx-mNt+_ST0opQ=_M1ZJK1acf8Rr0VqaAUskyig5YwL_dw@mail.gmail.com>
References: <20240222051539.3001988-3-saravanak@google.com>
	 <20240222051539.3001988-4-saravanak@google.com>
	 <ffec7c7b8eb86f573e420e0582075ba1e75d0e54.camel@perches.com>
	 <CAGETcx-mNt+_ST0opQ=_M1ZJK1acf8Rr0VqaAUskyig5YwL_dw@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
Precedence: bulk
MIME-Version: 1.0

On Thu, 2024-02-22 at 16:45 -0800, Saravana Kannan wrote:
> On Thu, Feb 22, 2024 at 12:54=E2=80=AFAM Joe Perches <joe@perches.com> wr=
ote:
> >=20
> > On Wed, 2024-02-21 at 21:15 -0800, Saravana Kannan wrote:
> > > When checkpatch is used as a git sendemail-validate hook, it's also p=
assed
> > > in the email header for sanity check.
> >=20
> > Why?
> >=20
> > If so, why not use a front-end script to stop/remove
> > the file from being scanned by checkpatch?
>=20
> Sure, I could do that. But this also makes it easier for people to
> start using checkpatch. Or I can put up a git hook wrapper script in
> here for people to symlink into their .git/hooks that does this.
>=20
> I'd prefer the lazy route of not creating a 1 line wrapper script :)

I'd not.  checkpatch is for _patches_.
Don't feed stuff to it that isn't patches and expect good results.