Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp699616rdb; Thu, 22 Feb 2024 17:43:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXc3L5qPBCvpF4DBAiGyy2PjABazH7mkN5mXx1zxadtPEPxEb8IiP+OL7ESl58bnq/vBbLRrw0y3JqGR9Dx7iX2NyqP4+n6tf+F8omZiQ== X-Google-Smtp-Source: AGHT+IFwuV2cDFQ3ec0T5iXrbDRAtS1nnf//oY5T8Rr6ebIMaoyyezBWRmn1mLdGYF5NmGqN5J55 X-Received: by 2002:a05:6a21:3403:b0:1a0:dd75:f303 with SMTP id yn3-20020a056a21340300b001a0dd75f303mr660879pzb.13.1708652632954; Thu, 22 Feb 2024 17:43:52 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708652632; cv=pass; d=google.com; s=arc-20160816; b=KeA525OIzrynlXA3uwYKJpmg1kBt3g/jMVJiv4Dh10yHvtGJ+ZMwitfZaUFCg1ZEFT 3+fTfnIb7RMLWKIcttjkkXt0xHtuBOcQ9ahzIw+eK7pzcTHEbVmZZsZJSpxhk6pOWuy8 ED+coZPfy37CuYT0t3Kqtd0p4R/2gNGK5wBwfeYNFi3AYxEIg32zaSvg59QVVY4Lnc4g /PwtreTkrOIUgNFGTMzQzEfXm+z9mkf2COLGr9RPiRmeQo8/aBBH4RpdFOzmFIBOQ3O2 vcGgSt8SGNDAFUBgkoHm0CfgyGABQJimHkcEGtWxz3+K3pxu7wQNQZgBkzzOkHyReOph ISvA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:list-unsubscribe:list-subscribe :list-id:precedence:dkim-signature; bh=Q68JTkmTvaca/7XKfrcLjsI6zB7P1f/ULoMPv/7Ii5w=; fh=T27noiawqT1ojKCvjdoxt1QP+UiKqzQVsEZB2Z0CYrI=; b=w0SK+ThLENM8eWjuXa6nrnLdi8gyipvGb96wHmvn0uZmP7rxMcmCCA12Fk1BOwxluu 9ly8/Rqzkh4tKAwNfadn2QqbyN0aO4GFGTe5boPhvHyWol/06IhV1SQluvy+x/hJ27RF 7giZOB4FSCIekHM26SeVEw5iozPIhcLJ8sedIRbUKbJOH6R9KwhlfaXfIPcRHCtIGB2r z0KTNvjOFPliYA5bpEQiaMncIi59tARdpL5Y4wHaZcydkLgtmvikP+eJ9mQAdgOik/nr f7uOnqyFTy/9jXOTCjjl4uOL3eLkJaw9WgLUm/VkJ4micizppwKl2n8IZLLa20jSQgOp Q4OA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=U5ELMvfu; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77646-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77646-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id q7-20020a170902a3c700b001db730d3f1bsi11079559plb.610.2024.02.22.17.43.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 17:43:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77646-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=U5ELMvfu; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77646-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77646-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id A390B285CC9 for ; Fri, 23 Feb 2024 01:43:52 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A72A8B66C; Fri, 23 Feb 2024 01:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="U5ELMvfu" Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 69352AD4B for ; Fri, 23 Feb 2024 01:43:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708652624; cv=none; b=JV0O6I8Qt6bvWijxD1eOEasRb+RNL55YjXIXxcTPcJjqZ7JrLZQdFtT2uxNZWsEouSImBw1tEjIwOGseM9XNvMG79mL441TzZuZT9WZte1Wa4skxOQhVnhxSQtcKzKGZ3KsnZdTnqdugkrECg/x2SZDBsUhv3c5rNa0qKgppoCU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708652624; c=relaxed/simple; bh=Q68JTkmTvaca/7XKfrcLjsI6zB7P1f/ULoMPv/7Ii5w=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=B5fXSpG0gWLcRrA0/H55a0n8x5D/QmmdskWw4MUEJSncOZ5JxR3i0v6zJfoAcxxUX1mtrsYhfCGjzm44qQu29kMJJ9UchwQ4KBdm0IrBJjsOHb9UWKI17Fbs6Yp9oyOS1xdtgs/aLU7zjk8Z+aA/qx/O2XB/GGYEkaygWD35RhU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=U5ELMvfu; arc=none smtp.client-ip=209.85.222.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-qk1-f181.google.com with SMTP id af79cd13be357-787ad0290adso14527885a.2 for ; Thu, 22 Feb 2024 17:43:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708652622; x=1709257422; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Q68JTkmTvaca/7XKfrcLjsI6zB7P1f/ULoMPv/7Ii5w=; b=U5ELMvfumvWRZxc/bD8Twdo0zXNP3rsWj1d+412tg8j3RX+yq33iZuepVo3BoPUWgo Ma7Y/s4eA7a6jmOUQ18rqRMAxyBL6ZTZ6M8xniCDXm4E/D2/dLrhfyBZIs9Yn+2/Vkz5 h34XJMer6kALIED5dF7tW7/b5BRm9qGSitzxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708652622; x=1709257422; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q68JTkmTvaca/7XKfrcLjsI6zB7P1f/ULoMPv/7Ii5w=; b=Uck2BT1sAkUPsOLcnT79dpkdFABsajWhscbKNQktdACH5tl0Tx67Oly4ndHAfQDoNr R2Ro7yka/26BqUfizFcElIpmtC3I2r5nZTBcpmhPed5htqb6w9B1qf6XE7/xn+LtqJiN Ksc3IwBG8MYSoxF6T/vgkyuF95wFefKzTGtbx7l+zahEcZElOjYynLBh7ksYk3ettPBV zyKSRLsDOGFPI8gEGIkES8iu+mbIF317WGmEJoXkvuZeybPEwV0Oi+ObtxYFqP05jB/u TYRxtNKqNod5dYugjkRjner7dJn9hk46oCXKQWzOwXEDHkiZrbq6UV29rVQL0k7deV3b uftw== X-Forwarded-Encrypted: i=1; AJvYcCVbXnlqTq0rH8N4dpJhOv+5XhXIJ0poxU9aEWE5mMkcrB0Cv9lUEGrNptbKuqJtOqrzwLUYljUSgb7Uzoo8SsROJQb2kcKEShRHnZhf X-Gm-Message-State: AOJu0Yz7uvmtQUG077rbUZx2efNUgu40QOySn5+MXvy6DvlpxIjIpbQf v34Ivvya19q8zAaWkADenEwNK2veNw3Ie4YoHFMMdY/mr3kPwG74QnCL5QstfvuFF4NfyqMcb96 YZBbbbKyY3Loyp4cpzgGfNMb5JYpMqjT+Wk/g X-Received: by 2002:a0c:d988:0:b0:68f:6a2e:cfc5 with SMTP id y8-20020a0cd988000000b0068f6a2ecfc5mr872706qvj.5.1708652622374; Thu, 22 Feb 2024 17:43:42 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240223010328.2826774-1-jthies@google.com> <20240223010328.2826774-2-jthies@google.com> In-Reply-To: <20240223010328.2826774-2-jthies@google.com> From: Prashant Malani Date: Thu, 22 Feb 2024 17:43:30 -0800 Message-ID: Subject: Re: [PATCH 1/4] usb: typec: ucsi: Clean up UCSI_CABLE_PROP macros To: Jameson Thies Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org, bleung@google.com, abhishekpandit@chromium.org, andersson@kernel.org, dmitry.baryshkov@linaro.org, fabrice.gasnier@foss.st.com, gregkh@linuxfoundation.org, hdegoede@redhat.com, neil.armstrong@linaro.org, rajaram.regupathy@intel.com, saranya.gopal@intel.com, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 22, 2024 at 5:04=E2=80=AFPM Jameson Thies w= rote: > > Clean up UCSI_CABLE_PROP macros by fixing a bitmask shifting error for > plug type and updating the modal support macro for consistent naming. > > Fixes: 3cf657f07918 ("usb: typec: ucsi: Remove all bit-fields") > Signed-off-by: Jameson Thies I think you should CC stable@ for this patch. That apart: Reviewed-by: Prashant Malani