Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp709497rdb; Thu, 22 Feb 2024 18:11:50 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVcHaMbsfVbEr88FglOZxIHRKvW44TiAyK3+Rjp8O5dAC6UZnlkUtW/klaFip4+MR1uQxT6Xh/hWl9GGiMMV/xtU/55+f2lNonl2uBd+w== X-Google-Smtp-Source: AGHT+IGPWLw2Nfu2DuecMXE6iIB5DTACIDrjQrgp30ofqUFrt0ZLpZchmvmSooGxnp/4epe2SnHK X-Received: by 2002:a05:6a20:9591:b0:19e:4ab2:c362 with SMTP id iu17-20020a056a20959100b0019e4ab2c362mr988538pzb.14.1708654310538; Thu, 22 Feb 2024 18:11:50 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708654310; cv=pass; d=google.com; s=arc-20160816; b=bo2r8/01W7tG0BregEWqGKGbK0fLF1biRgTx6GwUsHtGwkyYbSgCqmKsc5b7ltZDuN Qu4yt3Tj+i0slNdWlZ/RBNvtGaaVK1H81JP8auDLC+XIJX6qN13H8rAcRVQbcpVXWzuG CpDesMpQKBE5Md59Vd9vFZknzwckbOXB/vLIMuJcC2YkGt42Z1U+tGihahiTTyffYh+N XPi0gnW8qJkFB+xXox/m/cxLlrAHS+C+cZgSc+v2DWzp6oR10hN/4Bb7dyqplXn7kGvg ewpRAVkq9nkN2BbrzxQgPtjFfQSsjZG5qYMWq7Hsm8yEQwm0Vbgy8CPzJKUtgchkw1hG IM5Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:content-language:cc:to :subject:from:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id; bh=/Z3XjqVVOyGacphdVpey/OXP6HNxoJOGVcu6zUmHegM=; fh=gjvq/yTrowiwwimJVQjZo+XAZ9Ke73nP7Oelgtg+Yqk=; b=tye/VN3r9oLm80xxrSVLegFWV2YHKAQ8Tm57FbEzZ71KFYMATJ8oTVNM5MI+zxclZO dC/8C3XInCOecg+MWZHwGHhfnMXQS85gfajFtrC0qvGlh50A0xKXrxp81ob6HRAod6U0 sW5ySnA5aDxh8JRdSSCcxUf+rRFaSQzRUZMJSowsLjEvmyXY+d8YD2RZjJ4qFhNzH3Y4 WjobCuTWAQIwOthRzy5GwUxOtGd8pa08yghiuppqq1e/y14D6CFYmqjmwkO3pItSpJD3 7qDPjqkHESatVgD82D2W2TKWvoYpekYdSR5crvld3B+5ZshTK14EkETQPbOrom4nd8L+ KgQg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-kernel+bounces-77673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77673-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id v14-20020a056a00148e00b006e4c3a6c61dsi3297544pfu.13.2024.02.22.18.11.49 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 18:11:50 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=nfschina.com); spf=pass (google.com: domain of linux-kernel+bounces-77673-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77673-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 57EC2B22A96 for ; Fri, 23 Feb 2024 02:11:44 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 692A7BE5B; Fri, 23 Feb 2024 02:11:32 +0000 (UTC) Received: from mail.nfschina.com (unknown [42.101.60.195]) by smtp.subspace.kernel.org (Postfix) with SMTP id 4849B8F47; Fri, 23 Feb 2024 02:11:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=42.101.60.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708654291; cv=none; b=gOtuWRQDwNui0zkhrpJE0bauhhq+aWxYsgf3CHQ4zrTzdX/hPtIfS76LHFGpeL/mojd65hyFB9hkUIdeLqUNontEjuccWP+O7RLVLqv8SsEFLIUDXUZxyDB+Ce0qbAIEKja4FWXI4L28+V3x4zLYMcqmXrAcAHLDh8Yo6jzAXQ4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708654291; c=relaxed/simple; bh=M5LmF6kFoflz9uJySQG+mTHmhwdacuusQ0dma6Sds6M=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:In-Reply-To: Content-Type; b=caxT0JKPy+ErV2oNpK9lar/tAl2TVjWPsdp2yoazjp6Wge+e6R3kxBGUGQcXW+1ipjVTTY3HDIgRGy3SZv8g6rOFdmWgxGBn3tgU/ZqDO4u9jH1b96R8V5Rrr/fj4iQ7i7alPupXyuVGhdpiUUMDaJZu6uvKo7SLa7ukqLSUey0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com; spf=pass smtp.mailfrom=nfschina.com; arc=none smtp.client-ip=42.101.60.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=nfschina.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nfschina.com Received: from [172.30.11.106] (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPSA id 3EBC86046F80C; Fri, 23 Feb 2024 10:11:04 +0800 (CST) Message-ID: Date: Fri, 23 Feb 2024 10:11:03 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui Subject: Re: [PATCH] orangefs: Fix possible NULL deference in orangefs_mount To: Dan Carpenter Cc: hubcap@omnibond.com, martin@omnibond.com, xiyuyang19@fudan.edu.cn, cymi20@fudan.edu.cn, tanxin.ctf@gmail.com, devel@lists.orangefs.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Content-Language: en-US In-Reply-To: <3e4e23ca-5e00-43b3-91a7-690e690279e1@moroto.mountain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2024/2/22 18:45, Dan Carpenter wrote: > This was already fixed in commit: > 9bf93dcfc453 ("Julia Lawall reported this null pointer dereference, this > should fix it.") > > Amusing subject... :P Oh, really sorry for this. I forgot to check the linux-next git. I'm not sure if commit 9bf93dcfc453 will lead to sb refcount leak which was previously fixed by ac2c63757f4f ("orangefs: Fix sb refcount leak when allocate sb info failed."). In any case, the null pointer problem has been solved. Thanks for your reminder:) Su Hui