Received-SPF: pass (google.com: domain of linux-kernel+bounces-77688-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Liu Ying <victor.liu@nxp.com>
To: devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: robh@kernel.org,
	krzysztof.kozlowski+dt@linaro.org,
	conor+dt@kernel.org,
	shawnguo@kernel.org,
	s.hauer@pengutronix.de,
	kernel@pengutronix.de,
	festevam@gmail.com,
	linux-imx@nxp.com
Subject: [PATCH] arm64: dts: imx8mp-evk: Fix hdmi@3d node
Date: Fri, 23 Feb 2024 10:57:38 +0800
Message-Id: <20240223025738.2486807-1-victor.liu@nxp.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?7r+ADHGg5PkgF441YnvfkRhaY3GhU+QDkWQjTkqmy7DkdG6I0ftkbLlvNwfU?=
 =?us-ascii?Q?K0zROkNZoiiLZ88QcDU5wEDlY5twZnhfBUYHdC5VTAkJp1RFtmedW65ADflr?=
 =?us-ascii?Q?EZaFFAXvKkE/Nqg+JqRcXh9VxTjG+eNeoNAWRkiFCUtI7/SNtcn28wNP5Blf?=
 =?us-ascii?Q?HDK4yw7g49gwJlxhrHvg2/w1DBXAwVblvgLrjiviiwMfCRHxdFxQGoH/RGu1?=
 =?us-ascii?Q?dR+NWY++mOexC44jVfNgbqT1tC1QtCMrTnpgMFQHrPHQW2V7cjlq8gayysZ4?=
 =?us-ascii?Q?9rN6PkVqqRs8M0DHBpKiz3Ai+22PLqdK7x+qeSP8s6sVDMBsN/OSd4+d3Ks4?=
 =?us-ascii?Q?M9MX0Vr0mBpkJV9xRBe95APr4DitAgXTJLH4egtIWYGn523cDNTAQrMH3+D2?=
 =?us-ascii?Q?+NRODa/0rYkWgCtTJpDSj2fHttLGxFzXYWD0XJW8zou/6CLPxSIG0Onyo1bp?=
 =?us-ascii?Q?kjiI5a8L342THG9fPkkGheEhdyrplnB1cEBNDg2TqJ5DGtfEwhHXEyPy+Zfx?=
 =?us-ascii?Q?8D8RlUx61l8fz76jxKcaIVRClwP73KfiOIoKYtGJOC2PF0XH45H9kcEm16r8?=
 =?us-ascii?Q?UBahwP9DErM9H5+k2VFQzItCQQZqOhjYcgGBQW62Su+2+idy5G/OPnAeYowE?=
 =?us-ascii?Q?KwlM5xO//RGZyiBoNqDm9vAxs0hNBXDDJpF2GQttnIWW993nQ88pUDg4CwhF?=
 =?us-ascii?Q?+th40cTQ81zV614WIq9calNH3NBWTsmrscnSW1KgUXaPiKheRJeH3OaHMvVb?=
 =?us-ascii?Q?GYjGsB1bQ4XbUkzHStCdCF41lKyQh9jEKhSwG1Tu7BplGi2PjnQ2hvW6gKu5?=
 =?us-ascii?Q?awjgdt2ZInJOs0cC5Hg2aawelMT9NSgZERvecHXYK8hwy1zs6UDpdI1Rg2Lq?=
 =?us-ascii?Q?TFhNqPer4pS2emtkSx9d3Mp63AqVQ09sFF96f5r1Pq/s+p/FXyEm6iSMHhzx?=
 =?us-ascii?Q?aK8vcTy8X0WQN9Y9NdR7t/H0NFzsix8Sp9K77lvV1XZbkhw4sGsEilGO4HuY?=
 =?us-ascii?Q?t4mXvUw5fe7oXOy5kghyb5gKTagbEY+jhUOhMdREA9Ad9CRMzYySQ4yDdQNM?=
 =?us-ascii?Q?Wcwx/JIESiYDzJJdZ39MpuEG6EwLulGr6g1F+QekLVkE7Hwl20MXpmtjgDOJ?=
 =?us-ascii?Q?bIjWF8NDwpXNvWUlLTkMMLsGYOo7zZNt3fwcES30+UT7Vwax/cZRS7WU+ZOo?=
 =?us-ascii?Q?WafgA4IX5az2isU5zfu4w3KS8dHRXZ0jww3WyP4VMXWC06wSKUr4+ECgQcXJ?=
 =?us-ascii?Q?h/04M5e0cnEwaXzmoLmrh2bs1AArtKN3nPGA5ZWhEJe5JyGMuKSdynT77cxs?=
 =?us-ascii?Q?+YG3EQDd859ADuoKOES5j5t4oRM9VO6PxzJ8T8/PoLgTOWkj0A2d/1jZSnRj?=
 =?us-ascii?Q?SC9KKvy2mw60OS3enyRdcItBNWVXnImxwSaw0jW8bPAM3gYnpx0nU8D/q0yP?=
 =?us-ascii?Q?MuYZ73b52e2xs0cDKaz8XihtaLEuInIU1juwiJtXMOvEqrpkOqxMbZks/uly?=
 =?us-ascii?Q?yvVQemdECJRewW12KYfwugPVB3E67ozjerigQRyYvfc3NIPqEKc+DNBSIMZo?=
 =?us-ascii?Q?G0+GBQxB1OQFDiWgcZh7o7O36I3Y88Q8qY8CNvj0?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 493b3014-3365-4a44-7e38-08dc341a126c
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 02:49:36.5422
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WhQLpIihPPC7rl4tXJA+cFBRyaMBtijl0C0iFUm79OTrL1T2SfhCALJAyA4ytiwGV1h6mnSBNsRYkx6sQTSoRQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7237

The hdmi@3d node's compatible string is "adi,adv7535" instead of
"adi,adv7533" or "adi,adv751*".

Fix the hdmi@3d node by means of:
* Use default register addresses for "cec", "edid" and "packet", because
  there is no need to use a non-default address map.
* Add missing interrupt related properties.
* Drop "adi,input-*" properties which are only valid for adv751*.
* Add VEXT_3V3 fixed regulator.
* Add "*-supply" properties, since most are required.
* Fix label names - s/adv7533/adv7535/.

Fixes: 65344b9bed3a ("arm64: dts: imx8mp-evk: Add HDMI support")
Signed-off-by: Liu Ying <victor.liu@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 33 +++++++++++++-------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
index f87fa5a948cc..9beba8d6a0df 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mp-evk.dts
@@ -23,7 +23,7 @@ hdmi-connector {
 
 		port {
 			hdmi_connector_in: endpoint {
-				remote-endpoint = <&adv7533_out>;
+				remote-endpoint = <&adv7535_out>;
 			};
 		};
 	};
@@ -107,6 +107,13 @@ reg_usdhc2_vmmc: regulator-usdhc2 {
 		enable-active-high;
 	};
 
+	reg_vext_3v3: regulator-vext-3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "VEXT_3V3";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+	};
+
 	sound {
 		compatible = "simple-audio-card";
 		simple-audio-card,name = "wm8960-audio";
@@ -364,7 +371,7 @@ BUCK4 {
 				regulator-always-on;
 			};
 
-			BUCK5 {
+			reg_buck5: BUCK5 {
 				regulator-name = "BUCK5";
 				regulator-min-microvolt = <1650000>;
 				regulator-max-microvolt = <1950000>;
@@ -415,14 +422,16 @@ &i2c2 {
 
 	hdmi@3d {
 		compatible = "adi,adv7535";
-		reg = <0x3d>, <0x3c>, <0x3e>, <0x3f>;
-		reg-names = "main", "cec", "edid", "packet";
+		reg = <0x3d>;
+		interrupt-parent = <&gpio1>;
+		interrupts = <9 IRQ_TYPE_EDGE_FALLING>;
 		adi,dsi-lanes = <4>;
-		adi,input-depth = <8>;
-		adi,input-colorspace = "rgb";
-		adi,input-clock = "1x";
-		adi,input-style = <1>;
-		adi,input-justification = "evenly";
+		avdd-supply = <&reg_buck5>;
+		dvdd-supply = <&reg_buck5>;
+		pvdd-supply = <&reg_buck5>;
+		a2vdd-supply = <&reg_buck5>;
+		v3p3-supply = <&reg_vext_3v3>;
+		v1p2-supply = <&reg_buck5>;
 
 		ports {
 			#address-cells = <1>;
@@ -431,7 +440,7 @@ ports {
 			port@0 {
 				reg = <0>;
 
-				adv7533_in: endpoint {
+				adv7535_in: endpoint {
 					remote-endpoint = <&dsi_out>;
 				};
 			};
@@ -439,7 +448,7 @@ adv7533_in: endpoint {
 			port@1 {
 				reg = <1>;
 
-				adv7533_out: endpoint {
+				adv7535_out: endpoint {
 					remote-endpoint = <&hdmi_connector_in>;
 				};
 			};
@@ -524,7 +533,7 @@ port@1 {
 			reg = <1>;
 
 			dsi_out: endpoint {
-				remote-endpoint = <&adv7533_in>;
+				remote-endpoint = <&adv7535_in>;
 				data-lanes = <1 2 3 4>;
 			};
 		};
-- 
2.37.1