Received-SPF: pass (google.com: domain of linux-kernel+bounces-77708-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Chukun Pan <amadeus@jmu.edu.cn>
To: andersson@kernel.org
Cc: amadeus@jmu.edu.cn,
	conor+dt@kernel.org,
	devicetree@vger.kernel.org,
	konrad.dybcio@linaro.org,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	robh+dt@kernel.org,
	robimarko@gmail.com
Subject: Re: [PATCH v4 1/2] arm64: dts: qcom: ipq6018: add LDOA2 regulator
Date: Fri, 23 Feb 2024 11:10:20 +0800
Message-Id: <20240223031020.78744-1-amadeus@jmu.edu.cn>
In-Reply-To: <cliph5zxla23bgguzk52ulxh6trl4qcggjg7hqvrg2d4qdh3a7@mq6fewwjfk2m>
References: <cliph5zxla23bgguzk52ulxh6trl4qcggjg7hqvrg2d4qdh3a7@mq6fewwjfk2m>
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit

Hi, Bjorn
> I still don't see a patch that does "something-supply = <&ipq6018_l2>;",
> which would imply that the main thing this patch achieves is that the
> regulator framework might turn the regulator off after a while.

> Shouldn't there be a user of ipq6018_l2?

Although there is the sdhc node in ipq6018-cp01-c1 in the qsdk kernel,
I don't have the official rdp board of qca, so I can't test it.

Normally it looks like this:

&sdhc {
	bus-width = <4>;
	cd-gpios = <&tlmm 62 GPIO_ACTIVE_LOW>;
    ... /* specific properties */
	pinctrl-0 = <&sdhci_pins>;
	pinctrl-names = "default";
	vqmmc-supply = <&ipq6018_l2>;
	status = "okay";
};

As for actual routers, there are users.
One of the examples is on openwrt, a development board like 8devices:
https://github.com/openwrt/openwrt/blob/main/target/linux/qualcommax/files/arch/arm64/boot/dts/qcom/ipq6010-mango-dvk.dts#L272

	vqmmc-supply = <&ipq6018_l2>;
	cd-gpios = <&tlmm 62 GPIO_ACTIVE_LOW>;
..

The function of this node is to reference sd/emmc supply for devices
with pmic. Please let me know if it doesn't fit in this patch series
and I will deal with this in another pmic patch series.


Thanks,
Chukun

-- 
2.25.1