Received-SPF: pass (google.com: domain of linux-kernel+bounces-77752-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: =?iso-2022-jp?B?Sm9uZXMgU3l1ZSAbJEJpLVhnPSEbKEI=?= <jonessyue@qnap.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC: "j.vosburgh@gmail.com" <j.vosburgh@gmail.com>, "andy@greyhouse.net"
	<andy@greyhouse.net>, "davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>, "kuba@kernel.org"
	<kuba@kernel.org>, "pabeni@redhat.com" <pabeni@redhat.com>, "corbet@lwn.net"
	<corbet@lwn.net>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH net-next v2] bonding: 802.3ad replace MAC_ADDRESS_EQUAL with
  __agg_has_partner
Thread-Topic: [PATCH net-next v2] bonding: 802.3ad replace MAC_ADDRESS_EQUAL
 with  __agg_has_partner
Thread-Index: AQHaZgwUAa7mb20qqEG8uJDe8uCv/g==
Date: Fri, 23 Feb 2024 04:12:00 +0000
Message-ID:
 <SI2PR04MB5097AA23EE6799B3E56C0762DC552@SI2PR04MB5097.apcprd04.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
msip_labels:
authentication-results: dkim=none (message not signed)
 header.d=none;dmarc=none action=none header.from=qnap.com;
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SI2PR04MB5097:EE_|JH0PR04MB7624:EE_
x-ms-office365-filtering-correlation-id: 72a6a500-aaeb-4317-cbbe-08dc3425958a
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 32F7VKSqYmXyqbMd/reUE5e9JFBeCeCAk5SJXxtp3ew5HmFfOmxEORxSeu4IGGlApdShfino1MWdwasVi0JAoZaz+gA8ZMgSC6HT3g8eTOrTvXRJ6iPfjnGsCxGIpyzbOUDRgfnb35P/VnxMXNqmEm13+kFYKXA9fTkTxbrbDR2SQbK5A9MXYuIMzFB1pFCMybfyOSg3miyP5Gw14ZJSV3dDOJ1swzVOWZpOo/Du0Q9Esb0ypdblYlXh/lm55e4zeJiUUcBwkjgL6ElyavGTUKGZHTCqTEbHY2N8piGe+OgMa0TrvwVusjNM3SJMBGwu2B9GZKxSwz637pJga0wmPbua3FJh4MTsu+ll+18PkrG8SD0Jhv0AVufK1yrzRGY3/ccAYBSC9NlWSWvKWonAJfqZ51Z0/IYZq+1hOPUJqU0vWZ0+LfGkRwQjd1AvRu24b7apRa5gJ/r6mblkncVoHhVxV9iI2SUIlV1iAwNKZ12iIr0LmKb+VAESsFfhr5C9thLrV5myXDp1ZiEdqscCD7jevp2XY8UNMtWyNDfeCXw5IiT7Xm+NnsRTA9qXWQojexgDvJRP6MVJyXMYqvEOHslhPGLBt5LVcGki6HRw7qU=
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SI2PR04MB5097.apcprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(38070700009);DIR:OUT;SFP:1102;
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-2022-jp?B?Z09BUlcySXZVaEVRNUM3NWhSeEEzdDFldUlBZU44OXUya2d1MXlQaWpQ?=
 =?iso-2022-jp?B?MGFBcHphVmJvbjZHK2JjVTlCMkpoREJkUU1DT1pvZ2xRODJWaU5mRDhi?=
 =?iso-2022-jp?B?eGdrdm1weWxSS2kybTVUZDBLRnIzaGtRVytZUUh6WDhHTzNDSys0Y2lm?=
 =?iso-2022-jp?B?ZmlXVWZnWkJEWXJNUUk3d1l5REJuT1ZLTjBNSVVIR1BJeXk5eHhzS0lj?=
 =?iso-2022-jp?B?V2dzTis5Q1N6R2E0ditWRG9PMDY4QVBZWEZBR3B1aEpyZk1ScXJzcWVF?=
 =?iso-2022-jp?B?SUdhL2lOSnI2RG0vTUdKT2hUQmxOb0dsc0Z6RGFDODQ2U1RCdjRPTGdQ?=
 =?iso-2022-jp?B?a1VKcWVXcDRWRG96MjVWMWZyU3VXTHFvekdDT0krZmZNMk5kak1EOTMv?=
 =?iso-2022-jp?B?eGJBQVFPWWVYNWIraGpMQlFHblVKNlZ2c3QvTWljSXVDM1pReHBmMFk3?=
 =?iso-2022-jp?B?TldYaWVNV2oycFpkZnNuZlNLQmFjOStDVGtsVXg4dGxnb1F5c1p6ckFo?=
 =?iso-2022-jp?B?RndGMnBuTFFIMDdIOFJZUDBwVTdQanFaOHQ1WDVGc24yS1pIeHdGek1X?=
 =?iso-2022-jp?B?eGtGMGQ2VVU4TTdMMXhoOGxERnhGUUNhaVJKWUVOQ3lqS3FpSFM3ZWxS?=
 =?iso-2022-jp?B?ZStBbFZPSjdhLysrZ2JDdlgrcTZIZDJIaU5jemltWjBUT1FIck1HQjhU?=
 =?iso-2022-jp?B?ZElia0pxeXpiK1N5UldVYlBQcXV5RjVsRU1nSkRpVEhRTHRzQVZCaWZR?=
 =?iso-2022-jp?B?NnhRNGp0eDl5TjFjL3pXdTJQdjl6dlk4djZoekx0d25QWFdSd29ad1Jj?=
 =?iso-2022-jp?B?aThuWkdnN0lzL1cvYWpKODY5S3czYTFzZHNDL3dCemlzWFV1MTVvTVU4?=
 =?iso-2022-jp?B?MEdFakw1ZVY5M3QxUGhONFJwd1U1b0VuTHR4dzhtT0h3WHFja09WRURB?=
 =?iso-2022-jp?B?TkJBWmg0ZGNsQ1A1eEh4QW9uN29kbVFxVUw1dVRzeDFXMk4wMmNwU1BY?=
 =?iso-2022-jp?B?dDV3MVdXYUVqY1kzTDBDdUQzVkNMYmtaaldNOUpHNUJEOU4wSWNlenQ1?=
 =?iso-2022-jp?B?aDRaRHhNSkRqRjQvd3BoS3VWdmpCVVYxK0JqSXg1U2xKbTNSMnYzRm1Z?=
 =?iso-2022-jp?B?UW1leGlsZnVrM3duN1FJM0llUXRabXJobnhkczFFOTZQQkxYcGJhM09k?=
 =?iso-2022-jp?B?dmdOcWdKRllGT0VtVHBWbGl0OFIyaXlPZ2tyT1NmdTJyYldueEpzOEMr?=
 =?iso-2022-jp?B?S2NJM1dmalgwVGQ4aTNpMmZkZGI2NGhodWZhcG5YWndpcUdWNk9zSDNU?=
 =?iso-2022-jp?B?MTV4eVEyL012VkVxU29HdkJRZWtaZm9JbGlhTHcyZU5xTmcxZmw2TE1I?=
 =?iso-2022-jp?B?UFJxTHZlOGhwY1h2SWtybTV6MTVKcEIxMkh3WVJGNFpmOXlRVE9WU083?=
 =?iso-2022-jp?B?TCtrbFdFbjBvRm5UMVBtSnJNS2V3VGlsU2s2eTMrR2JJTG1IS3cwUVJ4?=
 =?iso-2022-jp?B?UFN0N09pRDlPS0RycDE4T0x1aEVpUmRQUlR2V09ONWg5TjRCc1F0c3Ew?=
 =?iso-2022-jp?B?cnl2ZjNwc0hCQ29NNEpYdWVxRyt5d0JWc2FtUjZ3YlQ5RWJ4N1VwUms4?=
 =?iso-2022-jp?B?NmlaZHllMHFoOHRJdWhJMENjWkxva3QzcnJ0UnBkT24ybmFlY1Z2Ylkx?=
 =?iso-2022-jp?B?eDBPYXc3WjVjWDEwZkU1YnNCYU5ES2JrNndYeW81bndvNlAwQjZyL3pF?=
 =?iso-2022-jp?B?TWl4d1NmcnltVTN0dDNjY2xZOGRvcFZ3dmE5QUJkYUl0Vmk2cTRqeVdz?=
 =?iso-2022-jp?B?VXhTZmFaajFoOUV0dmc1RFl2NkR1NERTTXdtd3VCMzNhNDlkNGsxcEQ5?=
 =?iso-2022-jp?B?Tk85TjdPeFJ5RXdsTTNMRzJKQ0tKK0hOZkJhZ3NDaGc3Q0Y5UUVBbWU1?=
 =?iso-2022-jp?B?MVJOS3FJank3UDBGaXFEUUZZY2VQQVRpZlhoOGRoTjRSNTJJeXBvaFVv?=
 =?iso-2022-jp?B?VHdqczhHOFJqRzNNb0QwUTR2U0FScjI3NmJiYmhsZWUveUkwZkJRVVZ6?=
 =?iso-2022-jp?B?eklrVWR1VnUzdnB1QytpNjZBM0hqSlBLcFFKZHhLWXQ5MlowSnlPRTVq?=
 =?iso-2022-jp?B?M1BXa2ErRkp4YVl0WXF3cE9ra0tnWlVxMmlnem4vK2FhYnJEK2RKWkhM?=
 =?iso-2022-jp?B?NG4zQU90ZEVWV1FMR2Jtd1l3bU9hd2taZkIzT2ZoYVpMaHpXWndjbWtP?=
 =?iso-2022-jp?B?NThHUUw5Ykx6VDlpRStVWWxCalN5KzI1ST0=?=
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: qnap.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SI2PR04MB5097.apcprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 72a6a500-aaeb-4317-cbbe-08dc3425958a
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Feb 2024 04:12:00.7006
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 6eba8807-6ef0-4e31-890c-a6ecfbb98568
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: k0YERYfYGhgiccWP36fCScaoXtKDkpL0SrGItgjwzWNgSMChow8OLSf8k98uwRwOpg2ym5mq3an382NFp8tNGA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: JH0PR04MB7624

They are verifying the same thing: if aggregator has a partner or not.=0A=
Replaces macro with inline function would look more clear to understand.=0A=
=0A=
Signed-off-by: Jones Syue <jonessyue@qnap.com>=0A=
---=0A=
v2:=0A=
  - Add correct CC list by './scripts/get_maintainer.pl -f Documentation/ne=
tworking/bonding.rst'=0A=
v1: https://lore.kernel.org/netdev/SI2PR04MB50977DA9BB51D9C8FAF6928ADC562@S=
I2PR04MB5097.apcprd04.prod.outlook.com/=0A=
---=0A=
 drivers/net/bonding/bond_3ad.c | 8 ++------=0A=
 1 file changed, 2 insertions(+), 6 deletions(-)=0A=
=0A=
diff --git a/drivers/net/bonding/bond_3ad.c b/drivers/net/bonding/bond_3ad.=
c=0A=
index f2942e8..eb3c2d1 100644=0A=
--- a/drivers/net/bonding/bond_3ad.c=0A=
+++ b/drivers/net/bonding/bond_3ad.c=0A=
@@ -2036,9 +2036,7 @@ static void ad_enable_collecting(struct port *port)=
=0A=
  */=0A=
 static void ad_disable_distributing(struct port *port, bool *update_slave_=
arr)=0A=
 {=0A=
-	if (port->aggregator &&=0A=
-	    !MAC_ADDRESS_EQUAL(&port->aggregator->partner_system,=0A=
-			       &(null_mac_addr))) {=0A=
+	if (port->aggregator && __agg_has_partner(port->aggregator)) {=0A=
 		slave_dbg(port->slave->bond->dev, port->slave->dev,=0A=
 			  "Disabling distributing on port %d (LAG %d)\n",=0A=
 			  port->actor_port_number,=0A=
@@ -2078,9 +2076,7 @@ static void ad_enable_collecting_distributing(struct =
port *port,=0A=
 static void ad_disable_collecting_distributing(struct port *port,=0A=
 					       bool *update_slave_arr)=0A=
 {=0A=
-	if (port->aggregator &&=0A=
-	    !MAC_ADDRESS_EQUAL(&(port->aggregator->partner_system),=0A=
-			       &(null_mac_addr))) {=0A=
+	if (port->aggregator && __agg_has_partner(port->aggregator)) {=0A=
 		slave_dbg(port->slave->bond->dev, port->slave->dev,=0A=
 			  "Disabling port %d (LAG %d)\n",=0A=
 			  port->actor_port_number,=0A=
-- =0A=
2.1.4=