Received-SPF: pass (google.com: domain of linux-kernel+bounces-77762-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240220171457.703-1-kprateek.nayak@amd.com> <20240220171457.703-12-kprateek.nayak@amd.com>
In-Reply-To: <20240220171457.703-12-kprateek.nayak@amd.com>
From: Guo Ren <guoren@kernel.org>
Date: Fri, 23 Feb 2024 12:37:30 +0800
Message-ID: <CAJF2gTRFwLw7v8Ks=_Tu-SmYjC-1D7_L0beGNjkJ-180f5ULuw@mail.gmail.com>
Subject: Re: [RFC PATCH 11/14] csky/thread_info: Introduce TIF_NOTIFY_IPI flag
To: K Prateek Nayak <kprateek.nayak@amd.com>
Cc: linux-kernel@vger.kernel.org, "Gautham R. Shenoy" <gautham.shenoy@amd.com>, 
	"Rafael J. Wysocki" <rafael@kernel.org>, Daniel Lezcano <daniel.lezcano@linaro.org>, 
	Ingo Molnar <mingo@redhat.com>, Peter Zijlstra <peterz@infradead.org>, 
	Juri Lelli <juri.lelli@redhat.com>, Vincent Guittot <vincent.guittot@linaro.org>, 
	Dietmar Eggemann <dietmar.eggemann@arm.com>, Steven Rostedt <rostedt@goodmis.org>, 
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>, 
	Daniel Bristot de Oliveira <bristot@redhat.com>, Valentin Schneider <vschneid@redhat.com>, linux-csky@vger.kernel.org, 
	linux-pm@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 21, 2024 at 1:20=E2=80=AFAM K Prateek Nayak <kprateek.nayak@amd=
com> wrote:
>
> Add support for TIF_NOTIFY_IPI on C-SKY. With TIF_NOTIFY_IPI, a sender
> sending an IPI to an idle CPU in TIF_POLLING mode will set the
> TIF_NOTIFY_IPI flag in the target's idle tasks's thread_info to pull the
> CPU out of idle, as opposed to setting TIF_NEED_RESCHED previously. This
> avoids spurious calls to schedule_idle() in cases where an IPI does not
> necessarily wake up a task on the idle CPU.
>
> Cc: Guo Ren <guoren@kernel.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Juri Lelli <juri.lelli@redhat.com>
> Cc: Vincent Guittot <vincent.guittot@linaro.org>
> Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Ben Segall <bsegall@google.com>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
> Cc: Valentin Schneider <vschneid@redhat.com>
> Cc: K Prateek Nayak <kprateek.nayak@amd.com>
> Cc: linux-csky@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: K Prateek Nayak <kprateek.nayak@amd.com>
> ---
>  arch/csky/include/asm/thread_info.h | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/csky/include/asm/thread_info.h b/arch/csky/include/asm/=
thread_info.h
> index b5ed788f0c68..9bc7a037c476 100644
> --- a/arch/csky/include/asm/thread_info.h
> +++ b/arch/csky/include/asm/thread_info.h
> @@ -61,6 +61,7 @@ static inline struct thread_info *current_thread_info(v=
oid)
>  #define TIF_SYSCALL_TRACEPOINT 5       /* syscall tracepoint instrumenta=
tion */
>  #define TIF_SYSCALL_AUDIT      6       /* syscall auditing */
>  #define TIF_NOTIFY_SIGNAL      7       /* signal notifications exist */
> +#define TIF_NOTIFY_IPI         8       /* Pending IPI on TIF_POLLLING id=
le CPU */
>  #define TIF_POLLING_NRFLAG     16      /* poll_idle() is TIF_NEED_RESCHE=
D */
>  #define TIF_MEMDIE             18      /* is terminating due to OOM kill=
er */
>  #define TIF_RESTORE_SIGMASK    20      /* restore signal mask in do_sign=
al() */
> @@ -73,6 +74,7 @@ static inline struct thread_info *current_thread_info(v=
oid)
>  #define _TIF_SYSCALL_TRACEPOINT        (1 << TIF_SYSCALL_TRACEPOINT)
>  #define _TIF_SYSCALL_AUDIT     (1 << TIF_SYSCALL_AUDIT)
>  #define _TIF_NOTIFY_SIGNAL     (1 << TIF_NOTIFY_SIGNAL)
> +#define _TIF_NOTIFY_IPI                (1 << TIF_NOTIFY_IPI)
>  #define _TIF_UPROBE            (1 << TIF_UPROBE)
>  #define _TIF_POLLING_NRFLAG    (1 << TIF_POLLING_NRFLAG)
>  #define _TIF_MEMDIE            (1 << TIF_MEMDIE)
> --
> 2.34.1
>
LGTM

Acked-by: Guo Ren <guoren@kernel.org>

--=20
Best Regards
 Guo Ren