Received-SPF: pass (google.com: domain of linux-kernel+bounces-77766-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <03499bd0-323d-4f57-99a8-d47c5ae680ae@amd.com>
Date: Fri, 23 Feb 2024 10:16:26 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2 2/4] net: macb: Add ARP support to WOL
To: Andrew Lunn <andrew@lunn.ch>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
 davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
 pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
 conor+dt@kernel.org, linux@armlinux.org.uk, vadim.fedorenko@linux.dev,
 netdev@vger.kernel.org, devicetree@vger.kernel.org,
 linux-kernel@vger.kernel.org, git@amd.com
References: <20240222153848.2374782-1-vineeth.karumanchi@amd.com>
 <20240222153848.2374782-3-vineeth.karumanchi@amd.com>
 <8e4a779a-22e7-4db2-b65e-69cca5e6fac5@lunn.ch>
Content-Language: en-GB
From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
In-Reply-To: <8e4a779a-22e7-4db2-b65e-69cca5e6fac5@lunn.ch>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?QUR3NzVGVmVaZWR2TDZnTlNyeU5KVm90c0p5azBZUGhpR0R3bitmYkd4RXBQ?=
 =?utf-8?B?UERSZXZpalRpWWJuWmxuNGsyaG1UeElWczJiQlBvZEVyNG5OYm5Vc3o2TlVW?=
 =?utf-8?B?MnA4TUl2K2xwU2JMbjNRUDkvbDFoVWZSS0Nsb084eDZIRS9BVU41RitMOG5W?=
 =?utf-8?B?NTdzc0hKYldGdlNJSEkzdWVwZXNXdmdpWHQ1UERSU1FQN1ZuR2VwQ0dYWjMw?=
 =?utf-8?B?ZjlEdGZQdXowUFBzWHBZNFV1dHk3emYxeGRNVk5LRkN6c0FtMFZPeDB6UmdZ?=
 =?utf-8?B?dEd0Y2cxa2xCbHhZV3kzQkNaS1FIaGRrbE1nTHBQeHdaaWFadzJjY2dENVRL?=
 =?utf-8?B?SEtRMjgvTUVpdTVySHcrVUVnSlJFekM2K3p1QTZvNENleDBEVHhVNzZDcHZo?=
 =?utf-8?B?cytNcEFsa3NnQ21HWmVMZnM1RnNHTnl5YWhPTkdLZGprbEVybmNPalM4OXFN?=
 =?utf-8?B?cHlBV0xSTmYxbUU0YnB1SWloZ29mSnhvOG9NclFYZWZwRTIvV2FYaXlUeEpU?=
 =?utf-8?B?cWdLd0lnMHJnanZqTkx3K0JwaHFiMEhCZmNBR3FrbVdzcE9ZNnAxMUgxVVlX?=
 =?utf-8?B?M3pOa2dsUUZjSzk0TWVkSjUzTmd6Y2pacDFyNFRaeDFLM3R0aW1OQlhuN1FP?=
 =?utf-8?B?SUFmQmI5ak5hZ09CUitrVUh5MjJxaXozSS95ZkxRcVBOekFiSDdiTzlhZ1RG?=
 =?utf-8?B?L2M2SlA1TndNMjl0R1ZHcEEyRFNiaHJmMUVzY1laWmF4LzRISGdPN2RYajJn?=
 =?utf-8?B?Rmh4V0x0SnFGU1c2Myt3Z1JHSE93czc1dTczTDdQZVBCWktsREZvdU9PVDh6?=
 =?utf-8?B?UGViQXJvaENybkd3cnRXUWlVVGo0TmhmZXpFaEt5ZGI2NW0xWFk3VWltQjBY?=
 =?utf-8?B?MGpUWExYL0I1N0c3aXpKV1M1THRILytheHBzL3J0VnMyTy9OY2NmeFM4cTVY?=
 =?utf-8?B?ZjdQa0xBUVNkMW43MW1kM0pqZXVFZVoyaXV3d2NZaS8rMkhsOTZLS0F2L0E5?=
 =?utf-8?B?QjE2RFlVYmJyM0FJRFZmaGdOWUtFcW93ckZlYkJJRlBsNUNITXIxM0xGNGpi?=
 =?utf-8?B?bUR4M3kvQklDWEJISi9oRHlPRjhZQmIwSnQrejRyT0NWc1B1ZDYyUGFkTGZW?=
 =?utf-8?B?SkNUM0prOHQ1WXRPWjZmbDA0VFBrdzYxYkpWRFZQUzRXTUZ5SExWeGhrZEYx?=
 =?utf-8?B?Ti9jSVNMSkM0ZUQxRXRzSVgyVjdiYUVYd2J6N0hJMEZNbCtPWmxVRVkxMXBm?=
 =?utf-8?B?c0UzRWpoV3lOS1hyNlVHcENEYWVLNCtKY2JvWHpTeWRSNkVVdko5ZHlReUpT?=
 =?utf-8?B?cGFCSVAzcFRwYnVZVGU3c1NzTmtjMnYwUGhndU1iTi9NelhSZ01MbVRYT1A0?=
 =?utf-8?B?RklTTHZiNmpCeGFlYVNQb0RLTndpT2RaUnNFeDlMWUx1cm9OTEpaNUdSRGVQ?=
 =?utf-8?B?TFhMN0lGRVRBejUxQlp5STNyK3FKZi9nSUR3KzVmVUlwVG9rbVRjcnY2THBH?=
 =?utf-8?B?WXR3RVBWN3VxL3doSWlVYnVscEw0dU5QM0hCdEE2dVdZcURBeVJOKzZBY0s2?=
 =?utf-8?B?eTlZL2l1Y1pNZVlXMXFsdHROSkpDOUs3dnFmejQ2d0lVQW5iVUcvNjR4T01y?=
 =?utf-8?B?aEZqWmp3TGZBakNvWFJKNG41WE44elhuTmF3Y0o2NXZXZW41RGJlU244eWF5?=
 =?utf-8?B?YWZIMGp0cDBDRWJIMzhTRFFLR2duMGJPeTB5WXlSYjlMNTdGTWkvWDlqenNk?=
 =?utf-8?B?bkdBVkRzLzFIQzVJTHE5TDk4T1lwcm9HMDRZdFBydEJoRHphelh2cStuVUNi?=
 =?utf-8?B?Qkl0SDZaRjNvSXRDUjdqOStlQ3RVeDFBc3VSS2NCOWhrdkMxUVhzSjBjeWZx?=
 =?utf-8?B?bDZoNFB5SFlOR0lCMndteUkxYldhTUNnSExBSlBVWDVnSWhqVksyU1diRWNs?=
 =?utf-8?B?VnFDazlMcXRqaEFmVFp3NWw1RkZwcmtlOVI4RHlveXN3RDZqakVxcVV0NUxk?=
 =?utf-8?B?akh5VTR2OW0wRmFSbWl6NGhJVnRRanFRSTNIZ2VZaUw5enVaaVJYSU9vYzA0?=
 =?utf-8?B?N29TcnJFWUtYaEt6S1JuQXcwWTllLzhzRzlSa1l1WHFvcHNnWlYyaGZkUzlB?=
 =?utf-8?Q?XKQVD6cg4FMXCm0GGfxMfzG9F?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 59e6d274-8fc8-46ac-6f66-08dc342a6a37
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5946.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 04:46:35.8212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 15krgvatj8d7U5GSybKqwV09sCF7r1ahwG/Gl5HM5WK77B5OwKt9dXAfD/jdJdRd
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB8290

Hi Andrew,

On 23/02/24 1:02 am, Andrew Lunn wrote:
>>   	u32			wol;
>> +	u32			wolopts;
> 
>> +	wol->supported |= (bp->wol & MACB_WOL_HAS_MAGIC_PACKET) ? WAKE_MAGIC : 0;
>> +	wol->supported |= (bp->wol & MACB_WOL_HAS_ARP_PACKET) ? WAKE_ARP : 0;
> 
>> +	if (bp->caps & MACB_CAPS_WOL)
>> +		bp->wol |= (MACB_WOL_HAS_ARP_PACKET | MACB_WOL_HAS_MAGIC_PACKET);
> 
> So bp->wol is the capabilities of the hardware?
> 

Yes, it holds the supported capabilities.

> And bp->wolopts is what has been enabled via ethtool?
> 

Yes, it holds the selected options through ethtool.

> I just wounder if it would be easier to understand is bp->wol was
> renamed wol_caps, similar to bp->caps?
> 
> 	Andrew

Sure, I will make the change.

???? vineeth