Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp754724rdb; Thu, 22 Feb 2024 20:48:20 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVDOyay7Srve5BHdSIzGPskM1AlknNYs570HbDxHxYWcg8HtT6gMQAHtyY9PNrHYtc7MbmFu1lk/ftt9lHb4/CnpaD5PXoepEgVmcVlYw== X-Google-Smtp-Source: AGHT+IGgfr0ry8yv9O+h9DrnVwcWsOdpkGRqXoJOh/UqX/v9Ael2dTFmoW63V9b/tRteBkUN2Wyt X-Received: by 2002:a17:902:db11:b0:1db:cf8c:d3c1 with SMTP id m17-20020a170902db1100b001dbcf8cd3c1mr1052911plx.57.1708663700602; Thu, 22 Feb 2024 20:48:20 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708663700; cv=pass; d=google.com; s=arc-20160816; b=Zr3OfckozZXjCyjY7YEuVHAT7AP+s7FWtL3Kdxuz/m8aSCAKqUU6Mjev1ec+U6IUYy UEOvrx2N4bPu20cbqnIdKJ0nUT7McPw5CLaGjjRP6IzkcGp3SvJxiylQQRjwLGha1/rv ZjxkkdY9/zGMJ+SbwCIAdok5noE1vr5eAQREKVPThLA5kzfQq0Gb8AJqc2LsQxpu8WXT O18qt2TOyLfo/ArX5dPjZ+5RMfz/cZ8cb8NVnfc9/kU5os+XPGzMQkkZgn5T0htlzCiA NyuXAccrDZW7ftJrIfz6xyCHyCLcI5Ex5XH3f6cSQMFSOFiuECpMgyx1m+dBQHlnKkDY 0FYA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=nXcNF0qh6SMAktBO6OSfev2SM0LlhBJpb+/xBaQxmkQ=; fh=oJpbns92jcJjGKKM6rWIRTRd8ICwEvxpTAftwzCGMwI=; b=DbyliNShk1fwmu0fyCxfGjFFDFelma1FN6nfQ66/dfH39tZiXCZtiWAxmHWBxSr4ul 7lbfkWloHGhasumM5sTAdYJ3oc32HhXIkoajXxKILUE1LZf8glliHu4xHlGd63ZrYPiU hVvELYLXzoUL2OT+pn+D6ZSTmSDbAf0atXOF51RW7uHSUiY+0t0KBb5nl356QT9DYL9Z tYwun6dtKh9GjnJKkpCA0Mvj72ddviT5BtoSRKqm66xW5I/lJ2oyQDcjLD9JT6bnMuGz TPu+3O7jvTnKDEXOPMlCT9YLWBQXxVOL2IrSbvrmHD3P7W95wENMScCd5pMm6CRN/gsY t+kA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=aObkpeWi; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-77767-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77767-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id j6-20020a17090276c600b001dba7e06c0dsi11143082plt.127.2024.02.22.20.48.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 20:48:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77767-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=aObkpeWi; arc=pass (i=1 spf=pass spfdomain=gmail.com dkim=pass dkdomain=gmail.com dmarc=pass fromdomain=gmail.com); spf=pass (google.com: domain of linux-kernel+bounces-77767-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77767-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 4CDDC287B25 for ; Fri, 23 Feb 2024 04:48:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 30D0111706; Fri, 23 Feb 2024 04:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aObkpeWi" Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F7FFC8DE; Fri, 23 Feb 2024 04:48:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708663690; cv=none; b=dhWVeQBM86Be3RTSijxomInP5dlZql2RGFmmFBBNwn/9RpHJTSvaa2JvXWYSEC15oMM+nS2ugytnWLtL6iHQTO4Ns1TX3qo9h/nBw6A03orahuILe6V7ODCGLh7skaWBvDO3i9uHiaTW78Kzv7kenj2Qz+/JtZsHXBQJvcwWZyw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708663690; c=relaxed/simple; bh=7bhHjyonMe9PX18yfWiX0QvGsbyBCiFCSTsTEciJaNw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gfe6k5Pssq4mYB84wRhdt98oI+L+7DaI6Iyl7dURPpiCGz89y6/b0UF13Ayq5rEjDIjWWnPZXksoqkUxYmhNoiIv8gyKOPoed60Zf0OHMP+xfrmPJo1L9o4YK9N1zlrocsQes4zcKBdAtJW96XFa4gHTpvx4/cS7OBOsuIfpKlA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=aObkpeWi; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-78725b62cf2so22612385a.1; Thu, 22 Feb 2024 20:48:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708663682; x=1709268482; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=nXcNF0qh6SMAktBO6OSfev2SM0LlhBJpb+/xBaQxmkQ=; b=aObkpeWi69a8HeaYT5lG+dFh46lx/4/Meh8OGxAFQo4mUxwuQSUcWyRh6XJUCyhe2T sz3akP5pTpDeaeP4nZrLixuL5hx2Y2+eRSxQ7LalN8hbwjti92ODHuSxKKkCtCXX0j09 4epbq5qvHGaUHhNifQGR/SivYjmW0lZZLkZ4flbahzx1X/anF8PwYdQjhYAYoQEJjWXc u+3Rs6pWJbnp2nb84TPzaXGsvnJT5t+sdwzrfhGT9ltK/wXFt5OcjVDzDFXsKmxRP0y6 sOLT+hanL4M5weex59Aq6f3LL9Q+msT+IDAn0/6I0e8hIyRiOxNWGVS/gOyBuZhCpX+f tG0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708663682; x=1709268482; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=nXcNF0qh6SMAktBO6OSfev2SM0LlhBJpb+/xBaQxmkQ=; b=aYdC7eBNv2OI0zFyPDuSguVU/OaVWkUuvmE0J8rMChSD3GiySD/Io+CL1Ix1j1e7zK oDphDI+An0v2/I3nPMBqIvWieyczFiovUUhpvsQ0rEt888sHF8EzHaAK20Fku3PVgyP+ lTxz62VCqFFkSFRydYLGpgSZDctWpuP5jATnNlYbGzilFNHYC8CGVrqV4UeHcE5UMKwZ Y4iqEBPK9yFtiJHLylw4B5zNptZTPlh8K4r9py5QdOKUmYmt8Kf56w/1wmkiC5ILY+TO /ACk0VvQQJspl2ndX99gqAD3254PYzpTz+4Raqe8FsuXyGlXH7QrVGeAiWBAYPPuBAO7 0gxA== X-Forwarded-Encrypted: i=1; AJvYcCXg+3xwm3lv7MdS6weFq/wToTuiiYr97FUAQUJ3nmVTyj9dC1/jhdbWRIXQx92LPyw/ndfjZUijkeKN3tKvAHUb1oFollNMrzD8wWCiS5yYGUSkT+oA5HhG0mi87sYAOPexar4q X-Gm-Message-State: AOJu0YyL4aZc43qknu+i/PtVR9eS6GFo/f89fPnDpa7qWO2om3U6vJ9g 963Jzcc1sMTiAGr0zve1o5qBKDIsicZCwnx82gN4KHCT1yOY9Kfa X-Received: by 2002:ad4:5ba6:0:b0:68e:fb17:e14b with SMTP id 6-20020ad45ba6000000b0068efb17e14bmr1396417qvq.1.1708663681845; Thu, 22 Feb 2024 20:48:01 -0800 (PST) Received: from [192.168.1.3] (ip68-4-215-93.oc.oc.cox.net. [68.4.215.93]) by smtp.gmail.com with ESMTPSA id mb10-20020a056214550a00b0068f85706ecfsm4744800qvb.104.2024.02.22.20.47.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Feb 2024 20:48:01 -0800 (PST) Message-ID: <572300ab-3475-4ea6-b6c9-9206f237171f@gmail.com> Date: Thu, 22 Feb 2024 20:47:58 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v5 3/8] net: phy: Add helper to set EEE Clock stop enable bit Content-Language: en-US To: Oleksij Rempel , Wei Fang , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Lunn , Heiner Kallweit , Russell King Cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Shenwei Wang , Clark Wang , NXP Linux Team References: <20240221062107.778661-1-o.rempel@pengutronix.de> <20240221062107.778661-4-o.rempel@pengutronix.de> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== In-Reply-To: <20240221062107.778661-4-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/20/2024 10:21 PM, Oleksij Rempel wrote: > From: Andrew Lunn > > The MAC driver can request that the PHY stops the clock during EEE > LPI. This has normally been does as part of phy_init_eee(), however > that function is overly complex and often wrongly used. Add a > standalone helper, to aid removing phy_init_eee(). > > Signed-off-by: Andrew Lunn > Signed-off-by: Oleksij Rempel Reviewed-by: Florian Fainelli It would be useful to also read whether the PHY is capable of stopping its clock, this has IMHO always been missing. Clause 45 IEEE PCS Status 1 Register (3.1) bit 6 reflects whether the PHY is capable of stopping its clock. -- Florian