Received-SPF: pass (google.com: domain of linux-kernel+bounces-77776-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 22 Feb 2024 23:00:03 -0600
From: Lucas De Marchi <lucas.demarchi@intel.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
CC: Erick Archer <erick.archer@gmx.com>, Oded Gabbay <ogabbay@kernel.org>,
	Thomas =?utf-8?Q?Hellstr=C3=B6m?= <thomas.hellstrom@linux.intel.com>, Maarten
 Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard
	<mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, David Airlie
	<airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, "Gustavo A. R. Silva"
	<gustavoars@kernel.org>, Kees Cook <keescook@chromium.org>,
	<intel-xe@lists.freedesktop.org>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>
Subject: Re: Re: [PATCH] drm/xe: Prefer struct_size over open coded arithmetic
Message-ID: <qoh3tnyvphqjilg7sz75fbjxzvjn6ey46hcvk3rhiaay3bcfmo@rzbvamf67qvu>
References: <20240210141913.6611-1-erick.archer@gmx.com>
 <30715dc4-3285-4f4a-a041-a718a8509721@embeddedor.com>
Content-Type: text/plain; charset="us-ascii"; format=flowed
Content-Disposition: inline
In-Reply-To: <30715dc4-3285-4f4a-a041-a718a8509721@embeddedor.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Z/hDHoExQ4Sd4HqUzD0q56F1bK1iR4rWjHCvqEUuRVWUFrx6Jfpq06CZLU4Z?=
 =?us-ascii?Q?tcBAyF3zFszs0XXC2kgy0BbBlO83sMi1WztGcLAwkrp5wXC1lc6RXjUgOwaT?=
 =?us-ascii?Q?l9gNLnb7cmW9WhOpo3UuiL7iBKlw3m1CgW3yHxa0W2mJuwP4n6ebeogTLb85?=
 =?us-ascii?Q?ayt87VR4TcOKk03VqXI4uitARba2uZ5trXYK7fbzMSLMa8UJgpJp9AkNv4Nb?=
 =?us-ascii?Q?eIMhHIV308j8oMiF0K0/IGdTl3L0Txdsx7o+evtOL1VRK/j1vzdu6ihtj33d?=
 =?us-ascii?Q?TrYq/oL8AYqCY5NKra753EsROlSMJNlfWm5kboFUCXTEWUwNR9QR5mVrDVf9?=
 =?us-ascii?Q?YtmCaE1aIQZn/gpW9DYEY9a2A2qUvVoPZ34ZOXRkyJBUzZysUJRyMdHHnMjY?=
 =?us-ascii?Q?907Z4Ckd6bklhMRDS6JqymWFL+oT6Eq2YW57Dnba8iQuhBG+EzPNYlGBWi8m?=
 =?us-ascii?Q?CpJVF4z2dde7EX8Jgo2y9MF4KG/26d7NbQAAikVDLd/+PwaxvKjcmAI018VR?=
 =?us-ascii?Q?wYXIO3yPJvORCmQe28sH8ZJ+lNXv083bDBw5tbGJWRqKWr4H1yFEd13N3/qe?=
 =?us-ascii?Q?LA9pMa9nYIg23JfoWujsTz3X9llmYrF1EIfspX68hdu9Xv2AyOs5RIqDmv6b?=
 =?us-ascii?Q?ckfzkeBMqrEh4XjuasmDu4dtuph3PxITmLeplG+8/2rDiWe/aWXDZ4VI0qxW?=
 =?us-ascii?Q?oytjdB789LeXzgz1KLHCmXXdVcIH4sr/MLyFmkZV3mKFWaZutD9YjZrMx38S?=
 =?us-ascii?Q?Nt/hlDs9ngki1Xky+RP9U4XFZkQvs4b94BONHP1eGSKyKKJhc9/VdCOTkW2X?=
 =?us-ascii?Q?jore9IP9SirKMFjPa521Oh9h9edvLb6E7x/SZITI8ZP3OotGatipK3/cvNWx?=
 =?us-ascii?Q?xv+R46OYEW7SUT2DKNXKD1X6HMQ0ajgYPjVu+6KGbhg0T95RItn5CDzExIkd?=
 =?us-ascii?Q?aQwEORruJeZ6ptTpH3xSPonue0w/6p5SuXzq8cJVSItg3zBcmtTRagMIXIcy?=
 =?us-ascii?Q?amR5z6rqHM5UySOBz04LrmmaPAKBcZoLjbUmTrq4nlSFvvHpHWNdte4/wmHm?=
 =?us-ascii?Q?weaIPzIg3zx1UHmoWsN3KG3ykNXijl2gwQj5SOpBEpH7sL5SFVensxZPEsoB?=
 =?us-ascii?Q?nui5lkHG5qZfKSlR345fZq0VNyC61GDWqpCj6nYtV3g+ACtSGDfWG0UFbopW?=
 =?us-ascii?Q?0b7O4APSQ17tNy8j4OzrtKdJ5fJiBXk2lyuFD1VdwizDwd0fpHgjXy9RBpeE?=
 =?us-ascii?Q?NaeDvisIo6FH/pr9WRhNVRDFrjBq95IMQNPRiIL3RwQGowsZIhISTcyNgbdR?=
 =?us-ascii?Q?+ReZ29l9kjZdMO26jsaFvmwBVPSzHy1DTR1LZyItxtkuhW6Hi5ZtLnsA6gBJ?=
 =?us-ascii?Q?uooulKP4sLpoKHkZEOIkkSyPpzQCJR4KSereF6L7ow2VNfgFsmVogYrqizy4?=
 =?us-ascii?Q?XUu9PNMuKykfL3JV6SebniwZ/WvFS5o5bo7wMDJd9ScUAvpvWe1898EqGaSP?=
 =?us-ascii?Q?l//ELoHOq0lbkopymf8iGp9n2DY/jdw8S6ApdtLCMVq2XqB+BJfI2rXdH2u4?=
 =?us-ascii?Q?/lTA5MzVDY1VQ4z045HziS50dr8hiNuTP0AuPgqj2cAFd5Br4ofIl+Y7Vetn?=
 =?us-ascii?Q?2Q=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d0d8df2-16bc-4bd2-04fc-08dc342c4d6d
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6139.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 05:00:06.2739
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1JScZqZo5FJh0qumdNUhUQDxfUwLkFdg4jb7QAHhCK4jkMLqcddijUmQUyGBtQNgts8schxvHTpXw5Hq37TQrQaBm71E8K5AON9iBCLomJc=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB5776
X-OriginatorOrg: intel.com

On Sat, Feb 10, 2024 at 10:49:57AM -0600, Gustavo A. R. Silva wrote:
>
>
>On 2/10/24 08:19, Erick Archer wrote:
>>This is an effort to get rid of all multiplications from allocation
>>functions in order to prevent integer overflows [1].
>>
>>As the "q" variable is a pointer to "struct xe_exec_queue" and this
>>structure ends in a flexible array:
>>
>>struct xe_exec_queue {
>>	[...]
>>	struct xe_lrc lrc[];
>>};
>>
>>the preferred way in the kernel is to use the struct_size() helper to
>>do the arithmetic instead of the argument "size + size * count" in the
>>kzalloc() function.
>>
>>This way, the code is more readable and more safer.
>>
>>Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [1]
>>Link: https://github.com/KSPP/linux/issues/160 [2]
>>Signed-off-by: Erick Archer <erick.archer@gmx.com>
>
>LGTM:
>
>Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>

applied to drm-xe-next. Thanks for the patch and review.

Lucas De Marchi