Received: by 2002:a05:7412:798b:b0:fc:a2b0:25d7 with SMTP id fb11csp770871rdb; Thu, 22 Feb 2024 21:48:00 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXUAzpdl/iZbcQWvjqSvanNoF5ZQf1Ms8jgfRAxFpGQRS2uJ7i+4A2OxOMd9TofVctJZnMNJELwYOWQJ54RkgdnNzoqDZHwJmkjjNynAA== X-Google-Smtp-Source: AGHT+IGrzUgGhw+4xl/xu4SwGMcPRuvww0CbHuA48h0XCKZlMpZKiVDb/D9eiRCROtlYMusPpZco X-Received: by 2002:a05:6214:21ee:b0:68f:da3e:26a with SMTP id p14-20020a05621421ee00b0068fda3e026amr310006qvj.59.1708667280642; Thu, 22 Feb 2024 21:48:00 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708667280; cv=pass; d=google.com; s=arc-20160816; b=przickzakgvkVmDqSewd1bi/rsiQ3BFGAGu0qH60N8No0o1opNsNnqjCkTAGlDliUo JSQpgoBmwoEOCDjuHXxtBFBgwJvbOYeZJJuqAYX6gQ9AwAN4M8IK7Lgt9vNyghAK5dGO WLcnPOf8b8YDUJaV3IHdVZbDyVvOBJcOgYL3+USIPm3kfgjo+hrDpAzG9GvDKY8xQype +1NhgyykOxfP0dD/bv2Cm4V3D3I4r0WEMB2D99uhwfOxn7W5iFd94Tr7XDM2kHfohAkw KLnwSCSRKM746UwFlfNvmHjtoRflnRPV3uf9nOxT3FDRV6nmbm0/8I3wXGqujXnHg6xs iV6Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=FLgAnoMtXtOoP/MT58Z1R1M569JvS4pDWEpHe4CcF8k=; fh=VKJnjaoQMuUrAX1ck9BiEodJ05HZfgUbdoqCfAULDrU=; b=sskLY66hNurX2KkNzmnZ7jr/IYdirzBBR9sNDpo+p5R0I5SHbrklsMDJS4Gh7oQhlx gnSmElDWYEZibABrDL05bMOtfJdA4eI2tgZWiSj88BB1ZpEGcUwoFcH9TgdXJN9/wBxD s6x+MRFhDfv234t75idiz7N44hFBlBez5x3Zc+Fqw6jfU4sVEMV9vnRaWTqqzBPEkl33 ZXINAIIDt+jdcSGMC4SNyos5DoRLq9stTkDno2uuqhz/dXRqTnMBRRpiqTAsMHymcYUW kmNce6KlJlN1oN3XrcCHtjr9LUwBWUPSSRzkXYogjOr6T6GwTmujlw2Y+OGa1ewLXeZq PUfw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VgwsAoo3; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77802-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77802-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id 14-20020ad45bae000000b0068f740f0e0asi9994068qvq.77.2024.02.22.21.48.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 21:48:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-77802-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=VgwsAoo3; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-77802-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-77802-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1049B1C225D3 for ; Fri, 23 Feb 2024 05:48:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C33C125AF; Fri, 23 Feb 2024 05:47:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="VgwsAoo3" Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 28C3A125A1 for ; Fri, 23 Feb 2024 05:47:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708667274; cv=none; b=ZbamnBbMUO47yQYfG6BNPF6LAMjszNiSF5QyVvJe7orycTqf60y/eGmEnUi6BIABiGys5WxmYMyJafBWw/s2+oeuYE2yhwh5JeyBmbvaVB0nK3knqLy8CoBJerZ/BczAx8podpZIo5aytdvVHXrE+jDRBVz2MKOyfh8YzP/NWvg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708667274; c=relaxed/simple; bh=7iHj8FnF8qOYSqO3SQ/uX8AyqMoQwBVtuKeJJZPr+XQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pAE7s3WxlNrfzaoDBCKEUdL+sY5ldvUfFoH9j1ymFKV41LS/HgqciM+D4xZi0gXsMbcF4lCKeen8c97AXV2Mv1gPcF7JqorA2AEbSRDgQolSD6Sfu9et/4htH2No5wWrUe58KpTS8Y+6W18I3ywMAwr1NnIQIId5yqh+dJIMO2M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=VgwsAoo3; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6e47db45ae5so2306a34.0 for ; Thu, 22 Feb 2024 21:47:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1708667272; x=1709272072; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=FLgAnoMtXtOoP/MT58Z1R1M569JvS4pDWEpHe4CcF8k=; b=VgwsAoo3TbcUNr//x4Pu9f5GOT2JFGENJDr0M+2pYOEF+J+iwmjvbX/xJNp7h7nIlK UWcZUpRL0MNxHzi/+2OCGI4OIeSloWxvV3pDjpcfO48IsQhhCwRq2YT2uLLloRTZhHs7 qGC5BElFXty1KcXXW2i4xr+WfCpxpYtcWcum0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708667272; x=1709272072; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FLgAnoMtXtOoP/MT58Z1R1M569JvS4pDWEpHe4CcF8k=; b=vhArMhnu7GzpCeWzSnCeufxkhVdoaRfeJ74l/Sck3ZcvygLzuAzSIvzhG9GC5TMt5c s/k5308TDga74jiCccqDO0JCuuj5v9dZAENOiGouNxAK3MG1kceHl/ZsVGsC8dXV520A jUK6Qr3htQAEN/KlI+DWrJerkTfYZ+qtIxvo0WgfMedq1lw3kFj9OQ4h1xqcswr456G6 dflBtXpqX2y/VfD4iR5QvJ1fr7X6wbUeMbImHjA63SMOmOYXQrLoj3q18WWTV182mjjd rrT9upnU5kvDruh1QqgPHYEBAbI5NBQix6YPtzdPcsmGYtu0s9ztK0im8yJ7hCocmnQh 0FRw== X-Forwarded-Encrypted: i=1; AJvYcCXETFT7kZ/aXNlMRInJbsp2gEUK//vNEot8CIF7M7wkisZCl18Q8iIiJB3ywwJ116hWaH6bZGzTmL6/MCrz/Wi3H7B1JA8Jro0DROkI X-Gm-Message-State: AOJu0YyFPW5Ky5jG4OyJbSkj13i+KfnvqhBRDZvVgdytUqOTBaSqgvYu TBj3DrIFe557oI1DmDGIRVeXlMq58HJ2d9bycJGfNkYzSu1B1VHxh3gliJbJDQ== X-Received: by 2002:a05:6830:1e2d:b0:6e4:3e64:b0b with SMTP id t13-20020a0568301e2d00b006e43e640b0bmr1203384otr.12.1708667272328; Thu, 22 Feb 2024 21:47:52 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:b194:4f71:568a:eeb0]) by smtp.gmail.com with ESMTPSA id s2-20020a632c02000000b005dc98d9114bsm11471557pgs.43.2024.02.22.21.47.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 21:47:52 -0800 (PST) Date: Fri, 23 Feb 2024 14:47:48 +0900 From: Sergey Senozhatsky To: Chengming Zhou Cc: hannes@cmpxchg.org, Andrew Morton , Sergey Senozhatsky , nphamcs@gmail.com, yosryahmed@google.com, Minchan Kim , linux-mm@kvack.org, Chengming Zhou , linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND 2/3] mm/zsmalloc: remove_zspage() don't need fullness parameter Message-ID: <20240223054748.GR11472@google.com> References: <20240220-b4-zsmalloc-cleanup-v1-0-b7e9cbab9541@linux.dev> <20240220-b4-zsmalloc-cleanup-v1-2-b7e9cbab9541@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240220-b4-zsmalloc-cleanup-v1-2-b7e9cbab9541@linux.dev> On (24/02/20 11:44), Chengming Zhou wrote: > From: Chengming Zhou > > We must remove_zspage() from its current fullness list, then use > insert_zspage() to update its fullness and insert to new fullness list. > Obviously, remove_zspage() doesn't need the fullness parameter. > > Signed-off-by: Chengming Zhou Reviewed-by: Sergey Senozhatsky